Merged
Conversation
wachunei
approved these changes
Dec 16, 2020
ibrahimtaveras00
suggested changes
Jan 12, 2021
Contributor
ibrahimtaveras00
left a comment
There was a problem hiding this comment.
Issue 1:
When on iOS and going through the onboarding wizard, when I'm all the way on browser, and go back to the wallet, the wizard disappears and I'm stuck until I tap skip tutorial
seen here = https://recordit.co/8r4u7d2j9h
Issue 2:
When you're on android and you are backing up seed phrase, when you tap and then deselect the pills they remove the text and is no longer legible
seen here:
# Conflicts: # ios/Podfile.lock # package.json
# Conflicts: # android/app/build.gradle # ios/MetaMask.xcodeproj/project.pbxproj # ios/Podfile.lock # package.json # yarn.lock
rickycodes
added a commit
that referenced
this pull request
Feb 25, 2021
* develop: (48 commits) Fix input state (#2265) bump android versionCode (#2260) bugfix/use bignumber for transfer deeplinks (#2257) Fix account list scroll (#2256) TransactionController from controllers (#2243) Fix circleci apk (#2240) v1.0.11 (#2238) Feature/warn when replacing (#2176) contract metadata images bump (#2233) Handle `balanceError` case (#2148) Remove best deals badge from WYRE transfers. (#2228) @metamask/controllers@6.0.1 (#2217) Fix cloudflare redirects (#2180) Merge pull request from GHSA-wmvx-96jh-gcr4 Update @metamask/contract-metadata (#2203) React Native update to 0.63 (#2078) Create dependabot.yml (#2204) Fix "Text strings must be rendered within a <Text> component" (#2193) Use navigate instead of push (#2191) Add fiat on ramp modal close button extra hit area (#2174) ...
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Files modified * Yellow box to logbox and keyboard aware and eslint lib update * Update react navigation and fix inputs size * Update scrollview tests * keyring unit test * More scroll view unit testing update * Fix typo * Updating password unit tests * snaps * circle * 9 * CURRENT_PROJECT_VERSION * xcodeversioncircleci * gesture-handler * lock * xcodeversioncircleci * xcodeversioncircleci * xcodeagain * intallbundler * faraday * v * fastlane * bumps * ifdebug * Fix detox for android and ios builds * Fix tutorial on iOS and backup on android * Update yarn.lock * Remove ignore from ci * Update unit tests Co-authored-by: Esteban Mino <efmino@uc.cl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates React Native from 0.62.2 to 0.63.4:
https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.4
@ibrahimtaveras00 Important to note that:
Issue
Resolves #2065