Conversation
brunobar79
approved these changes
Aug 2, 2018
Contributor
brunobar79
left a comment
There was a problem hiding this comment.
Dude, this is amazing... Not sure if you realized but this is like 60% of the entire app!
👍 x 💯
app/components/App/index.js
Outdated
Contributor
There was a problem hiding this comment.
Should we pass the engine to the browser too or that's where the provider fits?
Contributor
Author
There was a problem hiding this comment.
I think we will need an engine instance in the browser as well. The provider will facilitate communication from the dapp <-> app, but once we hit the app, (which will most likely be via the browser module), we need to call engine methods.
app/core/Engine.js
Outdated
Contributor
There was a problem hiding this comment.
Alphabetic ordered imports 😍
Contributor
Author
There was a problem hiding this comment.
I may or may not be a little OCD.
estebanmino
added a commit
that referenced
this pull request
Apr 22, 2021
* Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com>
sethkfman
added a commit
that referenced
this pull request
Apr 22, 2021
* scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com>
sethkfman
added a commit
that referenced
this pull request
Jun 2, 2021
* updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * e2e testing * modified build script to generate debug app for testing * added pod file install into code prep * moved pod install to e2e workflow * update e2e * updated e2e * updated e2e script * added back envs * updated e2e * updated e2e * updated code_setup & e2e * updated detox script * added test deploy * commented out steps for testing * updated build announce to use bitrise script * added bitrise announcement script * refactored bitrise scripts to reflect the notion workflows * added new yarn step to audit dependencies * removing scripts and using yarn e2e test * moved the trigger * updated yarn audit command * updated e2e * updated e2e * updated build scripts to generate release and added dependency for android test release * test-android-build * generic-file-storage * file-downloader * Revert "file-downloader" This reverts commit db69ef5. * Download keystore * moved keystore download up in the workflow * updated keystore pull script * updated keystore pull script * added file downloader * added file downloader * uploaded keystore file android test * updated android release * updated release build to pull keystore from bitrise * update android bitrise deploy * added android e2e workflow and updated release signing config * commented out e2e * uncommented e2e setup * uncommented e2e * updated file format * uncommented e2e * comment e2e * uncommented e2e * formatting bitrise file * updated build scripts to use release * swaped password for release * test ios release * updated yarn steps * update slack bot script * added group test release * run android test release * updated announce script * update triggers and typos * update to test ios build * updated build type for pre-release * ios app generation * ios app generation * updated iOS builds * use bitrise xcode deploy * update ios release steps * added deploy to itunes connect * formatting * updated node version * udpated node version * Bitrise yml bump version (#2535) * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * iOS build update * iOS build update * added android and ios in a single release build * added android and ios in a single release build * updated iOS release * updated iOS release * updated iOS release * updated iOS release * added android to test_release * test iOS build with export options * test iOS build with export options * setup android release build * fix action condition (#2576) * updated export options to include provisioning profile and added deploy to bitrise steps to ios * bump_version * start_release_builds * androidthenios * cachepull * before_run * deploy-to-itunesconnect * onefirsttheother * iosfirst * comments * updated slack announce script * uncommented deploy and slack announce * testing full release (#2582) * testing full release * Bump version name Co-authored-by: github-actions <github-actions@github.com> * update ios deploy step * removed test comment (#2584) * removed test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * testing android google play staging * increased versionCode & PROJECT VERSION * added iOS build * added test comment (#2585) * added test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * run android only deploy * run ios only deploy * run ios only deploy * run ios only deploy * Release/testbuild patch (#2589) * Swaps: BSC Support (#2468) * Swaps: Add cache thresholds configuration (#2514) * removed test comments * Bump version name Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * removed fastlane files and minor tweaks to scripts * updated e2e tests * updated e2e tests * updated yarn steps e2e * updated android scripts * updated build scrips and yml * updated e2e builds * remove CircleCi yml * added circleci script back * added emulator print out command * updated ios e2e test steps * removed devices * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * removed starting emulators * updated emulator name * avd list * avd creation * updated bitrise to tigger for v2.3.0 release build test * updated bundler version * updated build script * updated build script * updated change log with hide zero balance change (#2623) * updated version name * updated android emulator name * added build comments and verbose logging for tests * added build comments and refactored test inits * testing parallel deploys * added comments * formatting * moved code snipets * modified build triggers * modified build triggers * added deploy steps for parallel deploy * updated triggers * updated trigger * updated change log * stop caching * update build triggers * update build triggers * update audit script * testing parallel deployment * testing parallel deployment * testing parallel deployment * disable release in circleCI * testing parallel deployment * updated deploy directory * updated deploy step * deploy apk * updated changelog (#2648) * updated deploy scripts * remove code coverage * updated provisioning profile name * updated provisioning profile name * updated version for test 2.3.1 * updated provisioning profile * update provisioning profile * added fastlane and gemfiles back * disabled circle CI and added back slack bot announcement * commented all CI related tasks * revert bitrise specific scripting * commented out bitrise release triggers * removed ci commneted code * reverted script changes * minor syntax tweaks to scripts * updated the bitrise version to match package Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request integrates GABA into the application. Every method on every controller is now available in the wallet view, so we can start creating keyrings, accounts, adding tokens, etc. Most of the effort involved was yak shaving on the GABA side to fix bugs, modify module formats, etc.
Note: Disregard the temporary and insanely ugly test screen.
Checklist
Issue
N/A