Merged
Conversation
Contributor
Author
|
Updated UI on both Android and iOS. Latest demo:
|
Contributor
|
looks awesome @brunobar79 @cjeria want to make sure you see this! early next week let's chat and nail down the structure / navigation? I have some questions, esp about the per-currency transaction list |
bitpshr
suggested changes
Aug 7, 2018
Contributor
There was a problem hiding this comment.
This looks really great, and is extremely clean given the amount of code being added at once. This establishes a large portion of the UI and maintains high code quality throughout. Major PR!
Most comments are minor repeated comments that are stylistic or documentation oriented, with a few questions around blockies.js and shim.js.
.eslintignore
Outdated
| @@ -0,0 +1,3 @@ | |||
| /app/entry.node.js | |||
| /app/entry-web3.node.js | |||
Contributor
There was a problem hiding this comment.
After rebasing, I believe we'll be able to remove both of these /app/* entries.
.eslintignore
Outdated
| @@ -0,0 +1,3 @@ | |||
| /app/entry.node.js | |||
| /app/entry-web3.node.js | |||
| shim.js | |||
Contributor
There was a problem hiding this comment.
I'm still a little confused why need to keep shim.js in the repository at all, too. Won't we always do at least an npm install and a build before releasing to an app store? Would we ever really rely on what's last pushed to the repository?
| /android/app/src/main/assets/entry.js | ||
| /app/entry-web3.js | ||
| /app/entry.js | ||
| /shim.js |
Contributor
There was a problem hiding this comment.
See comment above about keeping shim.js in the repository.
| node_modules | ||
| package-lock.json | ||
| package.json | ||
| app/util/blockies.js |
Contributor
There was a problem hiding this comment.
Can we use https://www.npmjs.com/package/blockies or a git ref NPM module instead?
Contributor
Author
There was a problem hiding this comment.
I've tried using a couple of packages and none of them worked correctly. The extension is doing the same thing here and I think the reason for that is this commit: MetaMask/metamask-extension@1b89ceb
| import { colors, fontStyles } from '../../styles/common'; | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| wrapper: { |
Contributor
There was a problem hiding this comment.
I think GH is just rendering this weirdly, but could you be sure to run npm run format and commit the result? I want to make sure indentation is OK (it looks like it's fine when I view the raw file.)
Contributor
Author
There was a problem hiding this comment.
Just did it and this file wasn't affected by prettier so I assume it's github (?)
Contributor
Author
There was a problem hiding this comment.
Also checked on my local. LGTM
| @@ -0,0 +1,22 @@ | |||
| export default { | |||
Contributor
There was a problem hiding this comment.
Can we document this? What is this used for, what are the colors associated with them?
| writeFile: jest.fn() | ||
| })); | ||
|
|
||
| Date.now = jest.fn(() => 123); |
Contributor
There was a problem hiding this comment.
Smart; I could've used this on the bridge tests.
Contributor
Author
There was a problem hiding this comment.
The main reason I did this was because the tests were breaking... Every time I'd regenerate the snaps, t would generate a new key, and I think react-navigation internally uses a timestamp, so that fixed it.
index.js
Outdated
| import './shim.js'; | ||
| import 'crypto'; // eslint-disable-line import/no-nodejs-modules | ||
| import 'react-native-browser-polyfill'; // eslint-disable-line import/no-commonjs | ||
| // Fix for https://github.com/facebook/react-native/issues/5667 |
Contributor
There was a problem hiding this comment.
What's the fix? Importing shim.js, or importing crypto? It's unclear based on this comment's placement.
| # to a new version of aes-js, we patch it by removing the erroneous line. | ||
| echo "6. Fix aes-js build ouput..." | ||
| AES_OUTPUT_FILE="node_modules/aes-js/index.js"; | ||
| sed -i '' -e 's/var previous_mymodule = root.mymodule;//g' $AES_OUTPUT_FILE; |
Contributor
There was a problem hiding this comment.
Nit: can we add a newline between these two?
shim.js
Outdated
| @@ -0,0 +1,30 @@ | |||
| if(typeof global.self === "undefined") | |||
Contributor
There was a problem hiding this comment.
See my comment above about not including this in the repository.
estebanmino
added a commit
that referenced
this pull request
Apr 22, 2021
* Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com>
sethkfman
added a commit
that referenced
this pull request
Apr 22, 2021
* scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com>
sethkfman
added a commit
that referenced
this pull request
Jun 2, 2021
* updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * e2e testing * modified build script to generate debug app for testing * added pod file install into code prep * moved pod install to e2e workflow * update e2e * updated e2e * updated e2e script * added back envs * updated e2e * updated e2e * updated code_setup & e2e * updated detox script * added test deploy * commented out steps for testing * updated build announce to use bitrise script * added bitrise announcement script * refactored bitrise scripts to reflect the notion workflows * added new yarn step to audit dependencies * removing scripts and using yarn e2e test * moved the trigger * updated yarn audit command * updated e2e * updated e2e * updated build scripts to generate release and added dependency for android test release * test-android-build * generic-file-storage * file-downloader * Revert "file-downloader" This reverts commit db69ef5. * Download keystore * moved keystore download up in the workflow * updated keystore pull script * updated keystore pull script * added file downloader * added file downloader * uploaded keystore file android test * updated android release * updated release build to pull keystore from bitrise * update android bitrise deploy * added android e2e workflow and updated release signing config * commented out e2e * uncommented e2e setup * uncommented e2e * updated file format * uncommented e2e * comment e2e * uncommented e2e * formatting bitrise file * updated build scripts to use release * swaped password for release * test ios release * updated yarn steps * update slack bot script * added group test release * run android test release * updated announce script * update triggers and typos * update to test ios build * updated build type for pre-release * ios app generation * ios app generation * updated iOS builds * use bitrise xcode deploy * update ios release steps * added deploy to itunes connect * formatting * updated node version * udpated node version * Bitrise yml bump version (#2535) * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * iOS build update * iOS build update * added android and ios in a single release build * added android and ios in a single release build * updated iOS release * updated iOS release * updated iOS release * updated iOS release * added android to test_release * test iOS build with export options * test iOS build with export options * setup android release build * fix action condition (#2576) * updated export options to include provisioning profile and added deploy to bitrise steps to ios * bump_version * start_release_builds * androidthenios * cachepull * before_run * deploy-to-itunesconnect * onefirsttheother * iosfirst * comments * updated slack announce script * uncommented deploy and slack announce * testing full release (#2582) * testing full release * Bump version name Co-authored-by: github-actions <github-actions@github.com> * update ios deploy step * removed test comment (#2584) * removed test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * testing android google play staging * increased versionCode & PROJECT VERSION * added iOS build * added test comment (#2585) * added test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * run android only deploy * run ios only deploy * run ios only deploy * run ios only deploy * Release/testbuild patch (#2589) * Swaps: BSC Support (#2468) * Swaps: Add cache thresholds configuration (#2514) * removed test comments * Bump version name Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * removed fastlane files and minor tweaks to scripts * updated e2e tests * updated e2e tests * updated yarn steps e2e * updated android scripts * updated build scrips and yml * updated e2e builds * remove CircleCi yml * added circleci script back * added emulator print out command * updated ios e2e test steps * removed devices * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * removed starting emulators * updated emulator name * avd list * avd creation * updated bitrise to tigger for v2.3.0 release build test * updated bundler version * updated build script * updated build script * updated change log with hide zero balance change (#2623) * updated version name * updated android emulator name * added build comments and verbose logging for tests * added build comments and refactored test inits * testing parallel deploys * added comments * formatting * moved code snipets * modified build triggers * modified build triggers * added deploy steps for parallel deploy * updated triggers * updated trigger * updated change log * stop caching * update build triggers * update build triggers * update audit script * testing parallel deployment * testing parallel deployment * testing parallel deployment * disable release in circleCI * testing parallel deployment * updated deploy directory * updated deploy step * deploy apk * updated changelog (#2648) * updated deploy scripts * remove code coverage * updated provisioning profile name * updated provisioning profile name * updated version for test 2.3.1 * updated provisioning profile * update provisioning profile * added fastlane and gemfiles back * disabled circle CI and added back slack bot announcement * commented all CI related tasks * revert bitrise specific scripting * commented out bitrise release triggers * removed ci commneted code * reverted script changes * minor syntax tweaks to scripts * updated the bitrise version to match package Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
sethkfman
added a commit
that referenced
this pull request
Jun 17, 2021
* Add missing required prop in tests (#2727) * Add resolution for ws to address security vuln (#2737) * Add iconUrls to allowed list of keys (#2728) Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> * Feature/use same media player (#2711) * Use same media player * Remove unused react-native-video-controls * Remove SVG and image toggle * Add onBack * Update snapshot * only change one heading * Use scaling * Feature/bitrise circle ci hybrid (#2713) * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * e2e testing * modified build script to generate debug app for testing * added pod file install into code prep * moved pod install to e2e workflow * update e2e * updated e2e * updated e2e script * added back envs * updated e2e * updated e2e * updated code_setup & e2e * updated detox script * added test deploy * commented out steps for testing * updated build announce to use bitrise script * added bitrise announcement script * refactored bitrise scripts to reflect the notion workflows * added new yarn step to audit dependencies * removing scripts and using yarn e2e test * moved the trigger * updated yarn audit command * updated e2e * updated e2e * updated build scripts to generate release and added dependency for android test release * test-android-build * generic-file-storage * file-downloader * Revert "file-downloader" This reverts commit db69ef5. * Download keystore * moved keystore download up in the workflow * updated keystore pull script * updated keystore pull script * added file downloader * added file downloader * uploaded keystore file android test * updated android release * updated release build to pull keystore from bitrise * update android bitrise deploy * added android e2e workflow and updated release signing config * commented out e2e * uncommented e2e setup * uncommented e2e * updated file format * uncommented e2e * comment e2e * uncommented e2e * formatting bitrise file * updated build scripts to use release * swaped password for release * test ios release * updated yarn steps * update slack bot script * added group test release * run android test release * updated announce script * update triggers and typos * update to test ios build * updated build type for pre-release * ios app generation * ios app generation * updated iOS builds * use bitrise xcode deploy * update ios release steps * added deploy to itunes connect * formatting * updated node version * udpated node version * Bitrise yml bump version (#2535) * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * iOS build update * iOS build update * added android and ios in a single release build * added android and ios in a single release build * updated iOS release * updated iOS release * updated iOS release * updated iOS release * added android to test_release * test iOS build with export options * test iOS build with export options * setup android release build * fix action condition (#2576) * updated export options to include provisioning profile and added deploy to bitrise steps to ios * bump_version * start_release_builds * androidthenios * cachepull * before_run * deploy-to-itunesconnect * onefirsttheother * iosfirst * comments * updated slack announce script * uncommented deploy and slack announce * testing full release (#2582) * testing full release * Bump version name Co-authored-by: github-actions <github-actions@github.com> * update ios deploy step * removed test comment (#2584) * removed test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * testing android google play staging * increased versionCode & PROJECT VERSION * added iOS build * added test comment (#2585) * added test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * run android only deploy * run ios only deploy * run ios only deploy * run ios only deploy * Release/testbuild patch (#2589) * Swaps: BSC Support (#2468) * Swaps: Add cache thresholds configuration (#2514) * removed test comments * Bump version name Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * removed fastlane files and minor tweaks to scripts * updated e2e tests * updated e2e tests * updated yarn steps e2e * updated android scripts * updated build scrips and yml * updated e2e builds * remove CircleCi yml * added circleci script back * added emulator print out command * updated ios e2e test steps * removed devices * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * removed starting emulators * updated emulator name * avd list * avd creation * updated bitrise to tigger for v2.3.0 release build test * updated bundler version * updated build script * updated build script * updated change log with hide zero balance change (#2623) * updated version name * updated android emulator name * added build comments and verbose logging for tests * added build comments and refactored test inits * testing parallel deploys * added comments * formatting * moved code snipets * modified build triggers * modified build triggers * added deploy steps for parallel deploy * updated triggers * updated trigger * updated change log * stop caching * update build triggers * update build triggers * update audit script * testing parallel deployment * testing parallel deployment * testing parallel deployment * disable release in circleCI * testing parallel deployment * updated deploy directory * updated deploy step * deploy apk * updated changelog (#2648) * updated deploy scripts * remove code coverage * updated provisioning profile name * updated provisioning profile name * updated version for test 2.3.1 * updated provisioning profile * update provisioning profile * added fastlane and gemfiles back * disabled circle CI and added back slack bot announcement * commented all CI related tasks * revert bitrise specific scripting * commented out bitrise release triggers * removed ci commneted code * reverted script changes * minor syntax tweaks to scripts * updated the bitrise version to match package Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> * Bugfix/fix ws resolution (#2742) * Revert "Add resolution for ws to address security vuln (#2737)" This reverts commit e2226ca. * Use improved-yarn-audit and exclude 1748 * Convert token id to hexadecimal for collectible transfer (#2703) * Convert token id to hexadecimal for transfer * Add test for toHexadecimal Co-authored-by: Ricky Miller <ricky.miller@gmail.com> * make null conversionrate safe (#2706) Co-authored-by: ricky <ricky.miller@gmail.com> * @metamask/mobile-provider@2.1.0 (#2626) * @metamask/mobile-provider@2.1.0 * yarn * bugfix/notifications reducer (#2741) * Feature/simplify custom gas (#2738) * Use single method for fast/average/slow * Use newly added constants * Educate gas fees (#2611) Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> * On-Ramp: Refactor and Wyre countries (#2617) Co-authored-by: Esteban Miño <efmino@uc.cl> * Swaps: Allow every token on user wallet to be swapped (#2701) * Swaps: Update Market price unavailable and Price impact text (#2702) Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> * @metamask/controllers@10.1.0 (#2749) * bump * bump * yarn * bugfix/notification visibility (#2746) * isvisible * onfinished * removeonappstate * Circleci fix (#2757) * reintallpods * min9.0 * order * circleci * 12.5 * branch * v2.5.0 (#2748) * Bump * Update CHANGELOG.md * add heading back * bump to 748 * bump date as well * Use MediaPlayer (#2759) * Use MediaPlayer * height -> HEIGHT * Add isInteraction: false (#2777) * Fix: empty state when using fiat on non-mainnet transactions (#2776) * Add mainnet condition * Implement secondary values * Design adjustments * Fix boldness * Update test Co-authored-by: ricky <ricky.miller@gmail.com> * update CHANGELOG.md (#2796) * update changelog * update * bump version code * Updated config.yml * Optional chaining dollarBalance (#2809) * bumped version and updated changelog (#2810) * bumped version and updated changelog * removed config.yml update * removed changelog Co-authored-by: ricky <ricky.miller@gmail.com> Co-authored-by: Andre Pimenta <andrepimenta7@gmail.com> Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: Alex Donesky <alex.donesky@consensys.net>
sethkfman
added a commit
that referenced
this pull request
Jul 23, 2021
* VERSION_NAME * e2e testing * modified build script to generate debug app for testing * added pod file install into code prep * moved pod install to e2e workflow * update e2e * updated e2e * updated e2e script * added back envs * updated e2e * updated e2e * updated code_setup & e2e * updated detox script * added test deploy * commented out steps for testing * updated build announce to use bitrise script * added bitrise announcement script * refactored bitrise scripts to reflect the notion workflows * added new yarn step to audit dependencies * removing scripts and using yarn e2e test * moved the trigger * updated yarn audit command * updated e2e * updated e2e * updated build scripts to generate release and added dependency for android test release * test-android-build * generic-file-storage * file-downloader * Revert "file-downloader" This reverts commit db69ef5. * Download keystore * moved keystore download up in the workflow * updated keystore pull script * updated keystore pull script * added file downloader * added file downloader * uploaded keystore file android test * updated android release * updated release build to pull keystore from bitrise * update android bitrise deploy * added android e2e workflow and updated release signing config * commented out e2e * uncommented e2e setup * uncommented e2e * updated file format * uncommented e2e * comment e2e * uncommented e2e * formatting bitrise file * updated build scripts to use release * swaped password for release * test ios release * updated yarn steps * update slack bot script * added group test release * run android test release * updated announce script * update triggers and typos * update to test ios build * updated build type for pre-release * ios app generation * ios app generation * updated iOS builds * use bitrise xcode deploy * update ios release steps * added deploy to itunes connect * formatting * updated node version * udpated node version * Bitrise yml bump version (#2535) * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * iOS build update * iOS build update * added android and ios in a single release build * added android and ios in a single release build * updated iOS release * updated iOS release * updated iOS release * updated iOS release * added android to test_release * test iOS build with export options * test iOS build with export options * setup android release build * fix action condition (#2576) * updated export options to include provisioning profile and added deploy to bitrise steps to ios * bump_version * start_release_builds * androidthenios * cachepull * before_run * deploy-to-itunesconnect * onefirsttheother * iosfirst * comments * updated slack announce script * uncommented deploy and slack announce * testing full release (#2582) * testing full release * Bump version name Co-authored-by: github-actions <github-actions@github.com> * update ios deploy step * removed test comment (#2584) * removed test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * testing android google play staging * increased versionCode & PROJECT VERSION * added iOS build * added test comment (#2585) * added test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * run android only deploy * run ios only deploy * run ios only deploy * run ios only deploy * Release/testbuild patch (#2589) * Swaps: BSC Support (#2468) * Swaps: Add cache thresholds configuration (#2514) * removed test comments * Bump version name Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * removed fastlane files and minor tweaks to scripts * updated e2e tests * updated e2e tests * updated yarn steps e2e * updated android scripts * updated build scrips and yml * updated e2e builds * remove CircleCi yml * added circleci script back * added emulator print out command * updated ios e2e test steps * removed devices * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * removed starting emulators * updated emulator name * avd list * avd creation * updated bitrise to tigger for v2.3.0 release build test * updated bundler version * updated build script * updated build script * updated change log with hide zero balance change (#2623) * updated version name * updated android emulator name * added build comments and verbose logging for tests * added build comments and refactored test inits * testing parallel deploys * added comments * formatting * moved code snipets * modified build triggers * modified build triggers * added deploy steps for parallel deploy * updated triggers * updated trigger * updated change log * stop caching * update build triggers * update build triggers * update audit script * testing parallel deployment * testing parallel deployment * testing parallel deployment * disable release in circleCI * testing parallel deployment * updated deploy directory * updated deploy step * deploy apk * updated changelog (#2648) * updated deploy scripts * remove code coverage * updated provisioning profile name * updated provisioning profile name * updated version for test 2.3.1 * updated provisioning profile * update provisioning profile * added fastlane and gemfiles back * updated bitrise config * updated conflicts * removed conflicts * yarn.lock update * test deploy build * e2e updates * updated for e2e testing * updated android e2e step * android e2e test prep * added updates to ios e2e * build min update for e2e test * updated ios e2e * switched to debug e2e tests * updated debug e2e scripts * updated detox commands * updated ios e2e steps * build release * removed kill-start server * added the restart server adb * shifted iOS to debug build for e2e * update release script * ios release build * updated sentry script * updated sentry script path * updated sentry paths and install * test release * triggered tests * updated ios e2e for Detox Utils * break out build & test * split fix syntax issue * fix syntax issue * updated e2e tests * updated e2e * ios e2e update * test ios e2e * updated timeout * updated ios to use yarn * added cache e2e ios * added cache e2e ios * run both e2e tests * removed fastlane, updated version bump to use a variable * updated script print out and workflow * test release * removed console.log, cleaned up comments, fix regex on bump * updated target version * setup final workflow state * updated bitrise.yml formatting uncommented deploy to store and uncommented bump * reset the min sdk version * removed duplicate detox install * version number update * reformatted yml Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
sethkfman
added a commit
that referenced
this pull request
Aug 5, 2021
* Add missing required prop in tests (#2727) * Add resolution for ws to address security vuln (#2737) * Add iconUrls to allowed list of keys (#2728) Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> * Feature/use same media player (#2711) * Use same media player * Remove unused react-native-video-controls * Remove SVG and image toggle * Add onBack * Update snapshot * only change one heading * Use scaling * Feature/bitrise circle ci hybrid (#2713) * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * e2e testing * modified build script to generate debug app for testing * added pod file install into code prep * moved pod install to e2e workflow * update e2e * updated e2e * updated e2e script * added back envs * updated e2e * updated e2e * updated code_setup & e2e * updated detox script * added test deploy * commented out steps for testing * updated build announce to use bitrise script * added bitrise announcement script * refactored bitrise scripts to reflect the notion workflows * added new yarn step to audit dependencies * removing scripts and using yarn e2e test * moved the trigger * updated yarn audit command * updated e2e * updated e2e * updated build scripts to generate release and added dependency for android test release * test-android-build * generic-file-storage * file-downloader * Revert "file-downloader" This reverts commit db69ef5. * Download keystore * moved keystore download up in the workflow * updated keystore pull script * updated keystore pull script * added file downloader * added file downloader * uploaded keystore file android test * updated android release * updated release build to pull keystore from bitrise * update android bitrise deploy * added android e2e workflow and updated release signing config * commented out e2e * uncommented e2e setup * uncommented e2e * updated file format * uncommented e2e * comment e2e * uncommented e2e * formatting bitrise file * updated build scripts to use release * swaped password for release * test ios release * updated yarn steps * update slack bot script * added group test release * run android test release * updated announce script * update triggers and typos * update to test ios build * updated build type for pre-release * ios app generation * ios app generation * updated iOS builds * use bitrise xcode deploy * update ios release steps * added deploy to itunes connect * formatting * updated node version * udpated node version * Bitrise yml bump version (#2535) * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * iOS build update * iOS build update * added android and ios in a single release build * added android and ios in a single release build * updated iOS release * updated iOS release * updated iOS release * updated iOS release * added android to test_release * test iOS build with export options * test iOS build with export options * setup android release build * fix action condition (#2576) * updated export options to include provisioning profile and added deploy to bitrise steps to ios * bump_version * start_release_builds * androidthenios * cachepull * before_run * deploy-to-itunesconnect * onefirsttheother * iosfirst * comments * updated slack announce script * uncommented deploy and slack announce * testing full release (#2582) * testing full release * Bump version name Co-authored-by: github-actions <github-actions@github.com> * update ios deploy step * removed test comment (#2584) * removed test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * testing android google play staging * increased versionCode & PROJECT VERSION * added iOS build * added test comment (#2585) * added test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * run android only deploy * run ios only deploy * run ios only deploy * run ios only deploy * Release/testbuild patch (#2589) * Swaps: BSC Support (#2468) * Swaps: Add cache thresholds configuration (#2514) * removed test comments * Bump version name Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * removed fastlane files and minor tweaks to scripts * updated e2e tests * updated e2e tests * updated yarn steps e2e * updated android scripts * updated build scrips and yml * updated e2e builds * remove CircleCi yml * added circleci script back * added emulator print out command * updated ios e2e test steps * removed devices * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * removed starting emulators * updated emulator name * avd list * avd creation * updated bitrise to tigger for v2.3.0 release build test * updated bundler version * updated build script * updated build script * updated change log with hide zero balance change (#2623) * updated version name * updated android emulator name * added build comments and verbose logging for tests * added build comments and refactored test inits * testing parallel deploys * added comments * formatting * moved code snipets * modified build triggers * modified build triggers * added deploy steps for parallel deploy * updated triggers * updated trigger * updated change log * stop caching * update build triggers * update build triggers * update audit script * testing parallel deployment * testing parallel deployment * testing parallel deployment * disable release in circleCI * testing parallel deployment * updated deploy directory * updated deploy step * deploy apk * updated changelog (#2648) * updated deploy scripts * remove code coverage * updated provisioning profile name * updated provisioning profile name * updated version for test 2.3.1 * updated provisioning profile * update provisioning profile * added fastlane and gemfiles back * disabled circle CI and added back slack bot announcement * commented all CI related tasks * revert bitrise specific scripting * commented out bitrise release triggers * removed ci commneted code * reverted script changes * minor syntax tweaks to scripts * updated the bitrise version to match package Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> * Bugfix/fix ws resolution (#2742) * Revert "Add resolution for ws to address security vuln (#2737)" This reverts commit e2226ca. * Use improved-yarn-audit and exclude 1748 * Convert token id to hexadecimal for collectible transfer (#2703) * Convert token id to hexadecimal for transfer * Add test for toHexadecimal Co-authored-by: Ricky Miller <ricky.miller@gmail.com> * make null conversionrate safe (#2706) Co-authored-by: ricky <ricky.miller@gmail.com> * @metamask/mobile-provider@2.1.0 (#2626) * @metamask/mobile-provider@2.1.0 * yarn * bugfix/notifications reducer (#2741) * Feature/simplify custom gas (#2738) * Use single method for fast/average/slow * Use newly added constants * Educate gas fees (#2611) Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> * On-Ramp: Refactor and Wyre countries (#2617) Co-authored-by: Esteban Miño <efmino@uc.cl> * Swaps: Allow every token on user wallet to be swapped (#2701) * Swaps: Update Market price unavailable and Price impact text (#2702) Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> * @metamask/controllers@10.1.0 (#2749) * bump * bump * yarn * bugfix/notification visibility (#2746) * isvisible * onfinished * removeonappstate * Circleci fix (#2757) * reintallpods * min9.0 * order * circleci * 12.5 * branch * v2.5.0 (#2748) * Bump * Update CHANGELOG.md * add heading back * bump to 748 * bump date as well * Use MediaPlayer (#2759) * Use MediaPlayer * height -> HEIGHT * Add isInteraction: false (#2777) * Fix: empty state when using fiat on non-mainnet transactions (#2776) * Add mainnet condition * Implement secondary values * Design adjustments * Fix boldness * Update test Co-authored-by: ricky <ricky.miller@gmail.com> * update CHANGELOG.md (#2796) * update changelog * update * bump version code * Updated config.yml * Optional chaining dollarBalance (#2809) * bumped version and updated changelog (#2810) * bumped version and updated changelog * removed config.yml update * removed changelog * Lionbridge latest translations for secret recovery phrase and subtitle files (#2743) * updated translation files with latest translations for secret recovery phrase * added subtitles to secret phrase videos * added english subtitles * added urls for translations and updated video players to show subtitles * updated subtitle location * updated translation files with latest secret recovery text * removed subtitle logic from player * update translations * Review Translations (#2806) * Lionbridge * Lionbridge * Client Update * Lionbridge Co-authored-by: Brennan <Mark.Brennan@lionbridge.com> Co-authored-by: !corpitSVCUFC <!corpitSVCUFC@corpnet.liox.org> * bumped version and updated changelog * Update subtitles-en.vtt removed formatting * Optional chaining dollarBalance (#2809) * bumped version and updated changelog * moved files into folder * removed duplicate swaps section * updated video and subtitle location Co-authored-by: Brennan <Mark.Brennan@lionbridge.com> Co-authored-by: !corpitSVCUFC <!corpitSVCUFC@corpnet.liox.org> Co-authored-by: Andre Pimenta <andrepimenta7@gmail.com> * bumped version (#2843) * Don't render swap router address in recents (#2823) * Don't render swap router address in recents, fixes: #2822 * Use getSwapsContractAddress * rename toLowerCaseCompare to toLowerCaseEquals * Update test * Rename * Remove Picker deprecation warning (#2709) Use @react-native-community/picker * Improvement/react navigation upgrade 5 (#2731) * Move to new dependencies * move navigation.getparam to route.params * add navigationOptions * Fix dismiss and drawer working * Fix remaining route params * Fix switch navigator and fiat on ramp nav * Fix routename and pop * Remove screen props * Fix deeplink navigation * Fix navigation for inner screens * Ignore navigation warning * Fix get route * Fix showing protect wallet modal * Add route to proptypes * Add more missing proptypes * Update tests * Fix some more navigations * Update collectibles navigatoin * Use useNavigation * Use optional chaining on `dangerouslyGetParent()` * Removing ?? null and ?? undefined * Reorganize nav imports in App/index * Update findRouteNameFromNavigatorState * Remove noop functions * Adding testing for navigation * Add more navigation tests * Add comment explaining the test files * Remove unnecessary boolean casting * Remove unnecessary variable * Remove unnecessary boolean casting * Fixes navigation issues * Fix navigation issues * Fix QR scanner * fixed enroll navigation reset issue * Fix going to wallet view * updated test cases * Fix simple notification * Fix going to onboarding * added snapshots to test * fixed what new modal test * added picker to package.json * yarn clean * yarn update command * snapshot update * removed the dive method on the wrapper * snapshot update * update yarn unit test * commented out cache in build step * Bug/fix nft gesture experience (#2862) * Fix collections modal * Make eslint happy * Clean up modal code TODO: Converting components into hooks will save us from re-renders and from doing things like waiting to focus on inputs * Remove in-house safe area from reusable modal for now * Fix scroll interaction in collectible modal action sheet * Use color from overlay * Add test snap files * Update snapshots and make tests pass * uncommented cache for bitrise Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: Cal Leung <cleun007@gmail.com> * Swaps: Fix isZero undefined error (#2883) * Fix time formatting on transactions (#2854) * [Optimism] Feature/custom network gas estimates (#2865) * Move to new dependencies * move navigation.getparam to route.params * add navigationOptions * Fix dismiss and drawer working * Fix remaining route params * Fix switch navigator and fiat on ramp nav * Fix routename and pop * Remove screen props * Fix deeplink navigation * Fix navigation for inner screens * Ignore navigation warning * Fix get route * Fix showing protect wallet modal * Add route to proptypes * Add more missing proptypes * Update tests * Fix some more navigations * Update collectibles navigatoin * Use useNavigation * Use optional chaining on `dangerouslyGetParent()` * Removing ?? null and ?? undefined * Reorganize nav imports in App/index * Update findRouteNameFromNavigatorState * Remove noop functions * Adding testing for navigation * Add more navigation tests * Add comment explaining the test files * Remove unnecessary boolean casting * Remove unnecessary variable * Remove unnecessary boolean casting * Fixes navigation issues * Fix navigation issues * Fix QR scanner * fixed enroll navigation reset issue * Fix going to wallet view * updated test cases * Fix simple notification * Fix going to onboarding * added snapshots to test * fixed what new modal test * added picker to package.json * yarn clean * yarn update command * snapshot update * removed the dive method on the wrapper * snapshot update * update yarn unit test * added logic for gas calculations on custom networks identified by the network controller * added test controller * updated path for temp controller * updated for local file ref * update lock for local dep * updated dep * disable cache * updated dep * updated dep * added stub for getTokenListState * removed cache comments * removed console.log * updated spacing * update token list get and added todo * added undefined check * updated the logic for contractMap:wq * updated logic for token list * updated getTokensList * updated lock file * cache commented on bitrise * updated yarn * added resolutions for pbkdf * updated package * added resolutions * updated controllers and engine code * updated snapshots * refactor conditional * Remove hard coded upper limit to gas limit (#2884) * updated controller version * updated yarn lock Co-authored-by: andrepimenta <andrepimenta7@gmail.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: Dan J Miller <danjm.com@gmail.com> Co-authored-by: ricky <ricky.miller@gmail.com> * RC - v2.6.0 * RC v2.6.0 - yarn lock update & version code bump (#2888) * fixed yarn lock file, deleted local contrller, updated package * updated lock * updated lock * version code bump * Remove broken optional native dependency (#2882) All native dependencies that fail to compile when installing have been removed from the project. The only remaining example of this was a transitive dependency of `dnode`, which was an unused direct dependency. It has been removed. It was not imported anywhere, but it was referenced as a variable name in one unused module. This module has also been removed. * Fix prop type warning (#2821) * fix prop type warning * update snapshot * RC 2.6.0 - SWAPS fix (#2900) * added optional to pop call and bumped version code * trigger rc 2.6.0 build * remove RC build trigger * moved changelogs Co-authored-by: ricky <ricky.miller@gmail.com> Co-authored-by: Andre Pimenta <andrepimenta7@gmail.com> Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: Alex Donesky <alex.donesky@consensys.net> Co-authored-by: Brennan <Mark.Brennan@lionbridge.com> Co-authored-by: !corpitSVCUFC <!corpitSVCUFC@corpnet.liox.org> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Dan J Miller <danjm.com@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* navbar with icons * fix statusbar color * decent progress * clean up * added gradient bg * added roboto font * clean up * fixed icons and navigation flow * updated UI. working on both platforms * fix warning * added tests * added assets * fixed tests * singleton works * engine singleton and redux * fix tests * clean up eslintigore * fix eslint ignore * add shim.js back to .gitignore * fix AccountOverview * Accounts => AccountList * added comments for doc purposes * more clean up * more cleaning * more comments * let xcode cleanup stuff * fix tests
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * e2e testing * modified build script to generate debug app for testing * added pod file install into code prep * moved pod install to e2e workflow * update e2e * updated e2e * updated e2e script * added back envs * updated e2e * updated e2e * updated code_setup & e2e * updated detox script * added test deploy * commented out steps for testing * updated build announce to use bitrise script * added bitrise announcement script * refactored bitrise scripts to reflect the notion workflows * added new yarn step to audit dependencies * removing scripts and using yarn e2e test * moved the trigger * updated yarn audit command * updated e2e * updated e2e * updated build scripts to generate release and added dependency for android test release * test-android-build * generic-file-storage * file-downloader * Revert "file-downloader" This reverts commit db69ef5. * Download keystore * moved keystore download up in the workflow * updated keystore pull script * updated keystore pull script * added file downloader * added file downloader * uploaded keystore file android test * updated android release * updated release build to pull keystore from bitrise * update android bitrise deploy * added android e2e workflow and updated release signing config * commented out e2e * uncommented e2e setup * uncommented e2e * updated file format * uncommented e2e * comment e2e * uncommented e2e * formatting bitrise file * updated build scripts to use release * swaped password for release * test ios release * updated yarn steps * update slack bot script * added group test release * run android test release * updated announce script * update triggers and typos * update to test ios build * updated build type for pre-release * ios app generation * ios app generation * updated iOS builds * use bitrise xcode deploy * update ios release steps * added deploy to itunes connect * formatting * updated node version * udpated node version * Bitrise yml bump version (#2535) * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * iOS build update * iOS build update * added android and ios in a single release build * added android and ios in a single release build * updated iOS release * updated iOS release * updated iOS release * updated iOS release * added android to test_release * test iOS build with export options * test iOS build with export options * setup android release build * fix action condition (#2576) * updated export options to include provisioning profile and added deploy to bitrise steps to ios * bump_version * start_release_builds * androidthenios * cachepull * before_run * deploy-to-itunesconnect * onefirsttheother * iosfirst * comments * updated slack announce script * uncommented deploy and slack announce * testing full release (#2582) * testing full release * Bump version name Co-authored-by: github-actions <github-actions@github.com> * update ios deploy step * removed test comment (#2584) * removed test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * testing android google play staging * increased versionCode & PROJECT VERSION * added iOS build * added test comment (#2585) * added test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * run android only deploy * run ios only deploy * run ios only deploy * run ios only deploy * Release/testbuild patch (#2589) * Swaps: BSC Support (#2468) * Swaps: Add cache thresholds configuration (#2514) * removed test comments * Bump version name Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * removed fastlane files and minor tweaks to scripts * updated e2e tests * updated e2e tests * updated yarn steps e2e * updated android scripts * updated build scrips and yml * updated e2e builds * remove CircleCi yml * added circleci script back * added emulator print out command * updated ios e2e test steps * removed devices * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * removed starting emulators * updated emulator name * avd list * avd creation * updated bitrise to tigger for v2.3.0 release build test * updated bundler version * updated build script * updated build script * updated change log with hide zero balance change (#2623) * updated version name * updated android emulator name * added build comments and verbose logging for tests * added build comments and refactored test inits * testing parallel deploys * added comments * formatting * moved code snipets * modified build triggers * modified build triggers * added deploy steps for parallel deploy * updated triggers * updated trigger * updated change log * stop caching * update build triggers * update build triggers * update audit script * testing parallel deployment * testing parallel deployment * testing parallel deployment * disable release in circleCI * testing parallel deployment * updated deploy directory * updated deploy step * deploy apk * updated changelog (#2648) * updated deploy scripts * remove code coverage * updated provisioning profile name * updated provisioning profile name * updated version for test 2.3.1 * updated provisioning profile * update provisioning profile * added fastlane and gemfiles back * disabled circle CI and added back slack bot announcement * commented all CI related tasks * revert bitrise specific scripting * commented out bitrise release triggers * removed ci commneted code * reverted script changes * minor syntax tweaks to scripts * updated the bitrise version to match package Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
Open
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.