Skip to content

fix: QA Bugs cp-7.53.0#17976

Merged
chaitanyapotti merged 13 commits into
mainfrom
fix/qa-bugs-1
Aug 6, 2025
Merged

fix: QA Bugs cp-7.53.0#17976
chaitanyapotti merged 13 commits into
mainfrom
fix/qa-bugs-1

Conversation

@smgv

@smgv smgv commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name
  Scenario: user [verb for user action]
    Given [describe expected initial app state] 
    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Screen.Recording.2025-08-05.at.8.52.58.PM.mov
Screen.Recording.2025-08-05.at.9.10.11.PM.mov
Screenshot 2025-08-05 at 8 58 32 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@smgv smgv requested a review from chaitanyapotti August 5, 2025 16:25
@smgv smgv self-assigned this Aug 5, 2025
@smgv smgv added area-onboarding needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E team-onboarding Onboarding team labels Aug 5, 2025
@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c38cc58
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/965dbb71-3ea8-46df-af12-9e48d13662d4

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@smgv smgv requested a review from ieow August 5, 2025 17:06
@smgv smgv changed the title Fix/qa bugs 1 fix: QA Bugs Aug 5, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@LeVinhGithub LeVinhGithub added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 6, 2025
@LeVinhGithub

Copy link
Copy Markdown
Contributor

lgtm

cursor[bot]

This comment was marked as outdated.

@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5d3bdab
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/906c47ce-ecd8-4f9a-afc8-05b513edb620

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Aug 6, 2025
@chaitanyapotti chaitanyapotti removed this pull request from the merge queue due to a manual request Aug 6, 2025
@chaitanyapotti chaitanyapotti changed the title fix: QA Bugs fix: QA Bugs cp-7.53.0 Aug 6, 2025
@chaitanyapotti chaitanyapotti added this pull request to the merge queue Aug 6, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Aug 6, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

- Bug 1: #17888 (It
only fix the RevealCredential Fix other part is fixed in #17976

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name
  Scenario: user [verb for user action]
    Given [describe expected initial app state] 
    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

Bug 1: #17888

### **After**

<!-- [screenshots/recordings] -->



https://github.com/user-attachments/assets/fc9bfec7-6f99-477e-ae3c-9f0ba25d8b78



## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Merged via the queue into main with commit 210c48e Aug 6, 2025
60 of 63 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/qa-bugs-1 branch August 6, 2025 09:21
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-onboarding QA Passed QA testing has been completed and passed release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-onboarding Onboarding team

Projects

None yet

5 participants