Skip to content

fix: action view update to get the scrollview cp-7.53.0#17987

Merged
chaitanyapotti merged 6 commits into
mainfrom
fix/action-view-update
Aug 6, 2025
Merged

fix: action view update to get the scrollview cp-7.53.0#17987
chaitanyapotti merged 6 commits into
mainfrom
fix/action-view-update

Conversation

@smgv

@smgv smgv commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name
  Scenario: user [verb for user action]
    Given [describe expected initial app state] 
    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Bug 1: #17888

After

Screen.Recording.2025-08-05.at.8.58.41.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@smgv smgv requested a review from chaitanyapotti August 5, 2025 16:59
@smgv smgv self-assigned this Aug 5, 2025
@smgv smgv added area-onboarding needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E team-onboarding Onboarding team labels Aug 5, 2025
@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bd471a8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e4d68313-033c-443e-a51e-7bc4545062ef

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@smgv smgv requested a review from ieow August 5, 2025 17:06
cursor[bot]

This comment was marked as outdated.

Sign in to view

@LeVinhGithub LeVinhGithub added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 6, 2025
@LeVinhGithub

LeVinhGithub commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

lgtm

@github-actions

github-actions Bot commented Aug 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9f4a445
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/09f47304-652a-4ec1-991e-10ab8a95114b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Aug 6, 2025
@chaitanyapotti chaitanyapotti removed this pull request from the merge queue due to a manual request Aug 6, 2025
@chaitanyapotti chaitanyapotti changed the title fix: action view update to get the scrollview fix: action view update to get the scrollview cp-7.53.0 Aug 6, 2025
@chaitanyapotti chaitanyapotti added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 58f3c76 Aug 6, 2025
62 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/action-view-update branch August 6, 2025 09:18
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@chaitanyapotti chaitanyapotti linked an issue Aug 6, 2025 that may be closed by this pull request
[Bug]: The password field is hidden by keyboard, cannot scroll at SRP reveal flow and the private key import #17888
Closed
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

@ieow ieow Awaiting requested review from ieow

Assignees

@smgv smgv

Labels

area-onboarding QA Passed QA testing has been completed and passed release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-onboarding Onboarding team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: The password field is hidden by keyboard, cannot scroll at SRP reveal flow and the private key import

5 participants

@smgv @LeVinhGithub @chaitanyapotti @metamaskbot @tommasini