feat: multichain manual import#14400
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
bd74ffb to
4a4d9a4
Compare
556ca3c to
4f509d5
Compare
Contributor
|
657d56e to
5d9093d
Compare
Contributor
|
dd26967 to
5e3e0d2
Compare
Contributor
|
Prithpal-Sooriya
approved these changes
Apr 10, 2025
gambinish
approved these changes
Apr 10, 2025
7 tasks
github-merge-queue Bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 10, 2025
## **Description** Fixes a bug introduced into 12.16.0 RC in this PR: MetaMask/metamask-mobile#14400 Bug was that users could enter into a state where they could send NFTs on a different network than they belonged on. This is because we are now showing NFTs across all chains that a user has NFTs on, rather than the constrained to the GNS currentChain. Users could enter into NFT send flow in two ways: 1. Via the NFT detail screen. We proactively change the network on the users behalf if they enter the send flow this way (press Send from the detail screen of a NFT from a different chain) 2. Via the Send button on the main NFT Grid view. This is where the bug was caught. When entering into the send flow in this way, users could enter into a state where they could accidentally send an NFT on a different chain than intended. View recording below to visualize this difference. This fix filters out NFTs in the second flow so that they only ever show NFTs from the globally selected chain. [](https://codespaces.new/MetaMask/metamask-extension/pull/31850?quickstart=1) ## **Related issues** Fixes: #31858 ## **Manual testing steps** 1. Add account with NFTs on a network 2. Enter into Send flow as specified in flow 2 3. NFTs should only be listed on network that they are on. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/user-attachments/assets/b35ec707-fe42-4212-8343-446a048758fc ### **After** https://github.com/user-attachments/assets/eafe05fd-9950-4446-b79e-0d5773e724d1 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Nicholas Gambino <nicholas.gambino@consensys.net>
gambinish
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 10, 2025
## **Description** Fixes a bug introduced into 12.16.0 RC in this PR: MetaMask/metamask-mobile#14400 Bug was that users could enter into a state where they could send NFTs on a different network than they belonged on. This is because we are now showing NFTs across all chains that a user has NFTs on, rather than the constrained to the GNS currentChain. Users could enter into NFT send flow in two ways: 1. Via the NFT detail screen. We proactively change the network on the users behalf if they enter the send flow this way (press Send from the detail screen of a NFT from a different chain) 2. Via the Send button on the main NFT Grid view. This is where the bug was caught. When entering into the send flow in this way, users could enter into a state where they could accidentally send an NFT on a different chain than intended. View recording below to visualize this difference. This fix filters out NFTs in the second flow so that they only ever show NFTs from the globally selected chain. [](https://codespaces.new/MetaMask/metamask-extension/pull/31850?quickstart=1) ## **Related issues** Fixes: #31858 ## **Manual testing steps** 1. Add account with NFTs on a network 2. Enter into Send flow as specified in flow 2 3. NFTs should only be listed on network that they are on. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/user-attachments/assets/b35ec707-fe42-4212-8343-446a048758fc ### **After** https://github.com/user-attachments/assets/eafe05fd-9950-4446-b79e-0d5773e724d1 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Nicholas Gambino <nicholas.gambino@consensys.net>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the goal of this PR is to make the manual import token multichain
design:
https://www.figma.com/design/CvBEDNwQqfW4Wbil40Bhr1/Substitute-Global-Network-selector?t=7VlJYKwbd0ONMpnl-0
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
search.mov
custom.mov
Pre-merge author checklist
Pre-merge reviewer checklist