Description

Fixes a bug introduced into 12.16.0 RC

Bug was that users could enter into a state where they could send NFTs on a different network than they belonged on. This is because we are now showing NFTs across all chains that a user has NFTs on, rather than the constrained to the GNS currentChain.

Users could enter into NFT send flow in two ways:

1. Via the NFT detail screen. We proactively change the network on the users behalf if they enter the send flow this way (press Send from the detail screen of a NFT from a different chain)

2. Via the Send button on the main NFT Grid view. This is where the bug was caught. When entering into the send flow in this way, users could enter into a state where they could accidentally send an NFT on a different chain than intended.

View recording below to visualize this difference.

This fix filters out NFTs in the second flow so that they only ever show NFTs from the globally selected chain.

Related issues

Fixes: #31858

Manual testing steps

1. Add account with NFTs on a network
2. Enter into Send flow as specified in flow 2
3. NFTs should only be listed on network that they are on.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.