Description

This PR enables the account balances for non evm accounts (Solana) to be renders in the Account Selector List. This change was achieved by leveraging the existing logic in the useMultichainBalances hook which is already used in production to display both evm and non evm account balances for the selected account on the main wallet page. I had to expand this logic to not only derive the balance for the selected account on the selected chain but instead to derive the balances for all accounts. This way we can lookup the MultichainBalancesData (defined in useMultichainBalances.types.ts) in a map where the key is the account ID. The key changes that enabled this change were the following...

1. multichain.ts

   • refactor some of the balance selector to use util functions so that they could be reused.
   • created a new selector called selectMultichainNetworkAggregatedBalanceForAllAccounts which, uses the same logic as selectSelectedAccountMultichainNetworkAggregatedBalance except for all accounts and returns a map of account ids and MultichainNetworkAggregatedBalance

2. useMultichainBalances.ts

   • modified the return type of this hook so that it returns a map of account balance data and account ids as well as one single object for the selected account. The return type looks like this...

export interface UseMultichainBalancesHook {
  multichainBalancesForAllAccounts: Record<
    InternalAccount['id'],
    MultichainBalancesData
  >;
  selectedAccountMultichainBalance?: MultichainBalancesData;
}

• I also had to decouple the the hook from the currently selected chainId. This means that we must select the evmChainId (either currently selected or previously selected chainId), and the nonEvmChainId (either currently selected or previously selected)

3. useAccounts.ts

   • removed all of the balance computation inside the useAccounts hook (mostly through the getAccountBalances util that I removed) in favour of the results from the useMultichainBalances hook.
   • Memoized many of the functions in this hook.

4. Engine.ts

   • renamed getTotalFiatAccountBalance to getTotalEvmFiatAccountBalance
   • Modified getTotalEvmFiatAccountBalance to take an optional InternalAccount param that allows this function to derive the evm balance for a specified account not just the currently selected account
   • Modified the getTotalEvmFiatAccountBalance to use TokenController.allTokens instead of TokenController.tokens which is tied to the currently selected account

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/697

Manual testing steps

1. ensure you are building flask by verifying that your .js.env file contains export METAMASK_BUILD_TYPE="flask"
2. yarn setup && yarn start:ios
3. Import an account that has a balance, I can provide you with an SRP from 1Password if needed.
4. click on "add account or hardware wallet"
5. click on Solana account
6. Once the account is created, open the account selector list
7. The balance that is rendered on the right side of the the cell should match the balance rendered on the main wallet view. It should show your total fiat balance which is the sum of all of your native tokens (ETH/SOL) plus the sum of all of your token balances (ERC20/SPL tokens). This fiat balance should be in your currently selected currency and it should also show your native token balance.
8. Changing your selected account between non evm and evm should not change the balances you see in the account list.
9. Both EVM and Solana balances should be correct
10. changing your selected currency should be reflected in balance in the accounts list.
11. If you switch the network to a test net, the fiat balance should not be rendered and instead you should see your token balance.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.