Skip to content

fix: Hide account list selector balance for non evm accounts#14379

Merged
owencraston merged 1 commit into
mainfrom
fix/hide-non-evm-account-selector-balance
Apr 2, 2025
Merged

fix: Hide account list selector balance for non evm accounts#14379
owencraston merged 1 commit into
mainfrom
fix/hide-non-evm-account-selector-balance

Conversation

@owencraston

@owencraston owencraston commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Description

This PR provides a temporary fix for an issue where the Solana account balances appear as "0 ETH" in the account selector list. A proper fix that renders the correct Soalana fiat/token balance in this list is being worked on here but for the sake of speed and to unblock the RC 7.44.0, we are going to simply hide this incorrect value. This approach was disussed and confirmed with Rizivi this morning.

The plan for this change to be cherry picked into rc 7.44.0 once it merges.

Related issues

Fixes: #14332

Manual testing steps

  1. ensure you are building flask by verifying that your .js.env file contains export METAMASK_BUILD_TYPE="flask"
  2. yarn setup && yarn start:ios
  3. create or import a wallet
  4. click on the account selector list
  5. click on add account of hardware wallet
  6. click on solana account
  7. notice that there is no data at all in the right section of the account selector list
  8. if you select the solana account, it should still render your balance in the main wallet page.

Screenshots/Recordings

Before

image

After

Screen.Recording.2025-04-02.at.9.29.20.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@owencraston owencraston marked this pull request as ready for review April 2, 2025 16:31
@owencraston owencraston requested a review from a team as a code owner April 2, 2025 16:31
@github-actions

github-actions Bot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f5180b2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/742632c6-ae3c-4be6-be0a-58da3a430cf7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud

sonarqubecloud Bot commented Apr 2, 2025

Copy link
Copy Markdown

@owencraston owencraston added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit 639a255 Apr 2, 2025
@owencraston owencraston deleted the fix/hide-non-evm-account-selector-balance branch April 2, 2025 19:10
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 2, 2025
@metamaskbot metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Apr 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.45.0 Issue or pull request that will be included in release 7.45.0 team-accounts-framework Accounts team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Accounts list show ETH for Solana accounts

3 participants