Merged
Conversation
The version bump script referenced the old file path for the manifest. It was stored as a single file called `manifest.json`, but it was split into `_base.json` and platform-specific manifests in #8140. The manifest version bump script has been updated to reference `_base.json`, which is the piece that has the version property.
Member
Author
|
I tested this locally by commenting out the last line (the
|
brad-decker
approved these changes
Jun 1, 2020
Collaborator
Builds ready [9706c40]
Page Load Metrics (656 ± 57 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version bump script referenced the old file path for the manifest. It was stored as a single file called
manifest.json, but it was split into_base.jsonand platform-specific manifests in #8140.The manifest version bump script has been updated to reference
_base.json, which is the piece that has the version property.