Skip to content

Consistent rounded corners on tx details modal/popup#8714

Merged
tmashuang merged 1 commit intodevelopfrom
round-transaction-details-corner
Jun 1, 2020
Merged

Consistent rounded corners on tx details modal/popup#8714
tmashuang merged 1 commit intodevelopfrom
round-transaction-details-corner

Conversation

@tmashuang
Copy link
Copy Markdown
Contributor

@tmashuang tmashuang commented Jun 1, 2020

Add bottom rounded corners for the tx details modal/popup

Before
After

@tmashuang tmashuang requested a review from a team as a code owner June 1, 2020 19:36
rekmarks
rekmarks approved these changes Jun 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 1, 2020

Builds ready [8f25fca]
Page Load Metrics (695 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30116502110
domContentLoaded38886769310751
load39086869510751
domInteractive38786669310751

@tmashuang tmashuang merged commit fb906e2 into develop Jun 1, 2020
@tmashuang tmashuang deleted the round-transaction-details-corner branch June 1, 2020 20:04
Gudahtt added a commit that referenced this pull request Jun 1, 2020
@Gudahtt
Merge remote-tracking branch 'origin/develop' into Version-v8.0.0
2a4704a 
* origin/develop:
  Fix manifest version bump script (#8715)
  Consistent rounded corners on tx details modal/popup (#8714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rekmarks rekmarks rekmarks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmashuang @metamaskbot @rekmarks