Merged
Conversation
The disk store has not been written to since MetaMask v4.3.0, as it was removed in MetaMask#3083. It was kept around so that anything written to disk prior to v4.3.0 could still be restored. It has been a year and a half since that release, so I think it's time to remove the disk store altogether. The consequences of losing locally stored data are small anyway - it's an inconvenience at worst.
whymarrh
approved these changes
Sep 16, 2019
Contributor
whymarrh
left a comment
There was a problem hiding this comment.
It has been a year and a half since that release, so I think it's time to remove the disk store altogether.
Agreed, LGTM
danfinlay
approved these changes
Sep 16, 2019
Contributor
danfinlay
left a comment
There was a problem hiding this comment.
Great catch. We should really have a process for recording some debt that should be removed at a later date. I guess it should've had an open issue with it.
Gudahtt
added a commit
that referenced
this pull request
Sep 17, 2019
…evelop * origin/develop: (31 commits) Performance: Delivery optimized images (#7176) Add `appName` message to each locale Remove the disk store (#7170) Update @hapi/subtext as per security advisory (#7172) Add fixes for German translations (#7168) Fix recipient field of approve screen (#7171) 3box integration 2.0 (#6972) ci - metamaskbot - include links to dep-viz and all artifacts (#7155) Replace `undefined` selectedAddress with `null` (#7161) Add polyfill for AbortController (#7157) Remove redundant error logging (#7158) Set minimum Firefox version to v56.2 to support Waterfox (#7156) ci - install deps with "--har" flag to capture network activity (#7143) ci - create source-map-explorer build-artifacts (#7141) ci - build-artifacts - generate sesify-viz for inspecting deps (#7151) Publish GitHub release from master branch (#7136) fix rinkeby spelling (#7148) deps - move gulp-terser-js to devDeps test:integration - fix renamed test data file lint fix ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disk store has not been written to since MetaMask v4.3.0, as it was replaced in #3083. It was kept around so that anything written to disk prior to v4.3.0 could still be restored.
It has been a year and a half since that release, so I think it's time to remove the disk store altogether. The consequences of losing locally stored data are small anyway - it's an inconvenience at worst.