Replace undefined selectedAddress with null#7161
Merged
Conversation
The `runtime.Port.postMessage` API will drop keys with a value of `undefined` on Chrome, but not on Firefox. This was a problem for the `publicConfig` stream, which passed the key `selectedAddress` with the value of `undefined` to communicate to dapps that the user had logged out. Instead a `null` is now passed for `selectedAddress` upon logout, which is correctly sent by the `runtime.Port.postMessage` API on both Chrome and Firefox. closes #7101 closes #7109
Member
Author
|
This will result in a public-facing change to the |
Collaborator
Builds ready [3870cfe]
|
Member
Author
|
We've decided that both |
danfinlay
approved these changes
Sep 12, 2019
danfinlay
requested changes
Sep 12, 2019
Contributor
danfinlay
left a comment
There was a problem hiding this comment.
Marking the request for an empty array.
The v3.0.0 update includes a change to the `accountsChanged` event. The event will now emit an empty array instead of an array with `undefined` or `null`. The previous behavior was to emit `[undefined]`. The previous commit would have changed that to `[null]` anyway, so we figured if we're going to make a public-facing change to the event anyway we should change it to be correct. `[undefined]` was never intended, and it technically violates EIP-1193, which states that the `accountsChanged` event should emit an array of strings.
danfinlay
approved these changes
Sep 12, 2019
Contributor
danfinlay
left a comment
There was a problem hiding this comment.
Yup, I just published that version of inpage-provider.
Collaborator
Builds ready [3c6e5fb]
|
danjm
approved these changes
Sep 13, 2019
Gudahtt
added a commit
that referenced
this pull request
Sep 13, 2019
* Replace `undefined` selectedAddress with `null` The `runtime.Port.postMessage` API will drop keys with a value of `undefined` on Chrome, but not on Firefox. This was a problem for the `publicConfig` stream, which passed the key `selectedAddress` with the value of `undefined` to communicate to dapps that the user had logged out. Instead a `null` is now passed for `selectedAddress` upon logout, which is correctly sent by the `runtime.Port.postMessage` API on both Chrome and Firefox. closes #7101 closes #7109 * Update `metamask-inpage-provider` to v3.0.0 The v3.0.0 update includes a change to the `accountsChanged` event. The event will now emit an empty array instead of an array with `undefined` or `null`. The previous behavior was to emit `[undefined]`. The previous commit would have changed that to `[null]` anyway, so we figured if we're going to make a public-facing change to the event anyway we should change it to be correct. `[undefined]` was never intended, and it technically violates EIP-1193, which states that the `accountsChanged` event should emit an array of strings.
Gudahtt
added a commit
that referenced
this pull request
Sep 17, 2019
…evelop * origin/develop: (31 commits) Performance: Delivery optimized images (#7176) Add `appName` message to each locale Remove the disk store (#7170) Update @hapi/subtext as per security advisory (#7172) Add fixes for German translations (#7168) Fix recipient field of approve screen (#7171) 3box integration 2.0 (#6972) ci - metamaskbot - include links to dep-viz and all artifacts (#7155) Replace `undefined` selectedAddress with `null` (#7161) Add polyfill for AbortController (#7157) Remove redundant error logging (#7158) Set minimum Firefox version to v56.2 to support Waterfox (#7156) ci - install deps with "--har" flag to capture network activity (#7143) ci - create source-map-explorer build-artifacts (#7141) ci - build-artifacts - generate sesify-viz for inspecting deps (#7151) Publish GitHub release from master branch (#7136) fix rinkeby spelling (#7148) deps - move gulp-terser-js to devDeps test:integration - fix renamed test data file lint fix ...
Gudahtt
added a commit
that referenced
this pull request
Sep 27, 2019
* origin/master: Add v7.2.2 to changelog Update minimum Firefox verison to 56.0 (#7213) Version v7.2.2 Update changelog for v7.2.1, v7.2.0, and v7.1.1 Add `appName` message to each locale Version v7.2.1 Update changelog with additional bug fixes Fix recipient field of approve screen (#7171) Replace `undefined` selectedAddress with `null` (#7161) Add polyfill for AbortController (#7157) Set minimum Firefox version to v56.2 to support Waterfox (#7156) Publish GitHub release from master branch (#7136) Update the changelog for v7.1.1 (#7145) build - replace gulp-uglify-es with gulp-terser-js Version v7.2.0 Update changelog with 7.2.0 changes Allow dismissing privacy mode from popup Add changelog Version v7.1.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
runtime.Port.postMessageAPI will drop keys with a value ofundefinedon Chrome, but not on Firefox. This was a problem for thepublicConfigstream, which passed the keyselectedAddresswith the value ofundefinedto communicate to dapps that the user had loggedout.
Instead a
nullis now passed forselectedAddressupon logout, which is correctly sent by theruntime.Port.postMessageAPI on both Chromeand Firefox.
Relevant Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1003439
closes #7101
closes #7109