feat: add `wallet_requestExecutionPermissions` method by jeffsmale90 · Pull Request #35193 · MetaMask/metamask-extension

jeffsmale90 · 2025-08-18T22:01:15Z

Adds the method wallet_requestExecutionPermissions which is defined in this proposed revision of the EIP-7715 specification ethereum/ERCs#1098.

Description

This method is proxied to @metamask/permissions-kernel-snap, which implements the exact same method. This snap will be preinstalled in Extension, before the feature is enabled for any users.

The feature is gated by process.env.EIP_7715_READABLE_PERMISSIONS_ENABLED and requires process.env.PERMISSIONS_KERNEL_SNAP_ID to be set. Presently EIP_7715_READABLE_PERMISSIONS_ENABLED is set to false, and PERMISSIONS_KERNEL_SNAP_ID is set to an empty string for all builds.

Requires MetaMask/eth-json-rpc-middleware#396 released in https://github.com/MetaMask/eth-json-rpc-middleware/releases/tag/v17.1.0. This change also adds support for wallet_revokePermission, which will be implemented in a future PR, once the revocation UI is implemented.

Changelog

CHANGELOG entry: As this is behind a local feature gate, there are no public facing changes.

Manual testing steps

Can be tested with MetaMask/smart-accounts-kit#60 which adds support to the delegation-toolkit's experimental api to call the wallet method directly, rather than via wallet_invokeSnap.

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-08-18T22:01:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-08-18T22:46:04Z

Builds ready [a82090e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1191 ± 70 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1191	1056	1418	70	1250	1315
			load	1006	858	1197	70	1061	1115
			domContentLoaded	998	854	1189	70	1055	1110
			domInteractive	17	14	39	5	17	31
			firstPaint	653	94	1196	398	1016	1107
			backgroundConnect	216	203	244	7	219	230
			firstReactRender	21	14	143	13	22	36
			getState	13	5	87	14	14	32
			initialActions	3	0	58	6	2	13
			loadScripts	790	653	969	69	844	898
			setupStore	8	5	17	2	9	11
	Webpack	Home	uiStartup	2869	2169	3715	260	3018	3272
			load	2269	1500	3102	299	2451	2817
			domContentLoaded	2254	1492	3095	294	2443	2800
			domInteractive	24	14	135	21	19	69
			firstPaint	237	79	587	86	296	380
			backgroundConnect	89	16	420	118	68	356
			firstReactRender	179	93	407	87	248	353
			getState	24	5	293	48	20	45
			initialActions	6	2	26	4	8	14
			loadScripts	2242	1489	3092	288	2428	2796
			setupStore	21	7	215	35	18	43
Firefox	Browserify	Home	uiStartup	1314	1103	1751	134	1374	1685
			load	1125	964	1459	90	1183	1296
			domContentLoaded	1125	964	1459	90	1183	1295
			domInteractive	99	34	424	56	102	216
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	17	123	14	30	62
			firstReactRender	24	20	51	7	23	50
			getState	7	2	41	8	6	32
			initialActions	4	0	51	8	2	14
			loadScripts	1105	949	1443	88	1162	1264
			setupStore	9	3	77	13	5	35
	Webpack	Home	uiStartup	1603	1367	2137	144	1677	1879
			load	1339	1137	1639	116	1422	1565
			domContentLoaded	1338	1137	1638	116	1421	1564
			domInteractive	97	30	288	54	97	267
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	18	92	10	33	55
			firstReactRender	52	40	72	7	56	63
			getState	9	4	49	8	8	26
			initialActions	3	0	27	4	3	13
			loadScripts	1316	1120	1618	115	1396	1545
			setupStore	10	4	175	18	8	27

Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 231 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2870 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2270 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 2254 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 24 exceeds gate value 21 for chrome webpack home mean domInteractive
Benchmark value 238 exceeds gate value 199 for chrome webpack home mean firstPaint
Benchmark value 90 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 2242 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 3272 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2817 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2800 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 70 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 380 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 356 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2797 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1685 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 216 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 267 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 55 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 2658ms | Sum of p95 exceeds: 3998.8ms
Sum of all benchmark exceeds: 6656.8ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -6.04 KiB (-0.13%)
ui: 3.83 KiB (0.05%)
common: -55.74 KiB (-0.74%)

metamaskbot · 2025-08-19T01:55:07Z

Builds ready [ed48de5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1190 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1190	1081	1393	64	1237	1303
			load	1011	896	1203	63	1058	1114
			domContentLoaded	1002	892	1190	62	1051	1103
			domInteractive	18	13	50	6	17	27
			firstPaint	619	84	1112	404	1014	1089
			backgroundConnect	221	204	268	12	225	250
			firstReactRender	20	13	39	5	21	30
			getState	11	5	90	10	13	24
			initialActions	3	0	25	4	3	13
			loadScripts	790	687	955	59	832	888
			setupStore	8	4	14	2	8	12
	Webpack	Home	uiStartup	2179	1631	2555	183	2268	2501
			load	1642	1224	1985	154	1699	1871
			domContentLoaded	1635	1220	1972	153	1694	1865
			domInteractive	18	11	96	17	13	66
			firstPaint	173	61	549	69	195	285
			backgroundConnect	31	12	330	43	29	49
			firstReactRender	189	82	407	111	320	387
			getState	38	4	306	83	10	283
			initialActions	5	2	20	3	5	13
			loadScripts	1631	1218	1962	152	1691	1854
			setupStore	23	6	304	57	13	102
Firefox	Browserify	Home	uiStartup	1320	1125	1840	118	1374	1536
			load	1134	977	1535	88	1182	1275
			domContentLoaded	1134	977	1535	88	1182	1274
			domInteractive	102	35	442	55	103	205
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	18	109	14	33	66
			firstReactRender	24	20	52	7	24	43
			getState	6	2	34	6	5	21
			initialActions	5	0	167	19	2	14
			loadScripts	1111	961	1516	88	1157	1246
			setupStore	8	3	56	11	6	39
	Webpack	Home	uiStartup	1581	1382	2208	151	1654	1948
			load	1316	1159	1720	120	1378	1540
			domContentLoaded	1316	1159	1720	121	1378	1540
			domInteractive	91	30	275	42	94	204
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	19	198	23	34	74
			firstReactRender	53	42	68	6	58	65
			getState	12	4	91	13	10	42
			initialActions	5	0	126	13	3	21
			loadScripts	1293	1133	1701	118	1357	1518
			setupStore	9	4	41	7	8	28

Benchmark value 221 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 250 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 38 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2501 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 387 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 283 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 102 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 205 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 39 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1948 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 204 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 74 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 42 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 259ms | Sum of p95 exceeds: 612.8ms
Sum of all benchmark exceeds: 871.8ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -6.44 KiB (-0.14%)
ui: 3.91 KiB (0.06%)
common: -55.33 KiB (-0.73%)

jiexi · 2025-08-26T16:20:33Z

app/scripts/metamask-controller.js

        },
        this.controllerMessenger,
      ),
+      processRequestExecutionPermissions:


after this feature is enabled and shipped, I'd love to rename this hook to plain old handleSnapRequest or something like that

Great idea! I have updated this to forwardRequestToSnap which I think is pretty clear about what it's doing. Presently it forwards the request to the specified snap verbatim, but in the future we could support a mapRequest function that could accept the incoming request and return the snap request, so that the publicly exposed method doesn't necessarily need to match exactly the snap method.

https://github.com/MetaMask/metamask-extension/pull/35193/files#diff-6fbff2cfe97ac01b77296ef2122c7e0a5b3ff6a84b584b4d1a87482f35eea3d6R2192

lmkwyt

V00D00-child · 2025-09-03T02:29:56Z

app/scripts/lib/transaction/eip7715.ts

+    );
+  }
+
+  const requestExecutionPermissionsResult = (await handleRequest({


Forwarding requests to the kernel-snap is a pattern that is similar to how we forward requests to gator-snap to fetch granted permissions. Should we move this to the GatorPermissionsController and expose via an action to the consumer?

Is there a strong reason why processRequestExecutionPermissions() can not live in the GatorPermissionsController?

Nice - in response to Jiexi's suggestion above, I've removed the bulk of EIP-7715 bespoke logic, and implemented a generic forwardRequestToSnap handler.

The only thing left is Kernel Snap Id, which is provided via environment - I think the Gator Permissions Controller should be accepting the snap Id from the same place, as it makes switching between environments really easy.

Adds methods `wallet_requestExecutionPermissions` and `wallet_revokeExecutionPermission`, as defined in this revision of the EIP-7715 specification ethereum/ERCs#1098. This supports Readable Permissions project, and is related to the following PRs: - MetaMask/smart-accounts-kit#60 - MetaMask/metamask-extension#35193 Note: workflows are failing due to existing problems, fixed by #397

…json-rpc-middleware upgrade.

jeffsmale90 · 2025-09-05T04:15:46Z

I have read the CLA Document and I hereby sign the CLA

…rdRequestToSnap' handler.

metamaskbot · 2025-09-08T01:04:57Z

📊 Page Load Benchmark Results

Current Commit: 3d19c3b | Date: 9/8/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.28s (±92ms) 🟡 | historical mean value: 1.31s ⬇️ (historical data)
domContentLoaded-> current mean value: 965ms (±89ms) 🟢 | historical mean value: 991ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 91ms (±38ms) 🟢 | historical mean value: 94ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.28s	92ms	1.25s	1.91s	1.34s	1.91s
domContentLoaded	965ms	89ms	932ms	1.57s	1.02s	1.57s
firstPaint	91ms	38ms	72ms	296ms	144ms	296ms
firstContentfulPaint	91ms	38ms	72ms	296ms	144ms	296ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-08T04:26:09Z

📊 Page Load Benchmark Results

Current Commit: 14d7f82 | Date: 9/8/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.32s (±112ms) 🟡 | historical mean value: 1.31s ⬆️ (historical data)
domContentLoaded-> current mean value: 995ms (±109ms) 🟢 | historical mean value: 991ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 97ms (±40ms) 🟢 | historical mean value: 94ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.32s	112ms	1.27s	1.95s	1.46s	1.95s
domContentLoaded	995ms	109ms	948ms	1.62s	1.13s	1.62s
firstPaint	97ms	40ms	76ms	280ms	204ms	280ms
firstContentfulPaint	97ms	40ms	76ms	280ms	204ms	280ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-08T04:32:55Z

Builds ready [ded62c4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1229 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1229	1097	1419	63	1277	1321
			load	1068	953	1261	63	1117	1166
			domContentLoaded	1060	948	1255	64	1109	1156
			domInteractive	17	14	49	5	17	24
			firstPaint	750	73	1220	419	1088	1160
			backgroundConnect	243	229	269	8	246	259
			firstReactRender	24	17	67	7	25	36
			getState	15	6	64	8	18	29
			initialActions	5	0	44	7	6	12
			loadScripts	824	709	1018	65	875	923
			setupStore	10	6	32	5	11	23
	Webpack	Home	uiStartup	1933	1461	2427	256	2126	2366
			load	1554	1185	1979	195	1681	1819
			domContentLoaded	1545	1175	1975	195	1673	1807
			domInteractive	17	11	110	16	14	65
			firstPaint	164	61	582	78	202	284
			backgroundConnect	37	17	332	52	31	62
			firstReactRender	76	37	333	44	76	129
			getState	21	5	280	50	13	27
			initialActions	5	2	17	2	6	8
			loadScripts	1541	1173	1965	193	1670	1796
			setupStore	14	6	293	28	13	22
Firefox	Browserify	Home	uiStartup	1425	1200	1975	134	1471	1683
			load	1233	1050	1465	85	1295	1385
			domContentLoaded	1232	1050	1465	85	1294	1385
			domInteractive	108	35	365	56	114	249
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	20	169	20	35	62
			firstReactRender	27	22	54	4	28	36
			getState	7	2	125	13	6	15
			initialActions	5	1	190	19	3	10
			loadScripts	1208	1033	1445	85	1269	1361
			setupStore	11	5	80	13	8	34
	Webpack	Home	uiStartup	1533	1313	2063	136	1611	1782
			load	1308	1117	1630	117	1390	1536
			domContentLoaded	1307	1117	1630	117	1390	1536
			domInteractive	102	30	291	60	96	277
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	22	103	10	37	43
			firstReactRender	42	35	54	4	44	50
			getState	6	3	32	4	6	10
			initialActions	5	0	194	19	3	6
			loadScripts	1283	1097	1612	118	1368	1512
			setupStore	9	5	72	7	9	20

Benchmark value 243 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 260 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 23 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1425 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1683 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 249 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 277 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 296ms | Sum of p95 exceeds: 485.8ms
Sum of all benchmark exceeds: 781.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.13 KiB (0.03%)
ui: 0 Bytes (0%)
common: 3.17 KiB (0.04%)

app/scripts/metamask-controller.js

builds.yml

app/scripts/lib/forwardRequestToSnap.ts

metamaskbot · 2025-09-08T18:15:56Z

📊 Page Load Benchmark Results

Current Commit: 9fdc885 | Date: 9/8/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.29s (±66ms) 🟡 | historical mean value: 1.31s ⬇️ (historical data)
domContentLoaded-> current mean value: 967ms (±63ms) 🟢 | historical mean value: 985ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 89ms (±22ms) 🟢 | historical mean value: 95ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.29s	66ms	1.26s	1.90s	1.34s	1.90s
domContentLoaded	967ms	63ms	942ms	1.56s	1.00s	1.56s
firstPaint	89ms	22ms	76ms	256ms	132ms	256ms
firstContentfulPaint	89ms	22ms	76ms	256ms	132ms	256ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-08T18:16:01Z

Builds ready [9fdc885]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1233 ± 74 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1233	1115	1421	74	1287	1366
			load	1074	958	1263	70	1122	1197
			domContentLoaded	1066	949	1256	71	1117	1191
			domInteractive	18	14	54	7	17	39
			firstPaint	578	78	1223	435	1074	1173
			backgroundConnect	245	233	275	7	249	257
			firstReactRender	24	17	42	6	27	39
			getState	12	5	30	5	15	23
			initialActions	5	1	29	4	6	13
			loadScripts	829	714	1018	70	877	952
			setupStore	9	6	26	3	9	17
	Webpack	Home	uiStartup	2074	1547	2747	264	2212	2491
			load	1666	1241	2107	203	1786	1924
			domContentLoaded	1655	1235	2085	201	1778	1901
			domInteractive	20	12	140	22	15	68
			firstPaint	168	60	503	71	178	323
			backgroundConnect	34	13	281	28	34	67
			firstReactRender	84	37	333	52	87	178
			getState	33	5	313	74	15	277
			initialActions	11	2	230	32	7	27
			loadScripts	1652	1232	2072	200	1774	1898
			setupStore	15	6	277	27	15	22
Firefox	Browserify	Home	uiStartup	1373	1180	1866	116	1436	1599
			load	1186	1039	1386	81	1255	1318
			domContentLoaded	1186	1038	1386	81	1254	1317
			domInteractive	99	33	272	45	102	213
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	19	133	20	36	82
			firstReactRender	27	22	63	7	29	41
			getState	7	2	185	18	6	13
			initialActions	4	1	73	8	3	11
			loadScripts	1160	1020	1369	79	1234	1287
			setupStore	11	4	167	17	8	31
	Webpack	Home	uiStartup	1608	1379	2097	156	1737	1876
			load	1365	1165	1640	132	1485	1606
			domContentLoaded	1365	1165	1640	132	1484	1605
			domInteractive	104	48	293	52	100	271
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	22	103	10	39	47
			firstReactRender	45	38	59	4	47	53
			getState	8	3	158	15	6	15
			initialActions	5	1	97	11	3	8
			loadScripts	1340	1146	1618	132	1458	1577
			setupStore	10	5	46	6	10	17

Benchmark value 1074 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1067 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 245 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1367 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1198 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1191 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 258 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 952 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 34 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2491 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 69 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 277 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 27 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 213 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 82 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 271 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 303ms | Sum of p95 exceeds: 602.8ms
Sum of all benchmark exceeds: 905.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.13 KiB (0.03%)
ui: -100 Bytes (0%)
common: 3.17 KiB (0.04%)

…'s handleSnapRequest function, rather than binding the call function on the ControllerMessenger

metamaskbot · 2025-09-08T19:28:33Z

📊 Page Load Benchmark Results

Current Commit: f34409f | Date: 9/8/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.30s (±55ms) 🟡 | historical mean value: 1.31s ⬇️ (historical data)
domContentLoaded-> current mean value: 975ms (±53ms) 🟢 | historical mean value: 985ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 90ms (±19ms) 🟢 | historical mean value: 95ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.30s	55ms	1.26s	1.79s	1.37s	1.79s
domContentLoaded	975ms	53ms	942ms	1.46s	1.02s	1.46s
firstPaint	90ms	19ms	72ms	176ms	140ms	176ms
firstContentfulPaint	90ms	19ms	72ms	176ms	140ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-08T19:28:47Z

Builds ready [f34409f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1258 ± 73 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1258	1130	1478	73	1309	1414
			load	1092	973	1316	69	1139	1244
			domContentLoaded	1085	969	1308	70	1133	1237
			domInteractive	18	13	55	6	17	33
			firstPaint	673	78	1317	439	1078	1188
			backgroundConnect	248	235	277	8	253	266
			firstReactRender	24	16	45	6	26	37
			getState	13	5	107	11	15	24
			initialActions	4	1	15	3	6	10
			loadScripts	844	726	1065	69	891	998
			setupStore	9	6	33	3	10	16
	Webpack	Home	uiStartup	2040	1547	2712	278	2222	2545
			load	1637	1241	2100	219	1780	1971
			domContentLoaded	1624	1227	2090	214	1765	1931
			domInteractive	20	12	143	21	14	67
			firstPaint	168	66	406	65	192	308
			backgroundConnect	38	20	349	43	34	78
			firstReactRender	83	37	334	58	87	313
			getState	31	5	324	67	16	268
			initialActions	6	2	40	5	6	15
			loadScripts	1617	1225	2077	210	1758	1916
			setupStore	18	6	297	39	14	25
Firefox	Browserify	Home	uiStartup	1560	1324	2087	131	1662	1767
			load	1365	1159	1653	116	1469	1555
			domContentLoaded	1365	1159	1652	116	1468	1555
			domInteractive	123	38	439	66	129	262
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	39	22	183	24	39	94
			firstReactRender	29	24	83	8	31	45
			getState	7	3	43	7	7	18
			initialActions	3	0	17	3	3	11
			loadScripts	1336	1139	1634	113	1433	1523
			setupStore	9	5	97	10	9	24
	Webpack	Home	uiStartup	1534	1360	1983	153	1639	1860
			load	1310	1157	1744	132	1428	1549
			domContentLoaded	1310	1157	1743	133	1428	1548
			domInteractive	102	31	415	64	94	269
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	21	112	12	35	45
			firstReactRender	43	34	83	6	45	51
			getState	6	3	114	11	6	9
			initialActions	4	1	133	13	3	5
			loadScripts	1287	1133	1720	132	1408	1504
			setupStore	8	5	24	3	8	13

Benchmark value 1259 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1093 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1085 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 249 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 845 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1414 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1245 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1238 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1189 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 266 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 999 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2545 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 268 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1561 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1366 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1365 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 124 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 40 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1336 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1767 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1555 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1555 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 262 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 94 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1523 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 269 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 5 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 897ms | Sum of p95 exceeds: 1160.8ms
Sum of all benchmark exceeds: 2057.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.06 KiB (0.02%)
ui: -100 Bytes (0%)
common: 3.17 KiB (0.04%)

app/scripts/lib/forwardRequestToSnap.test.ts

metamaskbot · 2025-09-08T20:46:54Z

📊 Page Load Benchmark Results

Current Commit: ae84b86 | Date: 9/8/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.27s (±21ms) 🟡 | historical mean value: 1.31s ⬇️ (historical data)
domContentLoaded-> current mean value: 949ms (±19ms) 🟢 | historical mean value: 988ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 87ms (±19ms) 🟢 | historical mean value: 96ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.27s	21ms	1.24s	1.39s	1.31s	1.39s
domContentLoaded	949ms	19ms	931ms	1.06s	991ms	1.06s
firstPaint	87ms	19ms	72ms	200ms	132ms	200ms
firstContentfulPaint	87ms	19ms	72ms	200ms	132ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-08T20:47:08Z

Builds ready [ae84b86]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1403 ± 70 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1403	1284	1640	70	1439	1541
			load	1191	1058	1437	78	1237	1326
			domContentLoaded	1167	1044	1428	85	1228	1315
			domInteractive	22	17	96	10	22	38
			firstPaint	882	175	1437	434	1209	1309
			backgroundConnect	299	260	426	40	297	412
			firstReactRender	40	19	157	29	43	129
			getState	18	5	91	12	22	36
			initialActions	8	1	72	11	9	23
			loadScripts	891	771	1152	86	950	1057
			setupStore	15	7	96	13	14	31
	Webpack	Home	uiStartup	2131	1613	2823	261	2256	2560
			load	1700	1277	2209	206	1819	2028
			domContentLoaded	1690	1266	2197	205	1810	2011
			domInteractive	21	12	120	21	15	88
			firstPaint	167	67	428	66	187	296
			backgroundConnect	41	20	364	47	35	73
			firstReactRender	97	40	339	59	98	264
			getState	28	5	319	62	16	267
			initialActions	6	2	29	4	7	16
			loadScripts	1686	1263	2184	203	1806	1998
			setupStore	16	7	189	18	16	25
Firefox	Browserify	Home	uiStartup	1414	1210	1914	121	1484	1646
			load	1222	1053	1497	90	1297	1359
			domContentLoaded	1221	1052	1497	90	1296	1359
			domInteractive	105	33	308	55	116	255
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	20	132	17	34	66
			firstReactRender	28	22	63	6	30	36
			getState	9	2	128	17	7	18
			initialActions	5	1	85	11	4	14
			loadScripts	1196	1036	1476	87	1266	1337
			setupStore	11	4	96	13	9	43
	Webpack	Home	uiStartup	1606	1420	1940	130	1691	1837
			load	1375	1197	1690	120	1473	1563
			domContentLoaded	1375	1197	1690	120	1472	1563
			domInteractive	110	61	291	60	101	273
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	22	46	6	36	42
			firstReactRender	45	35	71	5	47	54
			getState	6	3	21	2	7	11
			initialActions	4	1	55	6	4	8
			loadScripts	1352	1168	1664	121	1450	1540
			setupStore	9	5	29	3	9	15

Benchmark value 1403 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1191 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1167 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 22 exceeds gate value 20 for chrome browserify home mean domInteractive
Benchmark value 882 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 300 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 41 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 18 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 8 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 892 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 15 exceeds gate value 11 for chrome browserify home mean setupStore
Benchmark value 1542 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1327 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1315 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1310 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 413 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 129 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 36 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 23 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 1058 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 31 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 41 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 2560 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2011 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 88 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 267 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1998 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1415 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 255 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 43 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 111 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 273 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 920ms | Sum of p95 exceeds: 1681.8ms
Sum of all benchmark exceeds: 2601.8ms

metamaskbot added the team-delegation MetaMask Delegation Team label Aug 18, 2025

github-actions bot added the size-S label Aug 18, 2025

jeffsmale90 force-pushed the feat/eip7715_requestExecutionPermissions branch from f267a84 to a82090e Compare August 18, 2025 22:20

github-actions bot added size-M and removed size-S labels Aug 18, 2025

jeffsmale90 mentioned this pull request Aug 19, 2025

feat: add RPC methods described in (revised) EIP-7715 MetaMask/eth-json-rpc-middleware#396

Merged

jeffsmale90 force-pushed the feat/eip7715_requestExecutionPermissions branch from a82090e to ed48de5 Compare August 19, 2025 01:30

jeffsmale90 changed the title ~~Add wallet_requestExecutionPermissions method.~~ feat: add wallet_requestExecutionPermissions method Aug 19, 2025

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 19, 2025

jeffsmale90 mentioned this pull request Aug 19, 2025

Support calling wallet_requestExecutionPermissions directly on the wallet api MetaMask/smart-accounts-kit#60

Merged

8 tasks

jiexi reviewed Aug 26, 2025

View reviewed changes

jeffsmale90 mentioned this pull request Sep 3, 2025

feat: Add feature flag for gator permissions page #35307

Merged

7 tasks

V00D00-child reviewed Sep 3, 2025

View reviewed changes

Add wallet_requestExecutionPermissions method. Pending @metamask/eth-…

52fb362

…json-rpc-middleware upgrade.

jeffsmale90 force-pushed the feat/eip7715_requestExecutionPermissions branch from ed48de5 to 52fb362 Compare September 5, 2025 04:02

Update yarn.lock with updated @metamask/eth-json-rpc-middleware

157cb26

jeffsmale90 force-pushed the feat/eip7715_requestExecutionPermissions branch from c541fd4 to d1b4e31 Compare September 7, 2025 23:59

jeffsmale90 requested review from V00D00-child and jiexi September 8, 2025 00:04

jeffsmale90 marked this pull request as ready for review September 8, 2025 00:04

jeffsmale90 added 2 commits September 8, 2025 12:10

Remove EIP-7715 specific handler, replace with general purpose 'forwa…

b386533

…rdRequestToSnap' handler.

Merge branch 'main' into feat/eip7715_requestExecutionPermissions

83e35f3

jeffsmale90 force-pushed the feat/eip7715_requestExecutionPermissions branch from 167e2a7 to 83e35f3 Compare September 8, 2025 00:10

jeffsmale90 force-pushed the feat/eip7715_requestExecutionPermissions branch from d7a811b to 3073711 Compare September 8, 2025 01:27

Merge branch 'main' into feat/eip7715_requestExecutionPermissions

9fdc885

jiexi reviewed Sep 8, 2025

View reviewed changes

app/scripts/metamask-controller.js Outdated Show resolved Hide resolved

jiexi reviewed Sep 8, 2025

View reviewed changes

builds.yml Show resolved Hide resolved

jiexi reviewed Sep 8, 2025

View reviewed changes

app/scripts/lib/forwardRequestToSnap.ts Show resolved Hide resolved

Throw InternalError instead of JsonRpcError, pass Metamask Controller…

f34409f

…'s handleSnapRequest function, rather than binding the call function on the ControllerMessenger

This comment was marked as outdated.

Sign in to view

jiexi reviewed Sep 8, 2025

View reviewed changes

app/scripts/lib/forwardRequestToSnap.test.ts Outdated Show resolved Hide resolved

Update forwardRequestToSnap assertions to match thrown errors

1fc9e9c

jiexi previously approved these changes Sep 8, 2025

View reviewed changes

Remove errant import from test

3773043

jeffsmale90 dismissed jiexi’s stale review via 3773043 September 8, 2025 20:04

Merge branch 'main' into feat/eip7715_requestExecutionPermissions

ae84b86

jeffsmale90 enabled auto-merge September 8, 2025 21:23

hanzel98 approved these changes Sep 8, 2025

View reviewed changes

jiexi approved these changes Sep 8, 2025

View reviewed changes

ffmcgee725 approved these changes Sep 9, 2025

View reviewed changes

jeffsmale90 added this pull request to the merge queue Sep 9, 2025

Merged via the queue into main with commit 7d955c2 Sep 9, 2025
146 checks passed

jeffsmale90 deleted the feat/eip7715_requestExecutionPermissions branch September 9, 2025 09:44

github-actions bot locked and limited conversation to collaborators Sep 9, 2025

metamaskbot added the release-13.4.0 Issue or pull request that will be included in release 13.4.0 label Sep 9, 2025

Conversation

jeffsmale90 commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Manual testing steps

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Aug 18, 2025

Uh oh!

metamaskbot commented Aug 19, 2025

Uh oh!

jiexi Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

jeffsmale90 Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

V00D00-child Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

jeffsmale90 Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeffsmale90 commented Sep 5, 2025

Uh oh!

metamaskbot commented Sep 8, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 8, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Sep 8, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 8, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 8, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 8, 2025

Uh oh!

Uh oh!

metamaskbot commented Sep 8, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jeffsmale90 commented Aug 18, 2025 •

edited

Loading

github-actions bot commented Aug 18, 2025 •

edited

Loading

jeffsmale90 Sep 8, 2025 •

edited

Loading