This repository was archived by the owner on Oct 16, 2025. It is now read-only.
feat: add RPC methods described in (revised) EIP-7715#396
Merged
jeffsmale90 merged 5 commits intomainfrom Sep 3, 2025
Merged
Conversation
6eb865b to
4f8bc87
Compare
…ission to support EIP-7715
4f8bc87 to
f339980
Compare
7 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mcmire
reviewed
Aug 20, 2025
…to 5792 and 7715 async middleware to match correct naming.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ffmcgee725
previously approved these changes
Aug 26, 2025
jiexi
reviewed
Aug 26, 2025
jiexi
previously approved these changes
Aug 26, 2025
Member
There was a problem hiding this comment.
functionally LGTM. I have some concerns regarding spec about if isAdjustmentAllowed should even be included as it ultimately is a proxy for something optional and if something is not strictly required for execution then IMO it should not be included in the request by the dapp
Please ping for re-approval if you feel that my nit above is fair
adonesky1
reviewed
Aug 26, 2025
Comment on lines
+88
to
+89
| res.result = await processRequestExecutionPermissions(params, req); | ||
| } |
Contributor
There was a problem hiding this comment.
I believe you'll need to pass end in as a param as well for the JSON RPC Engine to handle this gracefully
Suggested change
| res.result = await processRequestExecutionPermissions(params, req); | |
| } | |
| res.result = await processRequestExecutionPermissions(params, req); | |
| return end() | |
| } |
Contributor
There was a problem hiding this comment.
I guess they aren't doing this in the 5792 methods you used as a model. Need to figure out why that's ok 🤔
Contributor
Author
There was a problem hiding this comment.
From @metamask/json-rpc-engine - createAsyncMiddleware:
* Async middleware have no "end" function. Instead, they "end" if they return
* without calling "next". Rather than passing in explicit return handlers,
* async middleware can simply await "next", and perform operations on the
* response object when execution resumes.
The async middleware function accepts a next parameter, but no end parameter. 😅
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
… is configured for EIP-7715 methods.
8085971 to
52b0346
Compare
jiexi
reviewed
Sep 2, 2025
jiexi
reviewed
Sep 2, 2025
mj-kiwi
reviewed
Sep 3, 2025
src/index.ts
Outdated
Comment on lines
+31
to
+32
| RevokeExecutionPermissionsRequestParams, | ||
| RevokeExecutionPermissionsResult, |
There was a problem hiding this comment.
Should these two type names be singular to stay consistent with the singular form of wallet_revokeExecutionPermission?
Contributor
Author
There was a problem hiding this comment.
You are absolutely correct!
jiexi
approved these changes
Sep 3, 2025
mcmire
approved these changes
Sep 3, 2025
jeffsmale90
added a commit
that referenced
this pull request
Sep 3, 2025
This is the release for version 17.1.0. ``` a10c7fb feat: add RPC methods described in (revised) EIP-7715 (#396) 45ed998 Run compatibility test only in main branch. (#397) ``` --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Jeff Smale <6363749+jeffsmale90@users.noreply.github.com> Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2025
Adds the method `wallet_requestExecutionPermissions` which is defined in this proposed revision of the EIP-7715 specification ethereum/ERCs#1098. ## **Description** This method is proxied to `@metamask/permissions-kernel-snap`, which implements the exact same method. This snap will be preinstalled in Extension, before the feature is enabled for any users. The feature is gated by `process.env.EIP_7715_READABLE_PERMISSIONS_ENABLED` and requires `process.env.PERMISSIONS_KERNEL_SNAP_ID` to be set. Presently `EIP_7715_READABLE_PERMISSIONS_ENABLED` is set to false, and `PERMISSIONS_KERNEL_SNAP_ID` is set to an empty string for all builds. Requires MetaMask/eth-json-rpc-middleware#396 released in https://github.com/MetaMask/eth-json-rpc-middleware/releases/tag/v17.1.0. This change also adds support for `wallet_revokePermission`, which will be implemented in a future PR, once the revocation UI is implemented. [](https://codespaces.new/MetaMask/metamask-extension/pull/35193?quickstart=1) ## **Changelog** CHANGELOG entry: As this is behind a local feature gate, there are no public facing changes. ## **Manual testing steps** Can be tested with MetaMask/smart-accounts-kit#60 which adds support to the delegation-toolkit's experimental api to call the wallet method directly, rather than via `wallet_invokeSnap`. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds methods
wallet_requestExecutionPermissionsandwallet_revokeExecutionPermission, as defined in this revision of the EIP-7715 specification ethereum/ERCs#1098.This supports Readable Permissions project, and is related to the following PRs:
wallet_requestExecutionPermissionsmethod metamask-extension#35193Note: workflows are failing due to existing problems, fixed by #397