Skip to content

ci(next semver version): rely on package.json when crafting next semver version#34855

Merged
DDDDDanica merged 3 commits into
mainfrom
fix/next-semver-version
Aug 11, 2025
Merged

ci(next semver version): rely on package.json when crafting next semver version#34855
DDDDDanica merged 3 commits into
mainfrom
fix/next-semver-version

Conversation

@gauthierpetetin

@gauthierpetetin gauthierpetetin commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Description

package.json can no longer be used to craft next semver version with our new process, as it's now bumped to the next version number by a version bump PR such as this one: #34840

We need to stop relying on package.json when crafting next semver version otherwise, the automatic labeling of PRs and linked issues gets inaccurate.

Same PR for Mobile: MetaMask/metamask-mobile#17822

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin gauthierpetetin self-assigned this Aug 5, 2025
@gauthierpetetin gauthierpetetin added the team-extension-platform Extension Platform team label Aug 5, 2025
@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]

This comment was marked as outdated.

@metamaskbot

Copy link
Copy Markdown
Collaborator

❌ test-e2e-chrome-api-specs failed. View the html report here.

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [7bd2fec]
UI Startup Metrics (1149 ± 65 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1149104014376511841268
load97285712106310041086
domContentLoaded9648541204639981078
domInteractive17134251630
firstPaint6317711333899761040
backgroundConnect2152012499218234
firstReactRender19143342129
getState11388141329
initialActions40478318
loadScripts75763998764790866
setupStore74162713
WebpackHomeuiStartup22221646265219723302581
load16731193199516217471902
domContentLoaded16661188198616017401881
domInteractive1812215231449
firstPaint1736065687197324
backgroundConnect3114372452953
firstReactRender19489413109229392
getState2443076011263
initialActions62396616
loadScripts16611186197415717361869
setupStore3163096915280
FirefoxBrowserifyHomeuiStartup13761160179411214501594
load1180101914948712411324
domContentLoaded1180101914948712411324
domInteractive1083533357110272
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2816108122957
firstReactRender25215972545
getState62447623
initialActions508913231
loadScripts1157100214728512171303
setupStore11318523641
WebpackHomeuiStartup15561350301321016031980
load12931133184811813551508
domContentLoaded12931133184811813551508
domInteractive93312724799242
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2918123173170
firstReactRender51406555459
getState10210814940
initialActions508713219
loadScripts12691115182911813231484
setupStore2341342134732
Benchmark value 215 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 234 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2223 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2581 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 392 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 263 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 280 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 272 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 31 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 41 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 24 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 1980 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 242 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 70 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 59 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 40 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 19 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 284ms | Sum of p95 exceeds: 983.8ms
Sum of all benchmark exceeds: 1267.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

Comment thread .github/scripts/get-next-semver-version.sh Outdated
@gauthierpetetin gauthierpetetin changed the title fix(next semver version): stop relying on package.json when crafting next semver version fix(next semver version): rely on package.json when crafting next semver version Aug 6, 2025
cursor[bot]

This comment was marked as outdated.

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [c7fd5d5]
UI Startup Metrics (1143 ± 65 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1143103713246511851284
load97186511646210171100
domContentLoaded96486211576210051092
domInteractive17137481733
firstPaint6096911703909741036
backgroundConnect2131992438216233
firstReactRender20144052230
getState1036681023
initialActions507211223
loadScripts75866095262798887
setupStore64233712
WebpackHomeuiStartup23261756280221124382724
load17611264210719118762059
domContentLoaded17541259208618918712048
domInteractive1812111161551
firstPaint1776339763214291
backgroundConnect2811101163162
firstReactRender1959041096204391
getState3153317312266
initialActions721861869
loadScripts17501257207418718692035
setupStore196273411527
FirefoxBrowserifyHomeuiStartup13101119171610813841496
load112497813007911891267
domContentLoaded112397812987911891267
domInteractive963424143101207
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect251481112754
firstReactRender25205982451
getState728312534
initialActions4017217211
loadScripts110296312767911721250
setupStore935211745
WebpackHomeuiStartup15471349190112016171798
load12921128155410013601481
domContentLoaded12921128155410013591481
domInteractive93312795192254
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect311799183183
firstReactRender52417375765
getState94449837
initialActions30224213
loadScripts12671105153210213361458
setupStore94508731
Benchmark value 214 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 23 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2327 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1761 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1754 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 1750 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2725 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2059 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2048 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 391 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 266 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2035 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 207 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 34 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 45 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 254 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 83 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 525ms | Sum of p95 exceeds: 953.8ms
Sum of all benchmark exceeds: 1478.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 833 Bytes (0.02%)
  • ui: 1.03 KiB (0.01%)
  • common: 342 Bytes (0%)

DDDDDanica
DDDDDanica previously approved these changes Aug 6, 2025
github-merge-queue Bot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Aug 6, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Instead of incrementing the minor version, now we stay with the highest

[Same PR for
Extension](MetaMask/metamask-extension#34855)
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Comment thread .github/scripts/get-next-semver-version.sh
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [89056a8]
UI Startup Metrics (1167 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1167103213296612121281
load99187911196310391106
domContentLoaded98387111086310331088
domInteractive17135061736
firstPaint6159011063919951089
backgroundConnect2152032508219232
firstReactRender20144762133
getState10485101228
initialActions30789213
loadScripts77567189862826881
setupStore74142712
WebpackHomeuiStartup21431630257619222602474
load15961204192115916911846
domContentLoaded15891199191715816881833
domInteractive171190141359
firstPaint1505832659171280
backgroundConnect24144982841
firstReactRender22089423117377393
getState3042877410280
initialActions52283511
loadScripts15851197190615716821821
setupStore2663216314274
FirefoxBrowserifyHomeuiStartup12861107172210313321469
load111196313577911591253
domContentLoaded111196313577911591253
domInteractive963326142108202
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2614111132748
firstReactRender24205172348
getState62407528
initialActions5015617214
loadScripts109095013387711421229
setupStore73528523
WebpackHomeuiStartup15401345186812716241786
load12931123158710913781507
domContentLoaded12921123158710913781507
domInteractive90312583993191
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3117123173276
firstReactRender52409575563
getState11464111143
initialActions40658322
loadScripts12671101153210613561481
setupStore84396725
Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2474 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 280 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 274 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 202 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 191 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 76 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 43 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 238ms | Sum of p95 exceeds: 697.8ms
Sum of all benchmark exceeds: 935.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.41 KiB (0.03%)
  • ui: 7.62 KiB (0.11%)
  • common: 102 Bytes (0%)

@davidmurdoch davidmurdoch changed the title fix(next semver version): rely on package.json when crafting next semver version ci(next semver version): rely on package.json when crafting next semver version Aug 7, 2025

@Gudahtt Gudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Aug 11, 2025
@DDDDDanica DDDDDanica added this pull request to the merge queue Aug 11, 2025
Merged via the queue into main with commit 295aa44 Aug 11, 2025
275 of 277 checks passed
@DDDDDanica DDDDDanica deleted the fix/next-semver-version branch August 11, 2025 10:52
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 11, 2025
@metamaskbot metamaskbot added the release-13.2.0 Issue or pull request that will be included in release 13.2.0 label Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.2.0 Issue or pull request that will be included in release 13.2.0 team-extension-platform Extension Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants