Skip to content

fix: next version fix label PR#17822

Merged
tommasini merged 3 commits into
mainfrom
fix/next-version-label-fix
Aug 6, 2025
Merged

fix: next version fix label PR#17822
tommasini merged 3 commits into
mainfrom
fix/next-version-label-fix

Conversation

@tommasini

@tommasini tommasini commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

Description

Instead of incrementing the minor version, now we stay with the highest

Same PR for Extension

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team No E2E Smoke Needed labels Aug 1, 2025
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Aug 1, 2025
@github-actions

github-actions Bot commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin

gauthierpetetin commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Comment made on Slack:

Hi @tommasini , I just had a look at the current situation to better understand:

  • 7.53.0 was cut on July 31st
  • The highest branch is release/7.53.0
  • The highest version tag is 7.51.2
  • The version package is 7.54.0

Since the scripts takes the highest of all 3 and bumps the minor version we end up labeling issues with 7.55.0, while we'd like to label them with 7.54.0.
Like you say, we now bump the package.json to a future version number, which we didn't do in the past, as this is needed for nightly builds. => A question I have is: shall we do that on Extension repo as well, to ensure we keep the same process on both repos? Answer from @vpintorico : Yes we should

This being said, I think the source of truth for the next semver version we automatically apply as label should be whether the release was cut or not. This info is given by the existence of the release/x.y.z branch. So a fix could be to remove line 19 from the script:

VERSION_PACKAGE=$(node -p "require('../../package.json').version")

and update line 22 to rely only on branches and tags, and not on package.json anymore:

HIGHEST_VERSION=$(printf "%s\n%s\n%s" "$VERSION_BRANCHES" "$VERSION_TAGS" | sort --version-sort | tail -n 1)

=> What do you think?

cursor[bot]

This comment was marked as outdated.

@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2025

Copy link
Copy Markdown

@gauthierpetetin gauthierpetetin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Aug 6, 2025
@tommasini tommasini added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit e116e32 Aug 6, 2025
44 checks passed
@tommasini tommasini deleted the fix/next-version-label-fix branch August 6, 2025 17:04
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Aug 6, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 6, 2025
@metamaskbot metamaskbot added the release-7.54.0 Issue or pull request that will be included in release 7.54.0 label Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants