fix: cp-12.15.2 Allow verifyingContract to be omitted from EIP-712 signatures#31613
Merged
fix: cp-12.15.2 Allow verifyingContract to be omitted from EIP-712 signatures#31613
verifyingContract to be omitted from EIP-712 signatures#31613Conversation
The signature controller has been patched with changes from MetaMask/core#5595 to allow the `verifyingContract` field to be missing from EIP-712 signatures. It is optional in the spec. Fixes #31607
bd4dfaa to
4460a5f
Compare
verifyingContract to be omitted from EIP-712 signaturesverifyingContract to be omitted from EIP-712 signatures
Collaborator
Builds ready [4460a5f]
UI Startup Metrics (1215 ± 68 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MajorLift
approved these changes
Apr 4, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
…31630) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The typed signatures were broken when we don't pass a verifyingContract value in the message. This was fixed, and now we add a spec to cover this user flow. PR with the fix: #31613 [](https://codespaces.new/MetaMask/metamask-extension/pull/31630?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Check ci or run spec locally ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/user-attachments/assets/63ae3cdd-4d0c-49a0-9dfa-0dc0cec14749 ### **After** https://github.com/user-attachments/assets/7e4f8e55-3cd1-455c-badb-9ef1cb2fdfac <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The signature controller has been patched with changes from MetaMask/core#5595 to allow the
verifyingContractfield to be missing from EIP-712 signatures. It is optional in the spec.Related issues
Fixes #31607
Manual testing steps
(replace
YOUR_ADDRESS_HEREwith a connected address)3. Previous it would fail. On this branch it should correctly prompt a signature confirmation.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist