Conversation
verifyingContract field in EIP712 payloads is undefined or not a string
OGPoyraz
approved these changes
Apr 4, 2025
7 tasks
Merged
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 4, 2025
The signature controller has been patched with changes from MetaMask/core#5595 to allow the `verifyingContract` field to be missing from EIP-712 signatures. It is optional in the spec. Fixes #31607
adonesky1
added a commit
that referenced
this pull request
Apr 4, 2025
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 4, 2025
…signatures (#31613) ## **Description** The signature controller has been patched with changes from MetaMask/core#5595 to allow the `verifyingContract` field to be missing from EIP-712 signatures. It is optional in the spec. [](https://codespaces.new/MetaMask/metamask-extension/pull/31613?quickstart=1) ## **Related issues** Fixes #31607 ## **Manual testing steps** 1. Connect to the test-dapp 2. Enter this URL: ``` https://metamask.github.io/test-dapp/request.html?method=eth_signTypedData_v4¶ms=[%22YOUR_ADDRESSS_HERE%22,{%22types%22:{%22EIP712Domain%22:[{%22name%22:%22name%22,%22type%22:%22string%22}],%22Mail%22:[{%22name%22:%22from%22,%22type%22:%22string%22}]},%22primaryType%22:%22Mail%22,%22domain%22:{%22name%22:%22foo%22},%22message%22:{%from%22:%22foo%22}}] ``` (replace `YOUR_ADDRESS_HERE` with a connected address) 3. Previous it would fail. On this branch it should correctly prompt a signature confirmation. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - We can manually test this for now, I will follow-up with an E2E test in a later PR - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
7 tasks
MajorLift
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 4, 2025
…signatures (#31613) The signature controller has been patched with changes from MetaMask/core#5595 to allow the `verifyingContract` field to be missing from EIP-712 signatures. It is optional in the spec. [](https://codespaces.new/MetaMask/metamask-extension/pull/31613?quickstart=1) Fixes #31607 1. Connect to the test-dapp 2. Enter this URL: ``` https://metamask.github.io/test-dapp/request.html?method=eth_signTypedData_v4¶ms=[%22YOUR_ADDRESSS_HERE%22,{%22types%22:{%22EIP712Domain%22:[{%22name%22:%22name%22,%22type%22:%22string%22}],%22Mail%22:[{%22name%22:%22from%22,%22type%22:%22string%22}]},%22primaryType%22:%22Mail%22,%22domain%22:{%22name%22:%22foo%22},%22message%22:{%from%22:%22foo%22}}] ``` (replace `YOUR_ADDRESS_HERE` with a connected address) 3. Previous it would fail. On this branch it should correctly prompt a signature confirmation. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - We can manually test this for now, I will follow-up with an E2E test in a later PR - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
dbrans
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 7, 2025
…signatures (#31613) The signature controller has been patched with changes from MetaMask/core#5595 to allow the `verifyingContract` field to be missing from EIP-712 signatures. It is optional in the spec. [](https://codespaces.new/MetaMask/metamask-extension/pull/31613?quickstart=1) Fixes #31607 1. Connect to the test-dapp 2. Enter this URL: ``` https://metamask.github.io/test-dapp/request.html?method=eth_signTypedData_v4¶ms=[%22YOUR_ADDRESSS_HERE%22,{%22types%22:{%22EIP712Domain%22:[{%22name%22:%22name%22,%22type%22:%22string%22}],%22Mail%22:[{%22name%22:%22from%22,%22type%22:%22string%22}]},%22primaryType%22:%22Mail%22,%22domain%22:{%22name%22:%22foo%22},%22message%22:{%from%22:%22foo%22}}] ``` (replace `YOUR_ADDRESS_HERE` with a connected address) 3. Previous it would fail. On this branch it should correctly prompt a signature confirmation. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - We can manually test this for now, I will follow-up with an E2E test in a later PR - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
It seems we've broken some dapps that rely on EIP712 /
eth_signTypedData_v4signatures which don't includeverifyingContractas part of their payload.References
See: MetaMask/metamask-extension#31607
For example:
-->
Changelog
Checklist