refactor: wallet_createSession should call PermissionController.requestPermissions instead of ApprovalController.addAndShowApprovalRequest#30908
Merged
adonesky1 merged 4 commits intojl/caip-multichain-migrate-corefrom Mar 11, 2025
Conversation
Collaborator
Builds ready [1240e5b]
Page Load Metrics (2149 ± 113 ms)
|
jiexi
approved these changes
Mar 11, 2025
Collaborator
Builds ready [7346118]
Page Load Metrics (1823 ± 70 ms)
|
b710fbb
into
jl/caip-multichain-migrate-core
66 of 68 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We created a merger for the
Caip25Permissionspecification in order to enablewallet_addEthereumChainandwallet_switchEthereumChainto call to thePermissionControllerrather than theApprovalControllerfor incremental permission requests (i.e. for the permittedChains flow).PRs implementing these changes
core: MetaMask/core#5283
extension: #30042
We also changed
eth_requestAccountsandwallet_requestPermissionshandlers to call thePermissionController, but we should now do the change towallet_createSessionhandler as well and address this feedback on the Flask Multichain PR (at the moment this is only available on the Flask Multichain PR)Related issues
Fixes:
Manual testing steps
Then
(RECOMMENDED) Use the Multichain Test Dapp
OR
Form requests manually
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist