Addressing https://github.com/MetaMask/MetaMask-planning/issues/4017

We want to create a merger for the Caip25Permission specification in order to enable wallet_addEthereumChain and wallet_switchEthereumChain to call to the PermissionController rather than the ApprovalController for incremental permission requests (i.e. for the permittedChains flow).

Merger created in this core PR

Description

Related issues

Fixes:

Manual testing steps

We can start everything off by making sure we use the dev build of extension via yarn && yarn webpack or yarn && yarn start

wallet_requestPermissions empty eth_accounts request (default)

1. Send the following request through dev tools console via wallet_requestPermissions

await window.ethereum.request({
  method: 'wallet_requestPermissions',
  params: [
    {
      'eth_accounts': {},
    }
  ]
});

2. Should render the following UI

3. After approval, the dapp should also have eth_accounts and endowment:permitted-chains permission for the recently added chain via wallet_getPermissions

wallet_requestPermissions eth_accounts account permission request

1. Send the following request through dev tools console via wallet_requestPermissions

await window.ethereum.request({
  method: 'wallet_requestPermissions',
  params: [
    {
      'eth_accounts': {
        'caveats': [
        	{
        		'type': 'restrictReturnedAccounts',
        		'value': ["0x0aC9D99d92AB266e33b27469f8ce84FE7C56b6d5"] 
                          // replace this account with your local account public address
        	}
        ]
      },
    }
  ]
});

2. Should render the following UI

3. After approval, the dapp should also have eth_accounts and endowment:permitted-chains permission for the recently added chain via wallet_getPermissions

wallet_requestPermissions endowment:permitted-chains chain permission request

1. Send the following request through dev tools console via wallet_requestPermissions

await window.ethereum.request({
  method: 'wallet_requestPermissions',
  params: [
    {
      'eth_accounts': {
        'caveats': [
        	{
        		'type': 'restrictReturnedAccounts',
        		'value': []
        	}
        ]
      },
      'endowment:permitted-chains': {
      	'caveats': [
      		{
      			'type': 'restrictNetworkSwitching',
      			'value': ["0x1"] // replace with desired chain, here we default to mainnet
      		}
      	]
    }
    }
  ]
});

2. Should render the following UI

3. After approval, the dapp should also have eth_accounts and endowment:permitted-chains permission for the recently added chain via wallet_getPermissions

wallet_requestPermissions eth_accounts and endowment:permitted-chains account + chain permission request

1. Send the following request through dev tools console via wallet_requestPermissions

await window.ethereum.request({
  method: 'wallet_requestPermissions',
  params: [
    {
      'eth_accounts': {
        'caveats': [
        	{
        		'type': 'restrictReturnedAccounts',
        		'value': ["0x0aC9D99d92AB266e33b27469f8ce84FE7C56b6d5"]
                          // replace this account with your local account public address
        	}
        ]
      },
      'endowment:permitted-chains': {
      	'caveats': [
      		{
      			'type': 'restrictNetworkSwitching',
      			'value': ["0x1"] // replace with desired chain, here we default to mainnet
      		}
      	]
    }
    }
  ]
});

2. Should render the following UI

3. After approval, the dapp should also have eth_accounts and endowment:permitted-chains permission for the recently added chain via wallet_getPermissions

wallet_requestPermissions malformed eth_accounts address

1. Send the following request through dev tools console via wallet_requestPermissions

await window.ethereum.request({
  method: 'wallet_requestPermissions',
  params: [
    {
      'eth_accounts': {
        'caveats': [
        	{
        		'type': 'restrictReturnedAccounts',
        		'value': ["malformed.eth"]
        	}
        ]
      },
      'endowment:permitted-chains': {
      	'caveats': [
      		{
      			'type': 'restrictNetworkSwitching',
      			'value': []
      		}
      	]
    }
    }
  ]
});

2. Should see an exception being thrown in the console, with the message Value must be a hexadecimal string, starting with "0x".

wallet_switchEthereumChain Permissions for new chain

1. Send the following request through dev tools console via wallet_switchEthereumChain

await window.ethereum.request({
          jsonrpc: '2.0',
          method: 'wallet_switchEthereumChain',
          params: [{ chainId: '0xe705' }], 
          // replace by a chain that's currently not permitted, I used Linea Sepolia
})

2. Should render the following UI

4. After approval, the dapp should also have eth_accounts and endowment:permitted-chains permission for the recently added chain via wallet_getPermissions

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.