feat: create merger and factory for the Caip25Permission#5283
Merged
ffmcgee725 merged 28 commits intomainfrom Feb 25, 2025
Merged
feat: create merger and factory for the Caip25Permission#5283ffmcgee725 merged 28 commits intomainfrom
ffmcgee725 merged 28 commits intomainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Addressing https://github.com/MetaMask/MetaMask-planning/issues/4017
We want to create a merger for the Caip25Permission specification in order to enable wallet_addEthereumChain and wallet_switchEthereumChain to call to the PermissionController rather than the ApprovalController for incremental permission requests (i.e. for the permittedChains flow).
References
Extension: MetaMask/metamask-extension#30042
Changelog
@metamask/multichain-apimergeScopestomergeNormalizedScopescaip25CaveatBuilder()mergeInternalScopeswhich merges twoInternalScopesObjectsChecklist