Skip to content

chore: update accounts deps + peer deps#30011

Closed
ccharly wants to merge 22 commits intomainfrom
chore/update-accounts-deps-and-peers
Closed

chore: update accounts deps + peer deps#30011
ccharly wants to merge 22 commits intomainfrom
chore/update-accounts-deps-and-peers

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented Jan 30, 2025

Description

Similar to:

But also updates other controllers that depends on the accounts-controller.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ccharly ccharly force-pushed the chore/update-accounts-deps-and-peers branch from cad0d3f to 86897e9 Compare January 30, 2025 17:18
@ccharly ccharly force-pushed the chore/update-accounts-deps-and-peers branch from 86897e9 to fe73aba Compare January 30, 2025 17:19
@ccharly ccharly added the team-accounts-framework Accounts team label Jan 31, 2025
@ccharly ccharly mentioned this pull request Jan 31, 2025
7 tasks
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2025
## **Description**

Use the new Snap keyring version that no longer rely on a
`SnapController` reference. Instead it uses the messaging system.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29912?quickstart=1)

> [!NOTE]
> This PR is blocking other features for the moment, so not every peer
deps (related to the `AccountsController`) have been updated here. This
will be done in a separate PR:
> - #30011

## **Related issues**

- MetaMask/core#5190

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
@ccharly ccharly closed this Feb 21, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
@HowardBraham HowardBraham deleted the chore/update-accounts-deps-and-peers branch January 19, 2026 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants