chore: update accounts deps by ccharly · Pull Request #29912 · MetaMask/metamask-extension

ccharly · 2025-01-27T08:45:13Z

Description

Use the new Snap keyring version that no longer rely on a SnapController reference. Instead it uses the messaging system.

Note

This PR is blocking other features for the moment, so not every peer deps (related to the AccountsController) have been updated here. This will be done in a separate PR:

chore: update accounts deps + peer deps #30011

Related issues

feat(accounts-controller): re-publish Snap keyring events core#5190

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-27T08:45:26Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ccharly · 2025-01-27T08:49:53Z

@metamaskbot update-policies

socket-security · 2025-01-27T08:51:11Z

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/accounts-controller@22.0.0 🔁 npm/@metamask/accounts-controller@21.0.2	None	`0`	285 kB	metamaskbot
npm/@metamask/eth-snap-keyring@9.1.1 🔁 npm/@metamask/eth-snap-keyring@8.1.1	None	`0`	421 kB	metamaskbot
npm/@metamask/keyring-api@16.1.0	None	`+1`	553 kB	metamaskbot
npm/@metamask/keyring-internal-api@4.0.1	None	`0`	65.3 kB	metamaskbot
npm/@metamask/keyring-internal-snap-client@3.0.3 🔁 npm/@metamask/keyring-internal-snap-client@3.0.0	None	`0`	35.1 kB	metamaskbot
npm/@metamask/keyring-snap-client@3.0.3 🔁 npm/@metamask/keyring-snap-client@3.0.0	None	`0`	65.7 kB	metamaskbot
npm/@metamask/keyring-utils@2.0.0 🔁 npm/@metamask/keyring-utils@1.2.0	None	`0`	68.8 kB	metamaskbot

View full report↗︎

metamaskbot · 2025-01-27T09:02:28Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

ccharly · 2025-01-30T12:09:25Z

@metamaskbot update-policies

metamaskbot · 2025-01-30T12:21:48Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-01-30T14:50:06Z

Builds ready [0a9f7e4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1525 ± 37 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1392	1690	1532	75	36
		domContentLoaded	1384	1681	1506	75	36
		load	1393	1691	1525	77	37
		domInteractive	22	99	35	20	10
		backgroundConnect	8	62	23	18	8
		firstReactRender	15	75	39	25	12
		getState	4	54	9	11	5
		initialActions	0	1	0	0	0
		loadScripts	970	1246	1088	66	32
		setupStore	7	44	10	8	4
		uiStartup	1590	2195	1747	130	62

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 37.21 KiB (0.63%)
ui: 4.24 KiB (0.05%)
common: 182.99 KiB (2.00%)

metamaskbot · 2025-01-30T16:29:51Z

Builds ready [43889d2]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1709 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	376	1949	1612	404	194
		domContentLoaded	1486	1944	1689	127	61
		load	1490	1984	1709	132	63
		domInteractive	17	132	47	29	14
		backgroundConnect	8	51	22	15	7
		firstReactRender	16	95	43	27	13
		getState	4	62	21	22	11
		initialActions	0	1	0	0	0
		loadScripts	1058	1489	1234	116	55
		setupStore	7	90	18	22	11
		uiStartup	1736	2396	1992	166	80

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 37.21 KiB (0.63%)
ui: 4.24 KiB (0.05%)
common: 182.99 KiB (2.00%)

metamaskbot · 2025-01-30T17:33:25Z

Builds ready [79f106d]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1814 ± 121 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1516	2405	1822	267	128
		domContentLoaded	1477	2344	1790	249	120
		load	1515	2352	1814	253	121
		domInteractive	25	78	38	16	7
		backgroundConnect	9	59	30	17	8
		firstReactRender	15	97	52	30	15
		getState	4	68	13	16	8
		initialActions	0	1	0	0	0
		loadScripts	1059	1800	1322	207	100
		setupStore	7	59	15	14	7
		uiStartup	1714	2885	2141	351	169

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 37.21 KiB (0.63%)
ui: 4.24 KiB (0.05%)
common: 182.99 KiB (2.00%)

ccharly · 2025-01-31T14:47:45Z

app/scripts/controllers/preferences-controller.test.ts

+      'SnapKeyring:accountAssetListUpdated',
+      'SnapKeyring:accountBalancesUpdated',
+      'SnapKeyring:accountTransactionsUpdated',


Those are now required by the AccountsController

ccharly · 2025-01-31T14:47:51Z

app/scripts/controllers/mmi-controller.test.ts

+          'SnapKeyring:accountAssetListUpdated',
+          'SnapKeyring:accountBalancesUpdated',
+          'SnapKeyring:accountTransactionsUpdated',


Those are now required by the AccountsController

ccharly · 2025-01-31T14:49:45Z

app/scripts/lib/snap-keyring/snap-keyring.test.ts

    never
  >().getRestricted({
-    name: 'SnapKeyringBuilder',
+    name: 'SnapKeyring',


We have to update this since the AccountsController uses this messenger's name now for the new keyring events.

ccharly · 2025-01-31T14:49:55Z

app/scripts/lib/snap-keyring/types.ts


 export type SnapKeyringBuilderMessenger = RestrictedControllerMessenger<
-  'SnapKeyringBuilder',
+  'SnapKeyring',


We have to update this since the AccountsController uses this messenger's name now for the new keyring events.

ccharly and others added 8 commits January 23, 2025 10:41

chore: bump accounts dependencies

e07c0e5

chore: use assets-controllers@46.0.1 + re-patch

5f9cd4e

chore: bump @metamask/eth-snap-keyring to version 8.1.1

1838a57

chore: bump profile-sync-controller

0daf7bb

Update LavaMoat policies

5948106

Merge branch 'main' into chore/update-accounts-deps

71eeefc

chore: use preview builds

ca0d457

feat: use messenger for the Snap keyring

e53bad6

Merge branch 'main' into chore/update-accounts-deps

4314c69

ccharly changed the title ~~chore: /update accounts deps~~ chore: update accounts deps Jan 27, 2025

ccharly added 2 commits January 30, 2025 11:39

Merge branch 'main' into chore/update-accounts-deps

5a658a7

chore: update preview deps

6086c50

ccharly force-pushed the chore/update-accounts-deps branch from 59ea846 to 6086c50 Compare January 30, 2025 12:09

chore: remove preview builds

a95fda7

ccharly force-pushed the chore/update-accounts-deps branch from 3e9c6fa to a95fda7 Compare January 30, 2025 12:47

ccharly added 2 commits January 30, 2025 15:17

fix(tests): fix *Scopes + add new events for the AccountsController

7545371

chore: lint

0a9f7e4

ccharly added 4 commits January 30, 2025 16:23

test: fix scopes

93c285b

test: fix Snap keyring

c9b2060

test: fix account-picker

5c171c4

test: fix mock-state.json

749ec0a

ccharly added the team-accounts-framework Accounts team label Jan 30, 2025

ccharly self-assigned this Jan 30, 2025

ccharly removed their assignment Jan 30, 2025

test: fix selectors.test.js

43889d2

ccharly added 2 commits January 30, 2025 17:41

test: fix account-picker.test.tsx

b3bb8a6

test: fix mmi-controller.test.ts

79f106d

ccharly mentioned this pull request Jan 30, 2025

chore: update accounts deps + peer deps #30011

Closed

7 tasks

ccharly marked this pull request as ready for review January 31, 2025 08:52

ccharly requested review from a team as code owners January 31, 2025 08:52

ccharly commented Jan 31, 2025

View reviewed changes

danroc approved these changes Jan 31, 2025

View reviewed changes

NidhiKJha approved these changes Jan 31, 2025

View reviewed changes

ccharly added this pull request to the merge queue Jan 31, 2025

Merged via the queue into main with commit 7fdff0a Jan 31, 2025

ccharly deleted the chore/update-accounts-deps branch January 31, 2025 15:42

github-actions bot locked and limited conversation to collaborators Jan 31, 2025

metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Jan 31, 2025

Conversation

ccharly commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jan 27, 2025

Uh oh!

ccharly commented Jan 27, 2025

Uh oh!

socket-security bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Jan 27, 2025

Uh oh!

ccharly commented Jan 30, 2025

Uh oh!

metamaskbot commented Jan 30, 2025

Uh oh!

metamaskbot commented Jan 30, 2025

Uh oh!

metamaskbot commented Jan 30, 2025

Uh oh!

metamaskbot commented Jan 30, 2025

Uh oh!

ccharly Jan 31, 2025

Choose a reason for hiding this comment

Uh oh!

ccharly Jan 31, 2025

Choose a reason for hiding this comment

Uh oh!

ccharly Jan 31, 2025

Choose a reason for hiding this comment

Uh oh!

ccharly Jan 31, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ccharly commented Jan 27, 2025 •

edited

Loading

socket-security bot commented Jan 27, 2025 •

edited

Loading