Skip to content

chore: downgrade prettier-eslint to match prettier version#26145

Merged
HowardBraham merged 3 commits intoMetaMask:developfrom
legobeat:fix-prettier-eslint-version
Aug 16, 2024
Merged

chore: downgrade prettier-eslint to match prettier version#26145
HowardBraham merged 3 commits intoMetaMask:developfrom
legobeat:fix-prettier-eslint-version

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Jul 25, 2024 •
edited by github-actions bot
Loading

Description

#23106 added a version of prettier-eslint which uses prettier v3. This project otherwise uses prettier v2. This downgrades the package to the latest version still supporting prettier v2.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 25, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat mentioned this pull request Jul 25, 2024
Merged
7 tasks
@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 25, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/eslint@8.56.11 None 0 193 kB types
npm/@types/prettier@2.7.3 None 0 49.8 kB types
npm/@typescript-eslint/types@5.62.0 None 0 223 kB jameshenry
npm/@typescript-eslint/typescript-estree@5.62.0 environment, filesystem 0 553 kB jameshenry
npm/@typescript-eslint/visitor-keys@5.62.0 None 0 18.4 kB jameshenry
npm/prettier-eslint@15.0.1 environment, filesystem 0 53.1 kB zimme
npm/vue-eslint-parser@8.3.0 unsafe 0 1 MB ota-meshi

🚮 Removed packages: npm/@types/eslint@8.44.8, npm/@types/prettier@2.7.2, npm/@typescript-eslint/types@5.59.6, npm/@typescript-eslint/typescript-estree@5.59.6, npm/@typescript-eslint/visitor-keys@5.59.6, npm/prettier-eslint@16.3.0, npm/vue-eslint-parser@9.4.2

View full report↗︎

@legobeat legobeat marked this pull request as ready for review July 25, 2024 21:53
@legobeat legobeat requested a review from a team as a code owner July 25, 2024 21:53
legobeat
legobeat commented Jul 25, 2024
View reviewed changes
yarn.lock Outdated
Copy link
Copy Markdown
Contributor Author

@legobeat legobeat Jul 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this pulls back typescript to v4 again, it's also technically already a missing peerDependency of @metamask/eslint-config-typescript.

Updating @metamask/eslint-config-typescript, and prettier to v3, will properly remove TS v4.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels Jul 25, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (cad49eb) to head (22bb329).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #26145   +/-   ##
========================================
  Coverage    70.12%   70.12%           
========================================
  Files         1434     1434           
  Lines        50285    50285           
  Branches     13890    13890           
========================================
  Hits         35259    35259           
  Misses       15026    15026

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the fix-prettier-eslint-version branch 2 times, most recently from 2e7bb1f to 4d4f2d5 Compare July 26, 2024 20:27
Gudahtt
Gudahtt previously approved these changes Aug 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Aug 1, 2024

I would like to tackle the Prettier v3 upgrade soon, but let's stay consistent in the meantime. Good catch

@legobeat legobeat force-pushed the fix-prettier-eslint-version branch from 4d4f2d5 to 970124e Compare August 1, 2024 23:04
@legobeat legobeat requested review from a team August 1, 2024 23:05
@legobeat legobeat force-pushed the fix-prettier-eslint-version branch from 970124e to e415f99 Compare August 11, 2024 22:09
@socket-security
Copy link
Copy Markdown

socket-security bot commented Aug 11, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@legobeat legobeat force-pushed the fix-prettier-eslint-version branch 2 times, most recently from 16388d4 to 8aeceb1 Compare August 12, 2024 10:06
@Mrtenz
Copy link
Copy Markdown
Member

Mrtenz commented Aug 12, 2024

I would like to tackle the Prettier v3 upgrade soon, but let's stay consistent in the meantime. Good catch

Prettier 3 isn't compatible with auto-changelog currently fyi. The v3 API is asynchronous, and updating that is quite a big refactor of auto-changelog last time I checked.

@legobeat legobeat force-pushed the fix-prettier-eslint-version branch from 8aeceb1 to 937f974 Compare August 12, 2024 16:08
@HowardBraham HowardBraham merged commit f659700 into MetaMask:develop Aug 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
@legobeat legobeat deleted the fix-prettier-eslint-version branch August 16, 2024 23:49
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Sep 25, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 25, 2024

No release label on PR. Adding release label release-12.5.0 on PR, as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HowardBraham HowardBraham HowardBraham approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-application-security Application security team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legobeat @Gudahtt @Mrtenz @metamaskbot @HowardBraham