Skip to content

chore: cleanup .prettierignore file#24828

Merged
HowardBraham merged 1 commit intodevelopfrom
cleanup-prettier-ignore-file
Jul 25, 2024
Merged

chore: cleanup .prettierignore file#24828
HowardBraham merged 1 commit intodevelopfrom
cleanup-prettier-ignore-file

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented May 28, 2024 •
edited by github-actions bot
Loading

Description

A few invalid entries have been removed from the .prettierignore file, and the remaining entries have been alphabetized so that they are easier to quickly scan.

I did this because I was investigating a strange ESLint error, and these entries made the investigation a little more complicated than it needed to be.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt force-pushed the cleanup-prettier-ignore-file branch from 5b2cd60 to 55b0242 Compare May 28, 2024 14:47
Gudahtt
Gudahtt commented May 28, 2024
View reviewed changes
.prettierignore
development/chromereload.js
development/ts-migration-dashboard/filesToConvert.json
development/ts-migration-dashboard/build/**
public/**/*
Copy link
Copy Markdown
Member Author

@Gudahtt Gudahtt May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed, it did not exist

Gudahtt
Gudahtt commented May 28, 2024
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.72%. Comparing base (989a578) to head (f398324).
Report is 9 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #24828      +/-   ##
===========================================
- Coverage    69.74%   69.72%   -0.02%     
===========================================
  Files         1400     1400              
  Lines        49423    49440      +17     
  Branches     13669    13677       +8     
===========================================
+ Hits         34470    34472       +2     
- Misses       14953    14968      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt Gudahtt marked this pull request as ready for review May 28, 2024 15:27
@Gudahtt Gudahtt requested a review from a team as a code owner May 28, 2024 15:27
@Gudahtt Gudahtt added the team-extension-platform Extension Platform team label May 28, 2024
Gudahtt
Gudahtt commented May 28, 2024
View reviewed changes
.prettierignore
lavamoat/**/policy.json
dist/**/*
builds/**/*
test-*/**/*
Copy link
Copy Markdown
Member Author

@Gudahtt Gudahtt May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was split into these two lines:

/test-artifacts/**/*
/test/test-results/**/*

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 28, 2024

Builds ready [5aedb26]
Page Load Metrics (605 ± 516 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6559611811254
domContentLoaded96616157
load5333516051075516
domInteractive96616157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Gudahtt
Gudahtt commented May 28, 2024
View reviewed changes
.prettierignore
@@ -1,18 +1,16 @@
node_modules/**/*
Copy link
Copy Markdown
Member Author

@Gudahtt Gudahtt May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was listed twice, you can see that the second entry is preserved in this diff

@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented May 28, 2024

I wasn't sure if ESLint would treat the leading slash in the same way (e.g. leading slash means it's specifically in the project root, no leading slash matches the path in any subdirectory or in the root), the docs weren't clear on the subject.

But I tested it out by adding test files in the root and in a subdirectory, each with a lint error. And I validated that it treats them the same way.

My test was to create test1.js, test2.js, and test3.js, each with a lint error. And then duplicate them in a directory as well. Then ignore test1.js and /test2.js. I expected to see lint errors for both test3.js files (the control), no lint errors for test1.js, and lint errors just for the test2.js in a directory. And that's exactly what I saw.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 29, 2024

Builds ready [c2063f4]
Page Load Metrics (625 ± 520 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint652491094522
domContentLoaded9291573
load5732196251083520
domInteractive9291573
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt force-pushed the cleanup-prettier-ignore-file branch from c2063f4 to 52dcd23 Compare June 3, 2024 13:03
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 3, 2024

Builds ready [52dcd23]
Page Load Metrics (47 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint619875105
domContentLoaded8191021
load41704784
domInteractive8191021

@Gudahtt Gudahtt force-pushed the cleanup-prettier-ignore-file branch 3 times, most recently from 7940745 to 3cbb34a Compare June 6, 2024 20:00
@Gudahtt Gudahtt force-pushed the cleanup-prettier-ignore-file branch from 3cbb34a to ad035ce Compare June 17, 2024 15:07
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 17, 2024

Builds ready [ad035ce]
Page Load Metrics (283 ± 321 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint734281167435
domContentLoaded106317126
load442519283668321
domInteractive106317126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt force-pushed the cleanup-prettier-ignore-file branch from ad035ce to aeacb04 Compare June 20, 2024 16:41
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 20, 2024

Builds ready [aeacb04]
Page Load Metrics (50 ± 2 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67998384
domContentLoaded9121110
load41585052
domInteractive9121110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt force-pushed the cleanup-prettier-ignore-file branch from aeacb04 to e68cecf Compare June 24, 2024 19:16
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 24, 2024

Builds ready [e68cecf]
Page Load Metrics (43 ± 1 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint66847563
domContentLoaded811910
load39494331
domInteractive811910
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt force-pushed the cleanup-prettier-ignore-file branch from e68cecf to 8833011 Compare July 15, 2024 12:24
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 15, 2024

Builds ready [8833011]
Page Load Metrics (223 ± 236 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7514291189
domContentLoaded10482594
load441789223490236
domInteractive10482594
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt force-pushed the cleanup-prettier-ignore-file branch 2 times, most recently from 20aff11 to 52f1701 Compare July 16, 2024 17:23
@Gudahtt
chore: cleanup .prettierignore file
f398324 
A few invalid entries have been removed from the `.prettierignore`
file, and the remaining entries have been alphabetized so that they are
easier to quickly scan.

Additionally, a leading slash has been added for any entries that are
intended to be relative to the repository root directory. This was so
that it would be more explicit which patterns would apply to
subdirectories (this ambiguity led to me missing the
`test/test-results` directory on the first pass).

I did this because I was investigating a strange ESLint error, and
these entries made the investigation a little more complicated than it
needed to be.
@Gudahtt Gudahtt force-pushed the cleanup-prettier-ignore-file branch from 52f1701 to f398324 Compare July 18, 2024 14:23
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 18, 2024

Builds ready [f398324]
Page Load Metrics (167 ± 173 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint723721166230
domContentLoaded991312311
load411725167361173
domInteractive991312311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham merged commit 855dd80 into develop Jul 25, 2024
@HowardBraham HowardBraham deleted the cleanup-prettier-ignore-file branch July 25, 2024 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 25, 2024
@legobeat

This comment was marked as resolved.

Sign in to view
@Gudahtt

This comment was marked as resolved.

Sign in to view
@legobeat

This comment was marked as resolved.

Sign in to view
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HowardBraham HowardBraham HowardBraham approved these changes

+1 more reviewer

@vthomas13 vthomas13 vthomas13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform Extension Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gudahtt @metamaskbot @legobeat @HowardBraham @vthomas13