Skip to content

fix: Prettier ESLint VSCode extension#23106

Merged
HowardBraham merged 5 commits intodevelopfrom
prettier-eslint
Feb 23, 2024
Merged

fix: Prettier ESLint VSCode extension#23106
HowardBraham merged 5 commits intodevelopfrom
prettier-eslint

Conversation

@HowardBraham
Copy link
Copy Markdown
Contributor

@HowardBraham HowardBraham commented Feb 22, 2024 •
edited by github-actions bot
Loading

Description

The Prettier ESLint VSCode extension updated, and now our default formatters don't work anymore
https://marketplace.visualstudio.com/items?itemName=rvest.vs-code-prettier-eslint

The new version requires the package prettier-eslint to be installed.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Run yarn
  2. Open a file in VSCode and change it so it's formatted incorrectly
  3. Run the formatter
    Windows: Shift + Alt + F
    Mac: Shift + Option + F

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@HowardBraham HowardBraham added the team-extension-platform Extension Platform team label Feb 22, 2024
@HowardBraham HowardBraham self-assigned this Feb 22, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Feb 22, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/dlv@1.1.3 None 0 5.8 kB developit
npm/has-ansi@2.0.0 None +1 7.29 kB sindresorhus
npm/loglevel-colored-level-prefix@1.0.0 environment +8 684 kB kentcdodds
npm/prettier-eslint@16.3.0 environment, filesystem Transitive: shell, unsafe +87 53.4 MB jounqin
npm/require-relative@0.8.7 unsafe 0 2.26 kB kamicane
npm/vue-eslint-parser@9.4.2 unsafe Transitive: environment, filesystem, shell +58 10.2 MB ota-meshi

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Feb 22, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/prettier-eslint@16.3.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@HowardBraham HowardBraham changed the title fix: prettier-eslint VSCode extension fix: Prettier ESLint VSCode extension Feb 22, 2024
dbrans
dbrans previously approved these changes Feb 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@HowardBraham HowardBraham marked this pull request as ready for review February 22, 2024 01:56
@HowardBraham HowardBraham requested review from a team as code owners February 22, 2024 01:56
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 22, 2024

Builds ready [d68fe95]
Page Load Metrics (1759 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1163281815426
domContentLoaded1093382311
load14942002175913364
domInteractive1093382311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 532 Bytes (0.01%)

@legobeat
Copy link
Copy Markdown
Contributor

legobeat commented Feb 23, 2024 

@SocketSecurity ignore npm/prettier-eslint@16.3.0

new author ok

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.50%. Comparing base (4d2c1ff) to head (3a72a3e).
Report is 17 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #23106   +/-   ##
========================================
  Coverage    68.50%   68.50%           
========================================
  Files         1089     1089           
  Lines        43076    43076           
  Branches     11480    11480           
========================================
  Hits         29507    29507           
  Misses       13569    13569

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 23, 2024

Builds ready [3a72a3e]
Page Load Metrics (1890 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1114252048642
domContentLoaded1183372110
load15472269189018589
domInteractive1183372110
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 532 Bytes (0.01%)

@legobeat legobeat requested a review from dbrans February 23, 2024 04:51
@HowardBraham HowardBraham merged commit e0704de into develop Feb 23, 2024
@HowardBraham HowardBraham deleted the prettier-eslint branch February 23, 2024 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Feb 23, 2024
@HowardBraham HowardBraham added the contributor experience An issue that impacts, or planned improvement to, the contributor experience. label Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgewrmarshall georgewrmarshall Awaiting requested review from georgewrmarshall

@davidmurdoch davidmurdoch Awaiting requested review from davidmurdoch

2 more reviewers

@dbrans dbrans dbrans approved these changes

@legobeat legobeat legobeat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@HowardBraham HowardBraham

Labels

contributor experience An issue that impacts, or planned improvement to, the contributor experience. release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HowardBraham @metamaskbot @legobeat @dbrans