chore: Upgrade core packages to release 159.0.0#26138
Merged
cryptodev-2s merged 48 commits intodevelopfrom Aug 30, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated |
803d024 to
977b628
Compare
Contributor
Author
|
@metamaskbot update-policies |
Gudahtt
reviewed
Jul 30, 2024
Gudahtt
reviewed
Jul 30, 2024
Collaborator
|
Policies updated |
Contributor
|
Migrating
but postponed due to the possibility of breaking dapps:
Has this issue been resolved? I believe |
…packages-release-159
…packages-release-159
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated |
Contributor
Author
|
@metamaskbot update-policies |
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26138 +/- ##
========================================
Coverage 70.10% 70.10%
========================================
Files 1416 1416
Lines 49396 49396
Branches 13802 13802
========================================
Hits 34628 34628
Misses 14768 14768 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [41070b2]
Page Load Metrics (1795 ± 75 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
MajorLift
reviewed
Aug 29, 2024
MajorLift
reviewed
Aug 29, 2024
Collaborator
Builds ready [cc5b68e]
Page Load Metrics (1770 ± 119 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
…packages-release-159
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated |
|
Collaborator
Builds ready [32ecf59]
Page Load Metrics (1706 ± 76 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
MajorLift
reviewed
Aug 30, 2024
| }); | ||
| const phishingController = new PhishingController({ | ||
| // @ts-expect-error TODO: Resolve/patch mismatch between messenger types | ||
| // @ts-expect-error TODO: Resolve mismatch between base-controller versions. |
Contributor
There was a problem hiding this comment.
Note: @metamask/phishing-controller@12.0.1 is now on @metamask/base-controller@7.0.0, while the rest of extension is using @metamask/base-controller@6.0.2.
Mrtenz
approved these changes
Aug 30, 2024
montelaidev
approved these changes
Aug 30, 2024
Contributor
montelaidev
left a comment
There was a problem hiding this comment.
Accounts changes LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade core packages to release 159.0.0.
Upgraded packages:
Description
Related issues
Fixes: #25401
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist