Skip to content

chore(deps): Update json-rpc-engine#23532

Closed
brad-decker wants to merge 9 commits intodevelopfrom
chore/update-json-rpc-engine
Closed

chore(deps): Update json-rpc-engine#23532
brad-decker wants to merge 9 commits intodevelopfrom
chore/update-json-rpc-engine

Conversation

@brad-decker
Copy link
Copy Markdown
Contributor

@brad-decker brad-decker commented Mar 15, 2024 •
edited
Loading

Description

Updates our usage of json-rpc-engine to use @metamask/json-rpc-engine and changes one usage to use the .destroy method instead of looping through the now private _middleware array.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Ensure that all operations of the extension still work, especially dapp interactions

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brad-decker brad-decker added team-extension-platform Extension Platform team dependencies Pull requests that update a dependency file labels Mar 15, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 15, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/json-rpc-engine@6.1.0

View full report↗︎

@brad-decker
Copy link
Copy Markdown
Contributor Author

brad-decker commented Mar 15, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 15, 2024

Policies updated

MajorLift
MajorLift reviewed Mar 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just pointing out a few instances where unknown is passed into JsonRpcRequest's Params generic argument.

This is no longer possible because Params is now constrained by JsonRpcParams. We can fix this simply by omitting Params since its default value is also JsonRpcParams.

@brad-decker @MajorLift
Update app/scripts/lib/rpc-method-middleware/handlers/institutional/m…
da9d383 
…mi-open-add-hardware-wallet.js

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
@brad-decker
Copy link
Copy Markdown
Contributor Author

brad-decker commented Mar 17, 2024

For some reason a unit test is showing a snapshot change in CI but not locally. @NiranjanaBinoy and/or @MajorLift could you pull this locally and run tests to see if you can reproduce the snapshot change?

@MajorLift
Copy link
Copy Markdown
Contributor

MajorLift commented Mar 18, 2024

@brad-decker All jest tests are passing on local for me. Not seeing the snapshot change. :(

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 18, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brad-decker
Copy link
Copy Markdown
Contributor Author

brad-decker commented Mar 18, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 18, 2024

Policies updated

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 17, 2024

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label May 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
@HowardBraham HowardBraham deleted the chore/update-json-rpc-engine branch January 19, 2026 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MajorLift MajorLift MajorLift left review comments

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file stale issues and PRs marked as stale team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brad-decker @metamaskbot @MajorLift @zone-live