Skip to content

chore(deps): upgrade from json-rpc-engine to @metamask/json-rpc-engine#22875

Merged
legobeat merged 18 commits intoMetaMask:developfrom
legobeat:deps-json-rpc-engine
Oct 18, 2024
Merged

chore(deps): upgrade from json-rpc-engine to @metamask/json-rpc-engine#22875
legobeat merged 18 commits intoMetaMask:developfrom
legobeat:deps-json-rpc-engine

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Feb 8, 2024 •
edited
Loading

Description

Related issues

Blocked by

Follow-up to

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat changed the title deps: upgrade from json-rpc-engine to @metamask/json-rpc-engine chore(deps): upgrade from json-rpc-engine to @metamask/json-rpc-engine Feb 23, 2024
@legobeat legobeat force-pushed the deps-json-rpc-engine branch from d5ff260 to 77374b7 Compare March 5, 2024 12:25
@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 5, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/eth-rpc-errors@4.0.3, npm/json-rpc-engine@6.1.0

View full report↗︎

@legobeat legobeat force-pushed the deps-json-rpc-engine branch 3 times, most recently from ba6f305 to c2c9351 Compare March 6, 2024 01:06
@legobeat legobeat force-pushed the deps-json-rpc-engine branch 2 times, most recently from 5aaf166 to 2b3ae27 Compare April 22, 2024 10:49
@legobeat legobeat mentioned this pull request May 6, 2024
Closed
13 tasks
@legobeat legobeat force-pushed the deps-json-rpc-engine branch from 2b3ae27 to 98bc5d5 Compare May 6, 2024 10:37
@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels May 6, 2024
@legobeat legobeat force-pushed the deps-json-rpc-engine branch 14 times, most recently from 9817ec5 to 058be2f Compare May 7, 2024 01:13
@codecov
Copy link
Copy Markdown

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 34.82143% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 65.67%. Comparing base (0dc23ab) to head (0d4602a).

Files Patch % Lines
ui/store/actions.ts 30.95% 29 Missing ⚠️
...method-middleware/handlers/ethereum-chain-utils.js 7.14% 13 Missing ⚠️
ui/store/institutional/institution-background.ts 0.00% 6 Missing ⚠️
shared/modules/error.ts 63.64% 4 Missing ⚠️
ui/ducks/send/helpers.js 0.00% 4 Missing ⚠️
...p/scripts/lib/createRPCMethodTrackingMiddleware.js 25.00% 3 Missing ⚠️
...onents/multichain/import-account/import-account.js 0.00% 3 Missing ⚠️
ui/ducks/send/send.js 40.00% 3 Missing ⚠️
...ontrollers/user-storage/user-storage-controller.ts 33.33% 2 Missing ⚠️
ui/pages/error/error.component.js 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22875      +/-   ##
===========================================
- Coverage    65.70%   65.67%   -0.03%     
===========================================
  Files         1366     1366              
  Lines        54361    54394      +33     
  Branches     14141    14152      +11     
===========================================
+ Hits         35715    35718       +3     
- Misses       18646    18676      +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the deps-json-rpc-engine branch 2 times, most recently from befc171 to 769dff6 Compare May 7, 2024 02:00
@legobeat legobeat mentioned this pull request Oct 11, 2024
Merged
5 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 13, 2024

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@FrederikBolding FrederikBolding mentioned this pull request Oct 14, 2024
Closed
@legobeat legobeat mentioned this pull request Oct 17, 2024
Merged
7 tasks
This was referenced Oct 17, 2024
Closed
Closed
mikesposito
mikesposito approved these changes Oct 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mikesposito mikesposito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested ENS resolution on this branch and it works as expected

Looks great!

legobeat added 16 commits October 17, 2024 21:31
@legobeat
deps: json-rpc-engine@^6.1.0 -> @metamask/json-rpc-engine@^7.3.3
a53cee5
@legobeat
fix: call engine.destroy
919232f
@legobeat
fix: adjust error handling for new json-rpc-engine version
3379771
@legobeat
chore: update expected test results
0ecc38d
@legobeat
update lavamoat policies
0bb5f3c
@legobeat
chore: fix test
e73cb36
@legobeat
chore: fix createUnsupportedMethodMiddleware return type
188ad27
@legobeat
deps: @metamask/json-rpc-engine@^7.3.3->^10.0.0
2908fdd
@legobeat
chore: update lavamoat policies
ee425a7
@legobeat
chore: update test expected error messages
cdee99e
@legobeat
fix legacy import
356da30
@legobeat
fix JsonRpcRequest,JsonRpcResponse imports
0bf69b6
@legobeat
chore: lint:fix
24d4f7d
@legobeat
fix: check for null/undefined param in wallet_requestPermissions requ…
7bd49b7 
…est handling
@legobeat
chore(test): json rpc request params is not optional
40a0197
@legobeat
chore(test): json rpc request params can still be undefined
fd14948
naugtur
naugtur approved these changes Oct 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@naugtur naugtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supply-chain wise:
nothing suspicious in policy changes, but it does reveal a lot of duplication of @metamask/utils which would be nice to address in the future.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 21, 2024

No release label on PR. Adding release label release-12.6.0 on PR, as PR was added to branch 12.6.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@naugtur naugtur naugtur approved these changes

@HowardBraham HowardBraham HowardBraham approved these changes

@mikesposito mikesposito mikesposito approved these changes

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-application-security Application security team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@legobeat @metamaskbot @naugtur @HowardBraham @mikesposito @cryptodev-2s