fix: Include missing files in Sentry release artifact upload#25113
Merged
DDDDDanica merged 1 commit intodevelopfrom Jun 6, 2024
Merged
fix: Include missing files in Sentry release artifact upload#25113DDDDDanica merged 1 commit intodevelopfrom
DDDDDanica merged 1 commit intodevelopfrom
Conversation
danjm
approved these changes
Jun 6, 2024
The Sentry release artifact upload step was assuming that all JavaScript files were at the root of the build directory. This is not the case; in #23672 some of them were moved to a `scripts/` subdirectory. These files have been missing from release artifacts for some time now. The script has been updated to include all JavaScript files included in the build. It references the entire build directory now rather than specifically targetting JavaScript files at the top-level. No additional filter is needed to exclude non-JavaScript files because this command defaults to only including JavaScript and sourcemap files (and some React native files that don't exist in our build). Fixes #25110
1022122 to
db2fea7
Compare
Collaborator
Builds ready [db2fea7]
Page Load Metrics (48 ± 3 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25113 +/- ##
========================================
Coverage 65.66% 65.67%
========================================
Files 1359 1359
Lines 54015 54015
Branches 14017 14017
========================================
+ Hits 35468 35469 +1
+ Misses 18547 18546 -1 ☔ View full report in Codecov by Sentry. |
DDDDDanica
approved these changes
Jun 6, 2024
Collaborator
|
Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was added to branch 12.0.0 when release was cut. |
Collaborator
|
Missing release label release-11.16.8 on PR. Adding release label release-11.16.8 on PR and removing other release labels(release-12.0.0), as PR was cherry-picked in branch 11.16.8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Sentry release artifact upload step was assuming that all JavaScript files were at the root of the build directory. This is not the case; in #23672 some of them were moved to a
scripts/subdirectory. These files have been missing from release artifacts for some time now.The script has been updated to include all JavaScript files included in the build. It references the entire build directory now rather than specifically targetting JavaScript files at the top-level. No additional filter is needed to exclude non-JavaScript files because this command defaults to only including JavaScript and sourcemap files (and some React native files that don't exist in our build).
Related issues
Fixes #25110
Manual testing steps
metamask(if you don't have one already)https://[your username/organization].sentry.io/settings/projects/metamask/source-maps/artifact-bundles/Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist