refactor: make manifest content scripts relative to their dev location#23672
Merged
davidmurdoch merged 1 commit intodevelopfrom Mar 27, 2024
Merged
refactor: make manifest content scripts relative to their dev location#23672davidmurdoch merged 1 commit intodevelopfrom
davidmurdoch merged 1 commit intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
5eda770 to
d93059c
Compare
d93059c to
2c72e10
Compare
Collaborator
Builds ready [2c72e10]
Page Load Metrics (1046 ± 504 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
brad-decker
approved these changes
Mar 25, 2024
digiwand
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webpack build system I'm working on uses the extension manifest JSON files to determine the entry points of the application. The manifest file sometimes references files using a path relative to both the repo and the bundled extension (background.html and popup.html) and sometimes it doesn't (
inpage.jslives in thescriptsfolder).This PR makes the paths relative to the repo (and the bundled extension).