Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
@metamaskbot update-policies |
|
Policies updated |
|
@metamaskbot update-policies |
|
Policies updated |
Builds ready [1a0fed4]
Page Load Metrics (143 ± 180 ms)
|
|
@metamaskbot update-policies |
|
Policies updated |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask-institutional/custody-keyring@1.1.1, npm/bufferutil@4.0.8, npm/utf-8-validate@5.0.10 |
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> A few packages updates for MMI. Fixes: 1. Go to this page... 2. 3. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
|
@metamaskbot update-policies |
|
@metamaskbot update-policies |
|
Policy update failed. You can review the logs or retry the policy update here |
|
Policies updated |
|
@SocketSecurity ignore npm/utf-8-validate@5.0.10 These are all false positives, none of these are added here. The last one is actually being replaced. I'm not sure what's causing this. |
…hrome.offscreen does not exist (#25142) With the update to manifest v3, users on versions older than chrome 109 would have errors thrown from app-init about chrome.offscreen being undefined. Snaps and hardware wallets would be broken for these users. We need to update our minimum supported browser version to 109, but before we do that we need to warn users that there current browser version is out of date. This PR: 1. Handles the of chrome.offscreen being undefined in app-init.js, by simple not attempting to create the offscreen document of chrome.offscreen is undefined 2. Updates the `OUTDATED_BROWSER_VERSIONS` const so that users on chromium versions older than 109 will see a warning about their browser version 3. Adds an additional note to the outdated browser warning to tell users that snaps and hardware wallets won't work on the current version (but only for users on a MV3 version, where there is no offscreen document api) [](https://codespaces.new/MetaMask/metamask-extension/pull/25142?quickstart=1) Fixes: #25116 1. Install a chromium version earlier than 109 (https://www.chromium.org/getting-involved/download-chromium/#downloading-old-builds-of-chrome-chromium) 2. Build, install and onboard on this branch 3. You should see a warning about the browser being out of date, and that snaps and most hardware wallets won't work with this version   - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Builds ready [2d74793]
Page Load Metrics (49 ± 4 ms)
|
|
@albertolive Tested the mmi custodial account transaction flow I tested:
|
See changelog for details