Skip to content

Version v11.16.8#25090

Merged
danjm merged 13 commits intomasterfrom
Version-v11.16.8
Jun 7, 2024
Merged

Version v11.16.8#25090
danjm merged 13 commits intomasterfrom
Version-v11.16.8

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

@zone-live zone-live commented Jun 6, 2024

See changelog for details

@zone-live zone-live requested review from a team as code owners June 6, 2024 08:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jun 6, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@zone-live
Copy link
Copy Markdown
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@metamaskbot metamaskbot added the release-11.16.8 Issue or pull request that will be included in release 11.16.8 label Jun 6, 2024
@zone-live
Copy link
Copy Markdown
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [1a0fed4]
Page Load Metrics (143 ± 180 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7313487147
domContentLoaded9211542
load431773143374180
domInteractive9211542

@zone-live
Copy link
Copy Markdown
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jun 7, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rpc-websockets@8.0.1 None 0 0 B

🚮 Removed packages: npm/@metamask-institutional/custody-keyring@1.1.1, npm/bufferutil@4.0.8, npm/utf-8-validate@5.0.10

View full report↗︎

Gudahtt and others added 2 commits June 7, 2024 11:44
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

A few packages updates for MMI.

Fixes:

1. Go to this page...
2.
3.

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 7, 2024
@zone-live
Copy link
Copy Markdown
Contributor Author

@metamaskbot update-policies

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Jun 7, 2024

@metamaskbot update-policies

@Gudahtt Gudahtt removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 7, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Policy update failed. You can review the logs or retry the policy update here

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Jun 7, 2024

@SocketSecurity ignore npm/utf-8-validate@5.0.10
@SocketSecurity ignore npm/bufferutil@4.0.8
@SocketSecurity ignore npm/rpc-websockets@7.11.1

These are all false positives, none of these are added here. The last one is actually being replaced. I'm not sure what's causing this.

…hrome.offscreen does not exist (#25142)

With the update to manifest v3, users on versions older than chrome 109
would have errors thrown from app-init about chrome.offscreen being
undefined. Snaps and hardware wallets would be broken for these users.

We need to update our minimum supported browser version to 109, but
before we do that we need to warn users that there current browser
version is out of date.

This PR:
1. Handles the of chrome.offscreen being undefined in app-init.js, by
simple not attempting to create the offscreen document of
chrome.offscreen is undefined
2. Updates the `OUTDATED_BROWSER_VERSIONS` const so that users on
chromium versions older than 109 will see a warning about their browser
version
3. Adds an additional note to the outdated browser warning to tell users
that snaps and hardware wallets won't work on the current version (but
only for users on a MV3 version, where there is no offscreen document
api)

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25142?quickstart=1)

Fixes: #25116

1. Install a chromium version earlier than 109
(https://www.chromium.org/getting-involved/download-chromium/#downloading-old-builds-of-chrome-chromium)
2. Build, install and onboard on this branch
3. You should see a warning about the browser being out of date, and
that snaps and most hardware wallets won't work with this version

![Screenshot from 2024-06-07
10-26-34](https://github.com/MetaMask/metamask-extension/assets/7499938/fa1ab356-47eb-4720-916c-72e334d9d0e5)
![Screenshot from 2024-06-07
10-25-59](https://github.com/MetaMask/metamask-extension/assets/7499938/36f78219-3266-4e76-9600-1b5f983ae98a)

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [2d74793]
Page Load Metrics (49 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671017994
domContentLoaded8191342
load40704984
domInteractive8191342

@danjm
Copy link
Copy Markdown
Contributor

danjm commented Jun 7, 2024

@albertolive Tested the mmi custodial account transaction flow
@adonesky1 Tested the hardware switching bug

I tested:

  • installing on chromium v108, seeing the warning
  • installing on v126, not seeing the warning
  • ledger transactions, signatures
  • sending a transaction on an L2 with trezor, swap on an L2 with trezor
  • Snaps and PPOM
  • the auto lock timer bug, both the auto lock working when set to 1 minute, and no error happening when set to empty string
  • being on v11.16.7, hitting the auto lock timer bug, refreshing metamask and then being stuck on the loading screen, updating to v11.16.8 and now being able to log in successfully

@danjm danjm merged commit 7735ab1 into master Jun 7, 2024
@danjm danjm deleted the Version-v11.16.8 branch June 7, 2024 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.16.8 Issue or pull request that will be included in release 11.16.8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants