fix: Update minimum browser warning version, and gracefully fail if chrome.offscreen does not exist by danjm · Pull Request #25142 · MetaMask/metamask-extension

danjm · 2024-06-07T13:10:32Z

Description

With the update to manifest v3, users on versions older than chrome 109 would have errors thrown from app-init about chrome.offscreen being undefined. Snaps and hardware wallets would be broken for these users.

We need to update our minimum supported browser version to 109, but before we do that we need to warn users that there current browser version is out of date.

This PR:

Handles the of chrome.offscreen being undefined in app-init.js, by simple not attempting to create the offscreen document of chrome.offscreen is undefined
Updates the OUTDATED_BROWSER_VERSIONS const so that users on chromium versions older than 109 will see a warning about their browser version
Adds an additional note to the outdated browser warning to tell users that snaps and hardware wallets won't work on the current version (but only for users on a MV3 version, where there is no offscreen document api)

Related issues

Fixes: #25116

Manual testing steps

Install a chromium version earlier than 109 (https://www.chromium.org/getting-involved/download-chromium/#downloading-old-builds-of-chrome-chromium)
Build, install and onboard on this branch
You should see a warning about the browser being out of date, and that snaps and most hardware wallets won't work with this version

Screenshots/Recordings

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

… available

… below 109

…have the offscreen document

github-actions · 2024-06-07T13:10:56Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ui/helpers/constants/common.ts

shared/modules/mv3.utils.js

app/_locales/en/messages.json

Gudahtt · 2024-06-07T13:22:06Z

ui/pages/home/home.component.js

+      isMv3ButOffscreenDocIsMissing ? (
+        <div>
+          <p>{t('outdatedBrowserNotification')}</p>
+          <p>{t('browserDoesntSupportHWandSnaps')}</p>


Nit: The spacing between these doesn't seem right, maybe a <br> would look better in between?

Also the second message seems higher priority, but I can see it being easy to scan past. Maybe we could consider bolding it, or putting it first, or both

Updated in bfe2ef4

I used bold weight and a warning message color

Nice, yeah that looks better I think

…tsOrSnapsSupport

Gudahtt

LGTM!

Lint failures

codecov · 2024-06-07T14:54:59Z

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.66%. Comparing base (bba6016) to head (642124a).
Report is 6 commits behind head on develop.

Files	Patch %	Lines
ui/pages/home/home.component.js	66.67%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25142   +/-   ##
========================================
  Coverage    65.66%   65.66%           
========================================
  Files         1359     1359           
  Lines        54014    54020    +6     
  Branches     14015    14019    +4     
========================================
+ Hits         35464    35469    +5     
- Misses       18550    18551    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NiranjanaBinoy

lgtm

metamaskbot · 2024-06-07T15:23:36Z

Builds ready [642124a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (50 ± 2 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	101	82	8	4
		domContentLoaded	9	12	10	1	0
		load	45	60	50	5	2
		domInteractive	9	12	10	1	0

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 439 Bytes (0.01%)
common: 283 Bytes (0.00%)

metamaskbot · 2024-06-07T16:09:15Z

Missing release label release-11.16.8 on PR. Adding release label release-11.16.8 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 11.16.8.

danjm added 3 commits June 7, 2024 10:31

Prevent error in the service worker if there is no offscreen document…

20498a1

… available

Start showing outdated browser warnings to chromium users on versions…

56ee922

… below 109

Add detail to outdated browser warnings for users on MV3 that do not …

e33ac3c

…have the offscreen document

danjm requested a review from a team as a code owner June 7, 2024 13:10

danjm changed the title ~~Minimum browser offscreen~~ Update minimum browser warning version, and gracefully fail if chrome.offscreen does not exist Jun 7, 2024