Skip to content

Cherry pick 0d839b1 v11.16.7#25072

Merged
danjm merged 1 commit intoVersion-v11.16.7from
cherry-pick-0d839b1-v11.16.7
Jun 5, 2024
Merged

Cherry pick 0d839b1 v11.16.7#25072
danjm merged 1 commit intoVersion-v11.16.7from
cherry-pick-0d839b1-v11.16.7

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Jun 5, 2024

cherry-pick #24951 to v11.16.7

## **Description**

Replaces this PR:
#22092
The PR is the same but with `develop` branch as origin instead of
`fix/sentry-sessions` branch.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24951?quickstart=1)

## **Related issues**

- None

## **Manual testing steps**

See this PR: #22092

## **Screenshots/Recordings**

See this PR: #22092

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: HJetpoluru <harika.jetpoluru@consensys.net>
Co-authored-by: Harika Jetpoluru <153644847+hjetpoluru@users.noreply.github.com>
@danjm danjm requested review from a team and kumavis as code owners June 5, 2024 16:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm changed the base branch from develop to Version-v11.16.7 June 5, 2024 16:43
@danjm danjm merged commit 061e40a into Version-v11.16.7 Jun 5, 2024
@danjm danjm deleted the cherry-pick-0d839b1-v11.16.7 branch June 5, 2024 16:44
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
@metamaskbot metamaskbot added the release-11.16.7 Issue or pull request that will be included in release 11.16.7 label Jun 5, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-11.16.7 on PR, as PR was cherry-picked in branch 11.16.7.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.7 Issue or pull request that will be included in release 11.16.7

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants