chore(sentry): enable performance monitoring#24951
Merged
Conversation
Flaky tests issues do not match our issues templates. Their description just includes a link to cricleci.
Setting a value for tracesSampleRate enables performance monitoring in Sentry. Once performance monitoring is enabled, transactions are sent to Sentry every time a user loads a page or navigates within the app. Since the amount of traffic the app gets is important, this means a lot of transactions are sent. By setting tracesSampleRate to a value lower than 1.0, we reduce the volume of transactions to a more reasonable amount. Given tracesSampleRate is currently set to 0.04 for Mobile and given that the amount of MAU is more than 3x more important for Extension, we can set tracesSampleRate to 0.01 for Extension in order not to exceed our account limits.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
13 tasks
… feat/sentry-performance-monitoring-2
… feat/sentry-performance-monitoring-2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24951 +/- ##
========================================
Coverage 65.68% 65.68%
========================================
Files 1371 1371
Lines 54431 54431
Branches 14166 14166
========================================
Hits 35753 35753
Misses 18678 18678 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [60be631]
Page Load Metrics (114 ± 138 ms)
|
danjm
approved these changes
Jun 4, 2024
Collaborator
Builds ready [515439c]
Page Load Metrics (47 ± 4 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [de7302b]
Page Load Metrics (119 ± 140 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces this PR: #22092
The PR is the same but with
developbranch as origin instead offix/sentry-sessionsbranch.Related issues
Manual testing steps
See this PR: #22092
Screenshots/Recordings
See this PR: #22092
Pre-merge author checklist
Pre-merge reviewer checklist