chore(sentry): enable performance monitoring#22092
chore(sentry): enable performance monitoring#22092gauthierpetetin wants to merge 2 commits intofix/sentry-sessionsfrom
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
88ae1ad to
34dd812
Compare
a17fb3d to
a2a9bdf
Compare
0363173 to
a7d6c5a
Compare
app/scripts/lib/setupSentry.js
Outdated
| * transactions are sent. By setting `tracesSampleRate` to a value lower than 1.0, we | ||
| * reduce the volume of transactions to a more reasonable amount. | ||
| */ | ||
| tracesSampleRate: 0.1, |
There was a problem hiding this comment.
Mobile is using a sampling rate of 0.05, and even that small a rate is a huge amount of events. We should consider adjusting this based upon our current account limits, also taking into consideration the userbase between extension and mobile.
There was a problem hiding this comment.
Given tracesSampleRate is currently set to 0.04 for Mobile and given that the amount of MAU is more than 3x more important for Extension, I guess we can set tracesSampleRate to 0.01 for Extension.
Setting a value for tracesSampleRate enables performance monitoring in Sentry. Once performance monitoring is enabled, transactions are sent to Sentry every time a user loads a page or navigates within the app. Since the amount of traffic the app gets is important, this means a lot of transactions are sent. By setting tracesSampleRate to a value lower than 1.0, we reduce the volume of transactions to a more reasonable amount.
50ab199 to
47fe250
Compare
|
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
|
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions. |
Given tracesSampleRate is currently set to 0.04 for Mobile and given that the amount of MAU is more than 3x more important for Extension, we can set tracesSampleRate to 0.01 for Extension in order not to exceed our account limits.
|
Replaced by this PR: #24951 |
Description
Setting a value for
tracesSampleRateenables performance monitoring in Sentry. Once performance monitoring is enabled, transactions are sent to Sentry every time a user loads a page or navigates within the app. Since the amount of traffic the app gets is important, this means a lot of transactions are sent. By settingtracesSampleRateto a value lower than 1.0, we reduce the volume of transactions to a more reasonable amount.Sentry documentation
Mobile implementation
Enabling Sentry performance monitoring will allow us to add

app load timeto our North Star metrics dashboards, like we do for Mobile.Related issues
Manual testing steps
Create your own Sentry instance
Go to Sentry Performance dashboard and you shall see no transaction
Select
Settingsin the sidebar menu, then selectProjectsin the secondary menu. Click your project then selectClient Keys (DSN)from the secondary menu. Click theConfigurebutton on theClient Keyspage and copy yourProject IdandPublic Key.Add/replace
SENTRY_DSN_DEVvariable in.metamaskrcBuild the project to the
./dist/folder withyarn distAdd Extension to your browser
Open Extension and do some actions
Kill the Extension
Go to Sentry Performance dashboard and you shall see a few transactions
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist