Skip to content

cherry-pick feat: Revert disable stx opt-in modal (#24845) into v11.16.1#24848

Merged
dbrans merged 1 commit intoVersion-v11.16.1from
Version-v11.16.1-stx-enable-opt-in-modal
May 28, 2024
Merged

cherry-pick feat: Revert disable stx opt-in modal (#24845) into v11.16.1#24848
dbrans merged 1 commit intoVersion-v11.16.1from
Version-v11.16.1-stx-enable-opt-in-modal

Conversation

@dbrans
Copy link
Copy Markdown
Contributor

@dbrans dbrans commented May 28, 2024

cherry-pick feat: Revert disable stx opt-in modal abc0268 (#24845) into v11.16.1

no merge conflicts

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dbrans dbrans marked this pull request as ready for review May 28, 2024 22:27
@dbrans dbrans requested a review from a team as a code owner May 28, 2024 22:27
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 28, 2024
Once this is merged, this PR will be cherry-picked into 11.16.1

This reverts commit 20e51e6.

Per discussion relating to the feature flag http request for stx, we are
re-enabling the stx opt-in-modal.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24845?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@dbrans dbrans force-pushed the Version-v11.16.1-stx-enable-opt-in-modal branch from 915c6a2 to f867b00 Compare May 28, 2024 22:31
@dbrans dbrans merged commit e773dcd into Version-v11.16.1 May 28, 2024
@dbrans dbrans deleted the Version-v11.16.1-stx-enable-opt-in-modal branch May 28, 2024 23:21
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [f867b00]
Page Load Metrics (994 ± 545 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint652601134622
domContentLoaded9112282211
load5426009941135545
domInteractive9112282211

@metamaskbot metamaskbot added the release-11.16.1 Issue or pull request that will be included in release 11.16.1 label May 29, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-11.16.1 on PR, as PR was cherry-picked in branch 11.16.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.1 Issue or pull request that will be included in release 11.16.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants