Skip to content

feat: disable stx opt-in modal#24715

Merged
dbrans merged 1 commit intodevelopfrom
dbrans/disable-stx-opt-in-modal
May 22, 2024
Merged

feat: disable stx opt-in modal#24715
dbrans merged 1 commit intodevelopfrom
dbrans/disable-stx-opt-in-modal

Conversation

@dbrans
Copy link
Copy Markdown
Contributor

@dbrans dbrans commented May 22, 2024 •
edited
Loading

Description

Temporarily disable the smart transactions opt-in modal to unblock the 11.15 rollout.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dbrans dbrans added the team-transactions Transactions team label May 22, 2024
@dbrans dbrans changed the title disable stx opt-in modal feat: disable stx opt-in modal May 22, 2024
@dbrans dbrans marked this pull request as ready for review May 22, 2024 17:08
@dbrans dbrans requested a review from a team as a code owner May 22, 2024 17:08
@dbrans dbrans force-pushed the dbrans/disable-stx-opt-in-modal branch from 166fd22 to e5da14c Compare May 22, 2024 17:38
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 22, 2024

Builds ready [e5da14c]
Page Load Metrics (599 ± 438 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint66150942311
domContentLoaded8391594
load542422599913438
domInteractive8391594
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -2 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@dbrans dbrans merged commit 20e51e6 into develop May 22, 2024
@dbrans dbrans deleted the dbrans/disable-stx-opt-in-modal branch May 22, 2024 18:14
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
@metamaskbot metamaskbot added release-11.18.0 release-11.15.6 Issue or pull request that will be included in release 11.15.6 and removed release-11.18.0 labels May 22, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 22, 2024

Missing release label release-11.15.6 on PR. Adding release label release-11.15.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.15.6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@infiniteflower infiniteflower infiniteflower approved these changes

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.15.6 Issue or pull request that will be included in release 11.15.6 team-transactions Transactions team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dbrans @metamaskbot @danjm @infiniteflower