Skip to content

feat: Revert disable stx opt-in modal (#24715)#24845

Merged
dbrans merged 1 commit intodevelopfrom
dbrans/stx-enable-opt-in-modal
May 28, 2024
Merged

feat: Revert disable stx opt-in modal (#24715)#24845
dbrans merged 1 commit intodevelopfrom
dbrans/stx-enable-opt-in-modal

Conversation

@dbrans
Copy link
Copy Markdown
Contributor

@dbrans dbrans commented May 28, 2024 •
edited by github-actions bot
Loading

Once this is merged, this PR will be cherry-picked into 11.16.1

This reverts commit 20e51e6.

Per discussion relating to the feature flag http request for stx, we are re-enabling the stx opt-in-modal.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dbrans dbrans marked this pull request as ready for review May 28, 2024 20:46
@dbrans dbrans requested a review from a team as a code owner May 28, 2024 20:46
@dbrans dbrans added the team-transactions Transactions team label May 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 28, 2024

Builds ready [fb02dcb]
Page Load Metrics (423 ± 403 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64157972411
domContentLoaded8171221
load522630423838403
domInteractive8171221
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 2 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@dbrans dbrans merged commit abc0268 into develop May 28, 2024
@dbrans dbrans deleted the dbrans/stx-enable-opt-in-modal branch May 28, 2024 22:18
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@metamaskbot metamaskbot added release-11.18.0 release-11.16.1 Issue or pull request that will be included in release 11.16.1 and removed release-11.18.0 labels May 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 29, 2024

Missing release label release-11.16.1 on PR. Adding release label release-11.16.1 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sleepytanya sleepytanya sleepytanya approved these changes

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.16.1 Issue or pull request that will be included in release 11.16.1 team-transactions Transactions team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dbrans @metamaskbot @danjm @sleepytanya