Skip to content

revert (cherry-pick): deprecating more networks (#23695)#24524

Merged
danjm merged 2 commits intoVersion-v11.16.0from
Version-v11.16.0-cherry-pick-revert-depricate-linea-goerli
May 23, 2024
Merged

revert (cherry-pick): deprecating more networks (#23695)#24524
danjm merged 2 commits intoVersion-v11.16.0from
Version-v11.16.0-cherry-pick-revert-depricate-linea-goerli

Conversation

@salimtb
Copy link
Copy Markdown
Contributor

@salimtb salimtb commented May 14, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 14, 2024
@salimtb salimtb requested review from a team as code owners May 14, 2024 16:39
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label May 14, 2024
@danjm danjm changed the title revert: deprecating more networks (#23695) revert (cherry-pick): deprecating more networks (#23695) May 14, 2024
@salimtb salimtb force-pushed the Version-v11.16.0-cherry-pick-revert-depricate-linea-goerli branch 4 times, most recently from ceec913 to 0b29f31 Compare May 14, 2024 17:24
@danjm danjm force-pushed the Version-v11.16.0-cherry-pick-revert-depricate-linea-goerli branch from 0b29f31 to 733b409 Compare May 20, 2024 21:42
@salimtb salimtb force-pushed the Version-v11.16.0-cherry-pick-revert-depricate-linea-goerli branch 4 times, most recently from 6460d1f to ab875cc Compare May 21, 2024 01:30
@salimtb salimtb force-pushed the Version-v11.16.0-cherry-pick-revert-depricate-linea-goerli branch from ab875cc to 1ec647e Compare May 21, 2024 01:34
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [1ec647e]
Page Load Metrics (1412 ± 530 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint604181418038
domContentLoaded10105352612
load49273914121104530
domInteractive10105352612

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [1ec647e]
Page Load Metrics (1412 ± 530 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint604181418038
domContentLoaded10105352612
load49273914121104530
domInteractive10105352612

#24369 reverted the
commit that introduced migration 115. Instead of deleting 115, it
modified it. The problem with this is:
- the migration now does nothing
- the migration can't just be updated in the future, because after it
runs once for a user, it will never be run again

What we need to do is delete migration 115 and then rename the
subsequent migrations to one number lower (and update their contents to
reflect these new migration numbers. Then, when the reverted changes are
restored, the migration can be re-added as the new highest numbered
migration.

This PR makes the changes needed to delete migration 115 over multiple
commits, for ease of review. Reviewing this PR is really easy _if_ you
review commit by commit (but Github can't easily display the simplicity
of the changes when they are all together). Below I have briefly
described each commit and included a screenshot of what you will see if
you click the link to look at that commit directly

e7d4cb5 **Deletes** the existing
migration 115 files
![Screenshot from 2024-05-21
05-03-03](https://github.com/MetaMask/metamask-extension/assets/7499938/f062276d-5fa8-4857-880a-4ae1daefb229)

8d78df3 **Renames** the existing
migration 116 files to migration 115 files
![Screenshot from 2024-05-21
05-03-23](https://github.com/MetaMask/metamask-extension/assets/7499938/199e8d94-5101-472a-83b7-13b2d94037b9)

3023d17 **Renames** the existing
migration 117 files to migration 116 files
![Screenshot from 2024-05-21
05-03-39](https://github.com/MetaMask/metamask-extension/assets/7499938/7fddc54d-8e0a-44f7-ad14-00cf12041f14)

23f121b **Renames** the existing
migration 118 files to migration 117 files
![Screenshot from 2024-05-21
05-04-15](https://github.com/MetaMask/metamask-extension/assets/7499938/7c97a3aa-7f22-4db2-a7b7-bacbd9fca7b9)

f6cbb92 **Renames** the existing
migration 119 files to migration 118 files
![Screenshot from 2024-05-21
05-04-28](https://github.com/MetaMask/metamask-extension/assets/7499938/223cc3f9-b3a2-4b42-ae9a-3eba526d8968)

f40afd7 **Modifies** the renamed files
from the previous commits, so that any number within those files in the
range 115-119 is replaced by the number one below.
![Screenshot from 2024-05-21
05-05-29](https://github.com/MetaMask/metamask-extension/assets/7499938/3a680ca8-1c30-4e6e-bace-7c8b206cdb7e)

088ecd5 Just deletes 1 line from
app/scripts/migrations/index.js

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24666?quickstart=1)

1. Create a local build on the master branch, install and onboard
2. Create a build on this branch, install
3. In the background console, you should see logs that show migrations
115 to 118 running successfully

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [c26b26d]
Page Load Metrics (795 ± 473 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint691741022512
domContentLoaded105325116
load572291795984473
domInteractive105325116

@danjm danjm merged commit ad0234b into Version-v11.16.0 May 23, 2024
@danjm danjm deleted the Version-v11.16.0-cherry-pick-revert-depricate-linea-goerli branch May 23, 2024 09:22
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label May 23, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-11.16.0 on PR, as PR was cherry-picked in branch 11.16.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.16.0 Issue or pull request that will be included in release 11.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants