revert (cherry-pick): deprecating more networks (#23695)#24524
Merged
danjm merged 2 commits intoVersion-v11.16.0from May 23, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
danjm
reviewed
May 14, 2024
ceec913 to
0b29f31
Compare
0b29f31 to
733b409
Compare
6460d1f to
ab875cc
Compare
ab875cc to
1ec647e
Compare
Collaborator
Builds ready [1ec647e]
Page Load Metrics (1412 ± 530 ms)
|
Collaborator
Builds ready [1ec647e]
Page Load Metrics (1412 ± 530 ms)
|
#24369 reverted the commit that introduced migration 115. Instead of deleting 115, it modified it. The problem with this is: - the migration now does nothing - the migration can't just be updated in the future, because after it runs once for a user, it will never be run again What we need to do is delete migration 115 and then rename the subsequent migrations to one number lower (and update their contents to reflect these new migration numbers. Then, when the reverted changes are restored, the migration can be re-added as the new highest numbered migration. This PR makes the changes needed to delete migration 115 over multiple commits, for ease of review. Reviewing this PR is really easy _if_ you review commit by commit (but Github can't easily display the simplicity of the changes when they are all together). Below I have briefly described each commit and included a screenshot of what you will see if you click the link to look at that commit directly e7d4cb5 **Deletes** the existing migration 115 files  8d78df3 **Renames** the existing migration 116 files to migration 115 files  3023d17 **Renames** the existing migration 117 files to migration 116 files  23f121b **Renames** the existing migration 118 files to migration 117 files  f6cbb92 **Renames** the existing migration 119 files to migration 118 files  f40afd7 **Modifies** the renamed files from the previous commits, so that any number within those files in the range 115-119 is replaced by the number one below.  088ecd5 Just deletes 1 line from app/scripts/migrations/index.js [](https://codespaces.new/MetaMask/metamask-extension/pull/24666?quickstart=1) 1. Create a local build on the master branch, install and onboard 2. Create a build on this branch, install 3. In the background console, you should see logs that show migrations 115 to 118 running successfully - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Collaborator
Builds ready [c26b26d]
Page Load Metrics (795 ± 473 ms)
|
Collaborator
|
No release label on PR. Adding release label release-11.16.0 on PR, as PR was cherry-picked in branch 11.16.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist