Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7 tasks
salimtb
approved these changes
May 21, 2024
vthomas13
approved these changes
May 21, 2024
Collaborator
Builds ready [adf5e25]
Page Load Metrics (1129 ± 570 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24666 +/- ##
===========================================
- Coverage 67.40% 67.39% -0.01%
===========================================
Files 1289 1288 -1
Lines 50248 50240 -8
Branches 13011 13011
===========================================
- Hits 33865 33857 -8
Misses 16383 16383 ☔ View full report in Codecov by Sentry. |
DDDDDanica
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#24369 reverted the commit that introduced migration 115. Instead of deleting 115, it modified it. The problem with this is:
What we need to do is delete migration 115 and then rename the subsequent migrations to one number lower (and update their contents to reflect these new migration numbers. Then, when the reverted changes are restored, the migration can be re-added as the new highest numbered migration.
This PR makes the changes needed to delete migration 115 over multiple commits, for ease of review. Reviewing this PR is really easy if you review commit by commit (but Github can't easily display the simplicity of the changes when they are all together). Below I have briefly described each commit and included a screenshot of what you will see if you click the link to look at that commit directly
e7d4cb5 Deletes the existing migration 115 files

8d78df3 Renames the existing migration 116 files to migration 115 files

3023d17 Renames the existing migration 117 files to migration 116 files

23f121b Renames the existing migration 118 files to migration 117 files

f6cbb92 Renames the existing migration 119 files to migration 118 files

f40afd7 Modifies the renamed files from the previous commits, so that any number within those files in the range 115-119 is replaced by the number one below.

088ecd5 Just deletes 1 line from app/scripts/migrations/index.js
Manual testing steps
Pre-merge author checklist
Pre-merge reviewer checklist