fix: deprecating more networks by sahar-fehri · Pull Request #23695 · MetaMask/metamask-extension

sahar-fehri · 2024-03-25T12:51:37Z

Description

Deprecates Mumbai and linea goerli test networks.
Users should see a deprecation warning when switching to those networks.
Linea goerli is removed from the default network list.

Related issues

ticket: https://consensyssoftware.atlassian.net/browse/MMASSETS-183
patch for controller-utils: https://github.com/MetaMask/metamask-extension/pull/23727/files

Manual testing steps

Go to home page
Click on network selector, You should not see Linea testnet in the list.
Add Mumbai network to metamask
You should see deprecation warning

Screenshots/Recordings

Before

Linea goerli appears in the list of default networks

After

In this video initially the user is on Linea goerli (i am on develop branch), the user makes a few transactions on linea goerli,
then i switch to this branch so the migration runs, and notice that the user has switeched to linea-sepolia.
Linea goerli is removed from the default networks tab.
When the user adds linea-goerli using chainlist, he sees the deprecation warning and his transactions.

deprecation1.mov

This short video shows the deprecation warning when we switch to Mumbai network

Screen.Recording.2024-03-26.at.16.12.46.mov

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-03-25T12:51:48Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sentry · 2024-03-25T12:52:14Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: ui/pages/confirmations/confirmation/templates/add-ethereum-chain.js

Function	Unhandled Issue
`addEthereumChain.getAlerts`	TypeError: Failed to construct 'URL': Invalid URL new URL(/metamask/runtime-lavamoat.js... `Event Count:` 1 `Affected Users:` 0

_{Did you find this useful? React with a 👍 or 👎}

metamaskbot · 2024-03-25T13:33:06Z

Builds ready [850fa2e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (964 ± 525 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	378	141	77	37
		domContentLoaded	11	73	31	18	9
		load	56	3027	964	1093	525
		domInteractive	11	73	31	18	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -30 Bytes (-0.00%)
ui: -429 Bytes (-0.01%)
common: -115 Bytes (-0.00%)

codecov · 2024-03-25T13:33:54Z

Codecov Report

Attention: Patch coverage is 96.77419% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.61%. Comparing base (1098a10) to head (03a1e14).
Report is 69 commits behind head on develop.

Files	Patch %	Lines
...tions/confirmation/templates/add-ethereum-chain.js	85.71%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #23695      +/-   ##
===========================================
+ Coverage    67.54%   67.61%   +0.07%     
===========================================
  Files         1245     1246       +1     
  Lines        48866    48885      +19     
  Branches     12744    12754      +10     
===========================================
+ Hits         33005    33053      +48     
+ Misses       15861    15832      -29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-03-25T23:42:18Z

Builds ready [419d3ba]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1135 ± 551 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	89	402	151	66	32
		domContentLoaded	12	60	28	12	6
		load	68	2582	1135	1147	551
		domInteractive	12	60	28	12	6

Bundle size diffs [🚀 Bundle size reduced!]

background: -30 Bytes (-0.00%)
ui: -367 Bytes (-0.00%)
common: -115 Bytes (-0.00%)

metamaskbot · 2024-03-26T13:32:47Z

Builds ready [43c3db5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (826 ± 482 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	178	113	28	13
		domContentLoaded	10	53	24	14	7
		load	52	2414	826	1003	482
		domInteractive	10	53	24	14	7

Bundle size diffs [🚀 Bundle size reduced!]

background: -30 Bytes (-0.00%)
ui: -367 Bytes (-0.01%)
common: -130 Bytes (-0.00%)

metamaskbot · 2024-03-26T22:56:43Z

Builds ready [c39ecae]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (415 ± 361 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	187	120	31	15
		domContentLoaded	9	69	33	18	9
		load	54	2546	415	752	361
		domInteractive	9	69	33	18	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.05 KiB (0.06%)
ui: -367 Bytes (-0.01%)
common: -130 Bytes (-0.00%)

davidmurdoch · 2024-03-27T21:53:53Z

Why do we need to patch controller utils? Couldn't be update the package instead?

metamaskbot · 2024-04-12T18:13:09Z

Builds ready [4c91b58]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (552 ± 452 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	74	147	104	20	10
		domContentLoaded	9	58	26	13	6
		load	53	2870	552	941	452
		domInteractive	9	58	26	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.05 KiB (0.06%)
ui: -356 Bytes (-0.01%)
common: -331 Bytes (-0.01%)

ui/selectors/selectors.js

metamaskbot · 2024-04-15T08:15:37Z

Builds ready [59155fd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (866 ± 508 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	322	150	76	36
		domContentLoaded	9	71	36	19	9
		load	53	2539	866	1057	508
		domInteractive	9	71	36	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.05 KiB (0.06%)
ui: -356 Bytes (-0.01%)
common: -302 Bytes (-0.00%)

darkwing

Tiny nit! Otherwise looks great!

app/scripts/migrations/115.ts

ui/pages/confirmations/confirmation/templates/add-ethereum-chain.js

metamaskbot · 2024-04-16T07:18:19Z

Builds ready [03a1e14]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (660 ± 480 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	375	137	82	39
		domContentLoaded	10	63	30	16	8
		load	49	2631	660	1000	480
		domInteractive	9	63	30	16	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.04 KiB (0.06%)
ui: -356 Bytes (-0.01%)
common: -302 Bytes (-0.00%)

metamaskbot · 2024-05-07T18:07:55Z

Missing release label release-11.16.0 on PR. Adding release label release-11.16.0 on PR and removing other release labels(release-11.17.0), as PR was added to branch 11.16.0 when release was cut.

sahar-fehri requested a review from a team as a code owner March 25, 2024 12:51

sahar-fehri marked this pull request as draft March 25, 2024 12:51

sahar-fehri changed the title ~~Fix/deprecating more networks~~ fix: deprecating more networks Mar 25, 2024

sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets labels Mar 25, 2024

sahar-fehri force-pushed the fix/deprecating-more-networks branch from dbc9115 to ee86abf Compare March 25, 2024 13:01

sahar-fehri force-pushed the fix/deprecating-more-networks branch from 419d3ba to 43c3db5 Compare March 26, 2024 13:11

sahar-fehri added 9 commits March 26, 2024 23:20

fix: add deprecation warning for polygon

265028f

fix: deprecate linea goerli

b0343e7

fix: fix test

28ea8f3

fix: fix test

e7cc6ba

fix: update snapshot

d1b5c0f

fix: fix deprecation msg for mumbai

826d48a

fix: rebase

bbdae3b

fix: migrate users from linea goerli to linea sepolia

c2f1927

fix: rebase

8792318

sahar-fehri force-pushed the fix/deprecating-more-networks branch from 46fbbbc to 8792318 Compare March 26, 2024 22:22

sahar-fehri self-assigned this Mar 26, 2024

sahar-fehri marked this pull request as ready for review March 26, 2024 22:26

sahar-fehri requested review from a team as code owners March 26, 2024 22:26

fix: lint

c39ecae

fix: merge conflicts

a50c19c

sahar-fehri dismissed stale reviews from bergeron, darkwing, DDDDDanica, and brad-decker via a50c19c April 12, 2024 17:20

fix: fix unit test

4c91b58

darkwing reviewed Apr 12, 2024

View reviewed changes

ui/selectors/selectors.js Outdated Show resolved Hide resolved

fix: fix

59155fd

pedronfigueiredo previously approved these changes Apr 15, 2024

View reviewed changes

darkwing suggested changes Apr 15, 2024

View reviewed changes

app/scripts/migrations/115.ts Outdated Show resolved Hide resolved

jpuri reviewed Apr 16, 2024

View reviewed changes

ui/pages/confirmations/confirmation/templates/add-ethereum-chain.js Show resolved Hide resolved

fix: add unit test

e264161

sahar-fehri dismissed pedronfigueiredo’s stale review via e264161 April 16, 2024 06:54

fix: fix migration

03a1e14

jpuri approved these changes Apr 16, 2024

View reviewed changes

sahar-fehri requested a review from darkwing April 16, 2024 13:44

darkwing approved these changes Apr 16, 2024

View reviewed changes

salimtb approved these changes Apr 16, 2024

View reviewed changes

sahar-fehri merged commit 257e9f9 into develop Apr 16, 2024

sahar-fehri deleted the fix/deprecating-more-networks branch April 16, 2024 15:23

github-actions bot locked and limited conversation to collaborators Apr 16, 2024

metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 16, 2024

benjisclowder added release-11.17.0 and removed release-11.16.0 Issue or pull request that will be included in release 11.16.0 labels May 7, 2024

metamaskbot added release-11.16.0 Issue or pull request that will be included in release 11.16.0 and removed release-11.17.0 labels May 7, 2024

Conversation

sahar-fehri commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 25, 2024

Uh oh!

sentry bot commented Mar 25, 2024

🔍 Existing Issues For Review

Uh oh!

metamaskbot commented Mar 25, 2024

Uh oh!

codecov bot commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Mar 25, 2024

Uh oh!

metamaskbot commented Mar 26, 2024

Uh oh!

metamaskbot commented Mar 26, 2024

Uh oh!

davidmurdoch commented Mar 27, 2024

Uh oh!

metamaskbot commented Apr 12, 2024

Uh oh!

Uh oh!

metamaskbot commented Apr 15, 2024

Uh oh!

darkwing left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Apr 16, 2024

Uh oh!

metamaskbot commented May 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

sahar-fehri commented Mar 25, 2024 •

edited

Loading

codecov bot commented Mar 25, 2024 •

edited

Loading