Fixing sign button color and replacing deprecated components in SignatureRequestOriginalWarning#22741
Merged
georgewrmarshall merged 3 commits intodevelopfrom Jan 31, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| @import 'signature-request/index'; | ||
| @import 'signature-request-siwe/index'; | ||
| @import 'signature-request-original/index'; | ||
| @import 'signature-request-original/signature-request-original-warning/index'; |
Contributor
Author
There was a problem hiding this comment.
Removing import to deleted SCSS file
| width: 100%; | ||
| height: 132px; | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
No longer need this CSS
| import PropTypes from 'prop-types'; | ||
| import { useI18nContext } from '../../../../hooks/useI18nContext'; | ||
|
|
||
| import Popover from '../../../ui/popover'; |
Contributor
Author
There was a problem hiding this comment.
This version of the Popover is deprecated
| driver, | ||
| '[data-testid="page-container-footer-next"]', | ||
| '.signature-request-warning__footer__sign-button', | ||
| '[data-testid="signature-warning-sign-button"]', |
Contributor
Author
There was a problem hiding this comment.
Replacing removed class name with data test id
| await driver.clickElement('[data-testid="page-container-footer-next"]'); | ||
| await driver.clickElement( | ||
| '.signature-request-warning__footer__sign-button', | ||
| '[data-testid="signature-warning-sign-button"]', |
Contributor
Author
There was a problem hiding this comment.
Replacing removed class name with data test id
Collaborator
Builds ready [c37ec36]
Page Load Metrics (895 ± 46 ms)
Bundle size diffs
|
DDDDDanica
approved these changes
Jan 31, 2024
Contributor
|
LGTM! |
NidhiKJha
approved these changes
Jan 31, 2024
Contributor
Author
|
Fixes missing overlay #22756 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a Sev2 visual regression bug that occurred due to incorrect migration of component API in a previous PR, which aimed to update stale components with component library components. Not only does this PR rectify these visual regressions, but it also extends the integration of the component library by replacing additional stale components.
Related issues
Fixes: #22171
Manual testing steps
To check component updates
SignatureRequestOriginalWarningin the search barSignatureRequestOriginalWarningmodal component with correct buttonsTo check component works in app
SignatureRequestOriginalWarningmodalScreenshots/Recordings
Before
before1080.mov
After
after1080.mov
Screencast below shows working in app
after.app.mov
Pre-merge author checklist
Pre-merge reviewer checklist