Part of #18714: Replacing deprecated constants and components#20070
Merged
NidhiKJha merged 1 commit intoMetaMask:developfrom Jul 19, 2023
Merged
Part of #18714: Replacing deprecated constants and components#20070NidhiKJha merged 1 commit intoMetaMask:developfrom
NidhiKJha merged 1 commit intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report
@@ Coverage Diff @@
## develop #20070 +/- ##
===========================================
- Coverage 69.42% 69.42% -0.01%
===========================================
Files 990 990
Lines 37418 37418
Branches 10039 10039
===========================================
- Hits 25976 25974 -2
- Misses 11442 11444 +2
|
NidhiKJha
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
ui/components/app/signature-request-original/signature-request-original-warningScreenshots/Screencaps
After
unit test coverage
Manual Testing Steps
SignatureRequestOriginalWarningon this branchPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.