Skip to content

Adding missing modal overlay to signature request original warning#22756

Merged
georgewrmarshall merged 1 commit intodevelopfrom
fix/22171/missing-overlay
Jan 31, 2024
Merged

Adding missing modal overlay to signature request original warning#22756
georgewrmarshall merged 1 commit intodevelopfrom
fix/22171/missing-overlay

Conversation

@georgewrmarshall
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall commented Jan 31, 2024 •
edited
Loading

Description

In a previous PR, I unintentionally left out a commit from my local setup that added a modal overlay to the SignatureRequestOriginalWarning modal. The before/after videos I used were from my local setup, which mistakenly suggested that the modal overlay was included in the PR. This current PR rectifies that oversight by including the ModalOverlay, thereby resolving the missing overlay issue for the modal.

Related issues

Related: #22171

Manual testing steps

To check modal overlay in storybook

  1. Go to the storybook build of this PR
  2. Search SignatureRequestOriginalWarning in the search bar
  3. See that the ModalOverlay is included compared to develop build of storybook

To check modal overlay works in app

  1. Enable eth sign from settings
  2. Go to test dapp
  3. Trigger Eth Sign
  4. Accept
  5. See SignatureRequestOriginalWarning modal

Screenshots/Recordings

Before

Storybook showing no modal overlay

before.mov

In app showing modal overlay missing

before.app.mov

After

Storybook showing modal overlay

after.mov

In app showing modal overlay

after.app.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jan 31, 2024
@georgewrmarshall georgewrmarshall self-assigned this Jan 31, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 31, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall marked this pull request as ready for review January 31, 2024 18:13
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner January 31, 2024 18:13
@georgewrmarshall georgewrmarshall mentioned this pull request Jan 31, 2024
Merged
13 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd34bc5) 68.27% compared to head (cb3c22d) 68.27%.
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22756   +/-   ##
========================================
  Coverage    68.27%   68.27%           
========================================
  Files         1087     1087           
  Lines        42770    42770           
  Branches     11371    11371           
========================================
  Hits         29201    29201           
  Misses       13569    13569

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 31, 2024

Builds ready [cb3c22d]
Page Load Metrics (755 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint96160110168
domContentLoaded10261642
load7068727553919
domInteractive10261642
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 45 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall georgewrmarshall merged commit 374cddd into develop Jan 31, 2024
@georgewrmarshall georgewrmarshall deleted the fix/22171/missing-overlay branch January 31, 2024 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@NidhiKJha NidhiKJha NidhiKJha approved these changes

@garrettbear garrettbear Awaiting requested review from garrettbear

Assignees

@georgewrmarshall georgewrmarshall

Labels

release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-design-system All issues relating to design system in Extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@georgewrmarshall @metamaskbot @DDDDDanica @NidhiKJha