Skip to content

fix: Blockaid What's New os theme -> dark mode#22649

Merged
digiwand merged 1 commit intodevelopfrom
fix-blockaid-whats-new-png-dark-mode-support-2
Jan 24, 2024
Merged

fix: Blockaid What's New os theme -> dark mode#22649
digiwand merged 1 commit intodevelopfrom
fix-blockaid-whats-new-png-dark-mode-support-2

Conversation

@digiwand
Copy link
Copy Markdown
Contributor

@digiwand digiwand commented Jan 24, 2024

Description

Fix Blockaid What's New image when user setting is OS and their OS setting is dark mode

Related issues

Fixes: #22646
Related to: #22613

Manual testing steps

  1. Have a new instance of the wallet to populate the What's New modal
  2. Test the UI with different settings and when OS is light and dark mode

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner January 24, 2024 02:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 24, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand added the team-confirmations-secure-ux-PR PRs from the confirmations team label Jan 24, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (874f63c) 68.12% compared to head (ccfbac4) 68.13%.
Report is 6 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22649   +/-   ##
========================================
  Coverage    68.12%   68.13%           
========================================
  Files         1087     1087           
  Lines        42663    42661    -2     
  Branches     11349    11348    -1     
========================================
- Hits         29064    29063    -1     
+ Misses       13599    13598    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 24, 2024

Builds ready [ccfbac4]
Page Load Metrics (790 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint99140115115
domContentLoaded10291752
load7159647905225
domInteractive10291752
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -14 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@digiwand digiwand merged commit 01b9a1a into develop Jan 24, 2024
@digiwand digiwand deleted the fix-blockaid-whats-new-png-dark-mode-support-2 branch January 24, 2024 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
@metamaskbot metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

+1 more reviewer

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.10.0 Issue or pull request that will be included in release 11.10.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Theme set to os cause display wrong themed image in What's New

4 participants

@digiwand @metamaskbot @jpuri @blackdevelopa