Signature-Request refactor#19104
Merged
cryptotavares merged 39 commits intodevelopfrom Jul 20, 2023
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
georgewrmarshall
left a comment
There was a problem hiding this comment.
Hey @NiranjanaBinoy, this might be out of scope of this ticket but you could use a few more component-library components which would bring this component up to date with the UI :)
Contributor
georgewrmarshall
left a comment
There was a problem hiding this comment.
Left some suggestions. I would even suggest leaving out the h tags if it passes e2e tests they don't seem semantically correct to me. It's probably fine for the default p tag to be used
jpuri
reviewed
May 16, 2023
jpuri
reviewed
May 16, 2023
jpuri
reviewed
May 16, 2023
jpuri
reviewed
May 16, 2023
jpuri
reviewed
May 16, 2023
jpuri
reviewed
May 16, 2023
dfa866e to
e865101
Compare
Collaborator
Builds ready [f087b93]
Page Load Metrics (1597 ± 51 ms)
Bundle size diffs
|
blackdevelopa
approved these changes
Jul 20, 2023
Member
|
the PR looks good from QA side @NiranjanaBinoy 🔥 |
cryptotavares
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #17245
Explanation
Refactored https://github.com/MetaMask/metamask-extension/blob/develop/ui/components/app/signature-request/signature-request.component.js component:
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.