Update Text import paths: /app by georgewrmarshall · Pull Request #20083 · MetaMask/metamask-extension

georgewrmarshall · 2023-07-18T23:26:25Z

Explanation

Currently, there are deprecated instances of the Text component that use the JavaScript version of the Box component. This PR updates those deprecated import paths to the new component in the ui/components/app folder as well as snapshots. There should be no visual or component API difference between the two. Just className changes which will touch many snapshots

Part of Update deprecated Text import paths #19986

Dependency: Updating Text component to use TS Box #19949

Manual Testing Steps

Go to the latest build of storybook in this PR
Check all components don't have visual regressions against the hosted storybook GitHub page

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-07-18T23:26:36Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-07-19T00:03:11Z

Builds ready [f0c6bf6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1482 ± 19 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	108	143	119	9	4
		domContentLoaded	1400	1577	1482	39	19
		load	1400	1577	1482	39	19
		domInteractive	1400	1577	1482	39	19

Bundle size diffs

background: 0 bytes
ui: -5704 bytes
common: 0 bytes

codecov · 2023-07-19T00:03:53Z

Codecov Report

Merging #20083 (fbcbfb8) into develop (f9649a2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20083   +/-   ##
========================================
  Coverage    69.46%   69.46%           
========================================
  Files          992      992           
  Lines        37452    37452           
  Branches     10042    10042           
========================================
  Hits         26013    26013           
  Misses       11439    11439

Impacted Files	Coverage Δ
ui/components/app/add-network/add-network.js	`56.25% <ø> (ø)`
...nced-gas-fee-defaults/advanced-gas-fee-defaults.js	`100.00% <ø> (ø)`
...ed-gas-fee-gas-limit/advanced-gas-fee-gas-limit.js	`100.00% <ø> (ø)`
...s/app/approve-content-card/approve-content-card.js	`75.00% <ø> (ø)`
ui/components/app/beta-header/index.js	`100.00% <ø> (ø)`
...p/cancel-speedup-popover/cancel-speedup-popover.js	`78.12% <ø> (ø)`
ui/components/app/confirm-data/confirm-data.js	`93.75% <ø> (ø)`
...m-legacy-gas-display/confirm-legacy-gas-display.js	`93.55% <ø> (ø)`
.../components/app/confirm-hexdata/confirm-hexdata.js	`88.89% <ø> (ø)`
...page-container/confirm-page-container.component.js	`68.85% <ø> (ø)`
... and 44 more

DDDDDanica · 2023-07-19T16:51:11Z

LGTM !

metamaskbot · 2023-07-19T17:30:17Z

Builds ready [dd09a03]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1604 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	110	258	137	31	15
		domContentLoaded	1460	1811	1604	86	41
		load	1460	1811	1604	86	41
		domInteractive	1460	1811	1604	85	41

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -5.52 KiB (-0.07%)
common: 0 Bytes (0.00%)

metamaskbot · 2023-07-19T19:31:04Z

Builds ready [fbcbfb8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1641 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	117	175	138	18	9
		domContentLoaded	1492	1967	1640	136	65
		load	1493	1967	1641	138	66
		domInteractive	1492	1967	1640	136	65

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -5.36 KiB (-0.07%)
common: 0 Bytes (0.00%)

georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 18, 2023

georgewrmarshall self-assigned this Jul 18, 2023

georgewrmarshall mentioned this pull request Jul 18, 2023

Update deprecated Text import paths #19986

Closed

georgewrmarshall marked this pull request as ready for review July 19, 2023 01:12

georgewrmarshall requested review from a team as code owners July 19, 2023 01:12

georgewrmarshall added the needs-ux-ds-review label Jul 19, 2023

georgewrmarshall requested a review from garrettbear July 19, 2023 01:12

NidhiKJha previously approved these changes Jul 19, 2023

View reviewed changes

DDDDDanica previously approved these changes Jul 19, 2023

View reviewed changes

georgewrmarshall dismissed stale reviews from DDDDDanica and NidhiKJha via dd09a03 July 19, 2023 16:50

georgewrmarshall force-pushed the part/19986/update-text-import-paths-app branch from f0c6bf6 to dd09a03 Compare July 19, 2023 16:50

DDDDDanica previously approved these changes Jul 19, 2023

View reviewed changes

georgewrmarshall requested a review from NidhiKJha July 19, 2023 17:23

Mrtenz previously approved these changes Jul 19, 2023

View reviewed changes

georgewrmarshall added 4 commits July 19, 2023 11:35

Updating import paths

6ecb36a

Updating snapshots

ec45f90

Fixing lint issues

d41e978

Updating snapshots

fbcbfb8

georgewrmarshall dismissed stale reviews from Mrtenz and DDDDDanica via fbcbfb8 July 19, 2023 18:38

georgewrmarshall force-pushed the part/19986/update-text-import-paths-app branch from dd09a03 to fbcbfb8 Compare July 19, 2023 18:38

georgewrmarshall requested a review from Mrtenz July 19, 2023 20:03

georgewrmarshall requested a review from DDDDDanica July 19, 2023 20:03

DDDDDanica approved these changes Jul 19, 2023

View reviewed changes

garrettbear approved these changes Jul 19, 2023

View reviewed changes

Mrtenz approved these changes Jul 19, 2023

View reviewed changes

georgewrmarshall merged commit bf61322 into develop Jul 19, 2023

georgewrmarshall deleted the part/19986/update-text-import-paths-app branch July 19, 2023 22:32

github-actions Bot locked and limited conversation to collaborators Jul 19, 2023

metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 19, 2023

Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Text import paths: /app#20083

Update Text import paths: /app#20083
georgewrmarshall merged 4 commits intodevelopfrom
part/19986/update-text-import-paths-app

georgewrmarshall commented Jul 18, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 18, 2023

Uh oh!

metamaskbot commented Jul 19, 2023

Uh oh!

codecov Bot commented Jul 19, 2023 •

edited

Loading

Uh oh!

DDDDDanica commented Jul 19, 2023

Uh oh!

metamaskbot commented Jul 19, 2023

Uh oh!

metamaskbot commented Jul 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

georgewrmarshall commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jul 18, 2023

Uh oh!

metamaskbot commented Jul 19, 2023

Uh oh!

codecov Bot commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DDDDDanica commented Jul 19, 2023

Uh oh!

metamaskbot commented Jul 19, 2023

Uh oh!

metamaskbot commented Jul 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

georgewrmarshall commented Jul 18, 2023 •

edited

Loading

codecov Bot commented Jul 19, 2023 •

edited

Loading