e2e test for action metrics#18347
Merged
pedronfigueiredo merged 8 commits intodevelopfrom May 4, 2023
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [cac60c4]
Page Load Metrics (1600 ± 66 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #18347 +/- ##
===========================================
- Coverage 65.15% 64.82% -0.33%
===========================================
Files 936 930 -6
Lines 35965 35763 -202
Branches 9231 9191 -40
===========================================
- Hits 23432 23181 -251
- Misses 12533 12582 +49 |
8cbb436 to
4709c6f
Compare
Collaborator
Builds ready [4709c6f]
Page Load Metrics (1777 ± 84 ms)
Bundle size diffs
|
4709c6f to
45ad225
Compare
Collaborator
Builds ready [45ad225]
Page Load Metrics (1587 ± 38 ms)
Bundle size diffs
|
Collaborator
Builds ready [ed240b0]
Page Load Metrics (1593 ± 49 ms)
Bundle size diffs
|
a15ab4e to
fe6c719
Compare
Collaborator
Builds ready [fe6c719]
Page Load Metrics (1914 ± 126 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
fe6c719 to
475baa9
Compare
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
|
Collaborator
Builds ready [475baa9]
Page Load Metrics (1495 ± 54 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
475baa9 to
c851d8f
Compare
Collaborator
Builds ready [c851d8f]
Page Load Metrics (1516 ± 42 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
reviewed
Apr 28, 2023
darkwing
reviewed
Apr 28, 2023
darkwing
previously approved these changes
Apr 28, 2023
67e83a6 to
af487f4
Compare
429ce64 to
879b366
Compare
Collaborator
Builds ready [879b366]
Page Load Metrics (1529 ± 99 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
879b366 to
6d4f1e5
Compare
Collaborator
Builds ready [6d4f1e5]
Page Load Metrics (1585 ± 62 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
danjm
reviewed
May 2, 2023
danjm
previously approved these changes
May 2, 2023
Contributor
danjm
left a comment
There was a problem hiding this comment.
LGTM!
I asked a question. Might be worth adding a code comment on that sentry mock, but this is not a blocker
Gudahtt
reviewed
May 2, 2023
development/build/index.js
Outdated
| 'stateHooks', | ||
| 'sentryHooks', | ||
| 'sentry', | ||
| 'JSON', |
Member
There was a problem hiding this comment.
Hmm. This will have a significant impact upon the production bundle. Making this change in a PR that appears to be test-focused is potentially misleading.
When creating a changelog, we might reasonably look at this PR and conclude no functional changes were made.
Contributor
There was a problem hiding this comment.
I believe these lines can now be removed as they were added to #18989
DDDDDanica
previously approved these changes
May 2, 2023
brad-decker
suggested changes
May 2, 2023
Contributor
brad-decker
left a comment
There was a problem hiding this comment.
Requesting changes to block merge until @Gudahtt 's comment is resolved
dcccf65 to
dc6d451
Compare
Collaborator
Builds ready [dc6d451]
Page Load Metrics (1571 ± 54 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
brad-decker
suggested changes
May 3, 2023
development/build/index.js
Outdated
| 'stateHooks', | ||
| 'sentryHooks', | ||
| 'sentry', | ||
| 'JSON', |
Contributor
There was a problem hiding this comment.
I believe these lines can now be removed as they were added to #18989
62f30ec to
c4a4a03
Compare
c4a4a03 to
710e61e
Compare
DDDDDanica
approved these changes
May 3, 2023
Collaborator
Builds ready [710e61e]
Page Load Metrics (1752 ± 75 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
End to end tests for this PR #18346